public_git/tart
1
0
Fork 0
mirror of https://github.com/cirruslabs/tart.git synced 2026-09-30 03:01:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Allow to specify custom image in benchmarks (#941)

Browse Source
This commit is contained in:
Fedor Korotkov
2024-11-08 16:41:05 +00:00
committed by GitHub
parent 02f94720c5
commit cd0f238a67
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
benchmark/README.md
+1 -1
View File
@@ -5,7 +5,7 @@ Tart comes with a Golang-based benchmarking utility that allows one to easily co
Currently, only Flexible I/O tester workloads are supported. To run them, [install Golang](https://go.dev/) and run the following command from this (`benchmark/`) directory: Currently, only Flexible I/O tester workloads are supported. To run them, [install Golang](https://go.dev/) and run the following command from this (`benchmark/`) directory:
```shell ```shell
go run cmd/main.go fio go run cmd/main.go fio --image ghcr.io/cirruslabs/macos-sonoma-base:latest
``` ```
You can also enable the debugging output to diagnose issues: You can also enable the debugging output to diagnose issues:
benchmark/internal/command/fio/fio.go
+3 -1
View File
@@ -15,6 +15,7 @@ import (
) )
var debug bool var debug bool
var image string
func NewCommand() *cobra.Command { func NewCommand() *cobra.Command {
cmd := &cobra.Command{ cmd := &cobra.Command{
@@ -24,6 +25,7 @@ func NewCommand() *cobra.Command {
} }
cmd.Flags().BoolVar(&debug, "debug", false, "enable debug logging") cmd.Flags().BoolVar(&debug, "debug", false, "enable debug logging")
cmd.Flags().StringVar(&image, "image", "ghcr.io/cirruslabs/macos-sonoma-base:latest", "image to use for testing")
return cmd return cmd
} }
@@ -111,7 +113,7 @@ func initializeExecutors(ctx context.Context, logger *zap.Logger) ([]executor.Ex
logger.Info("initializing Tart executor") logger.Info("initializing Tart executor")
tart, err := tart.New(ctx, logger) tart, err := tart.New(ctx, image, logger)
if err != nil { if err != nil {
return nil, err return nil, err
} }
benchmark/internal/executor/tart/tart.go
+3 -5
View File
@@ -14,8 +14,6 @@ import (
"time" "time"
) )
const baseImage = "ghcr.io/cirruslabs/macos-sonoma-base:latest"
type Tart struct { type Tart struct {
vmRunCancel context.CancelFunc vmRunCancel context.CancelFunc
vmName string vmName string
@@ -23,17 +21,17 @@ type Tart struct {
logger *zap.Logger logger *zap.Logger
} }
func New(ctx context.Context, logger *zap.Logger) (*Tart, error) { func New(ctx context.Context, image string, logger *zap.Logger) (*Tart, error) {
tart := &Tart{ tart := &Tart{
vmName: fmt.Sprintf("tart-benchmark-%s", uuid.NewString()), vmName: fmt.Sprintf("tart-benchmark-%s", uuid.NewString()),
logger: logger, logger: logger,
} }
if err := Cmd(ctx, tart.logger, "pull", baseImage); err != nil { if err := Cmd(ctx, tart.logger, "pull", image); err != nil {
return nil, err return nil, err
} }
if err := Cmd(ctx, tart.logger, "clone", baseImage, tart.vmName); err != nil { if err := Cmd(ctx, tart.logger, "clone", image, tart.vmName); err != nil {
return nil, err return nil, err
} }
benchmark/internal/executor/tart/tart_test.go
+1 -1
View File
@@ -11,7 +11,7 @@ import (
func TestTart(t *testing.T) { func TestTart(t *testing.T) {
ctx := context.Background() ctx := context.Background()
tart, err := tart.New(ctx, zap.NewNop()) tart, err := tart.New(ctx, "ghcr.io/cirruslabs/macos-sonoma-base:latest", zap.NewNop())
require.NoError(t, err) require.NoError(t, err)
output, err := tart.Run(ctx, "echo \"this is a test\"") output, err := tart.Run(ctx, "echo \"this is a test\"")