fix redundant appending of infrastructure roles

2020-11-04 15:49:38 +01:00 · 2020-11-04 15:49:38 +01:00 · f41111f1c3
parent db0d089e75
commit f41111f1c3
1 changed files with 1 additions and 3 deletions
--- a/pkg/controller/util.go
+++ b/pkg/controller/util.go
@ -341,9 +341,7 @@ func (c *Controller) getInfrastructureRole(
 				util.Coalesce(string(secretData[infraRole.RoleKey]), infraRole.DefaultRoleValue))
 		}

-		if roleDescr.Valid() {
-			roles = append(roles, *roleDescr)
-		} else {
+		if !roleDescr.Valid() {
 			msg := "infrastructure role %q is not complete and ignored"
 			c.logger.Warningf(msg, roleDescr)