From ca129eb9daab748f322f40cd45cc5c5a5ec86272 Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov <sergey.dudoladov@zalando.de>
Date: Thu, 7 Jan 2021 15:39:48 +0100
Subject: [PATCH] move error messages out of retry

---
 pkg/cluster/pod.go | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/pkg/cluster/pod.go b/pkg/cluster/pod.go
index d05e923db..fc79a9239 100644
--- a/pkg/cluster/pod.go
+++ b/pkg/cluster/pod.go
@@ -321,17 +321,16 @@ func (c *Cluster) isSafeToRecreatePods(pods *v1.PodList) bool {
 				state, err = c.patroni.GetPatroniMemberState(&pod)
 
 				if err != nil {
-					c.logger.Errorf("failed to get Patroni state for pod: %s", err)
 					return false, err
 				} else if state == "creating replica" {
-					c.logger.Warningf("cannot re-create replica %s: it is currently being initialized", pod.Name)
-					return false, nil
+					return false, fmt.Errorf("cannot re-create replica %s: it is currently being initialized", pod.Name)
 				}
 				return true, nil
 			},
 		)
 
 		if err != nil {
+			c.logger.Errorf("failed to get Patroni state for pod: %s", err)
 			return false
 		}