Merge pull request #240 from zalando-incubator/feature/goreport-improvements

Some improvements for golint, ineffassign and misspell
This commit is contained in:
Dmitry Dolgov
2018-02-22 11:31:08 +01:00
committed by GitHub
8 changed files with 31 additions and 36 deletions
+3 -3
View File
@@ -275,9 +275,9 @@ func (c *Cluster) tolerations(tolerationsSpec *[]v1.Toleration) []v1.Toleration
Effect: v1.TaintEffect(podToleration["effect"]),
},
}
} else {
return []v1.Toleration{}
}
return []v1.Toleration{}
}
func (c *Cluster) generatePodTemplate(
@@ -376,7 +376,7 @@ func (c *Cluster) generatePodTemplate(
var names []string
// handle environment variables from the PodEnvironmentConfigMap. We don't use envSource here as it is impossible
// to track any changes to the object envSource points to. In order to emulate the envSource behavior, however, we
// need to make sure that PodConfigMap variables doesn't override those we set explicitely from the configuration
// need to make sure that PodConfigMap variables doesn't override those we set explicitly from the configuration
// parameters
envVarsMap := make(map[string]string)
for _, envVar := range envVars {