From ba67b23ed4fc18204a92d876e69bc3c7a3986275 Mon Sep 17 00:00:00 2001
From: Felix Kunde <felix-kunde@gmx.de>
Date: Wed, 28 Jan 2026 20:03:07 +0100
Subject: [PATCH] fix schema validation and trim \ when unmarshalling
 maintenance window

---
 .../crds/operatorconfigurations.yaml          | 15 +++-----------
 manifests/operatorconfiguration.crd.yaml      | 15 +++-----------
 pkg/apis/acid.zalan.do/v1/crds.go             | 20 +++----------------
 pkg/apis/acid.zalan.do/v1/marshal.go          |  3 ++-
 pkg/apis/acid.zalan.do/v1/util_test.go        |  7 +++++++
 5 files changed, 18 insertions(+), 42 deletions(-)

diff --git a/charts/postgres-operator/crds/operatorconfigurations.yaml b/charts/postgres-operator/crds/operatorconfigurations.yaml
index 0778c0c15..373a295c5 100644
--- a/charts/postgres-operator/crds/operatorconfigurations.yaml
+++ b/charts/postgres-operator/crds/operatorconfigurations.yaml
@@ -102,19 +102,10 @@ spec:
                 type: boolean
                 default: false
               maintenance_windows:
-                type: array
-                nullable: true
                 items:
-                  type: object
-                  properties:
-                    endTime:
-                      type: string
-                    everyday:
-                      type: boolean
-                    startTime:
-                      type: string
-                    weekday:
-                      type: string
+                  pattern: '^\ *((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\d):([0-5]?\d)|(2[0-3]|[01]?\d):([0-5]?\d))-((2[0-3]|[01]?\d):([0-5]?\d)|(2[0-3]|[01]?\d):([0-5]?\d))\ *$'
+                  type: string
+                type: array
               max_instances:
                 type: integer
                 description: "-1 = disabled"
diff --git a/manifests/operatorconfiguration.crd.yaml b/manifests/operatorconfiguration.crd.yaml
index 04104c07b..f792078f5 100644
--- a/manifests/operatorconfiguration.crd.yaml
+++ b/manifests/operatorconfiguration.crd.yaml
@@ -100,19 +100,10 @@ spec:
                 type: boolean
                 default: false
               maintenance_windows:
-                type: array
-                nullable: true
                 items:
-                  type: object
-                  properties:
-                    endTime:
-                      type: string
-                    everyday:
-                      type: boolean
-                    startTime:
-                      type: string
-                    weekday:
-                      type: string
+                  pattern: '^\ *((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\d):([0-5]?\d)|(2[0-3]|[01]?\d):([0-5]?\d))-((2[0-3]|[01]?\d):([0-5]?\d)|(2[0-3]|[01]?\d):([0-5]?\d))\ *$'
+                  type: string
+                type: array
               max_instances:
                 type: integer
                 description: "-1 = disabled"
diff --git a/pkg/apis/acid.zalan.do/v1/crds.go b/pkg/apis/acid.zalan.do/v1/crds.go
index a44ef94a0..2b993a3d2 100644
--- a/pkg/apis/acid.zalan.do/v1/crds.go
+++ b/pkg/apis/acid.zalan.do/v1/crds.go
@@ -128,25 +128,11 @@ var OperatorConfigCRDResourceValidation = apiextv1.CustomResourceValidation{
 						Type: "boolean",
 					},
 					"maintenance_windows": {
-						Type:     "array",
-						Nullable: true,
+						Type: "array",
 						Items: &apiextv1.JSONSchemaPropsOrArray{
 							Schema: &apiextv1.JSONSchemaProps{
-								Type: "object",
-								Properties: map[string]apiextv1.JSONSchemaProps{
-									"end_time": {
-										Type: "string",
-									},
-									"everyday": {
-										Type: "boolean",
-									},
-									"start_time": {
-										Type: "string",
-									},
-									"weekday": {
-										Type: "string",
-									},
-								},
+								Type:    "string",
+								Pattern: "^\\ *((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\\d):([0-5]?\\d)|(2[0-3]|[01]?\\d):([0-5]?\\d))-((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\\d):([0-5]?\\d)|(2[0-3]|[01]?\\d):([0-5]?\\d))\\ *$",
 							},
 						},
 					},
diff --git a/pkg/apis/acid.zalan.do/v1/marshal.go b/pkg/apis/acid.zalan.do/v1/marshal.go
index 9f95753cd..014214fed 100644
--- a/pkg/apis/acid.zalan.do/v1/marshal.go
+++ b/pkg/apis/acid.zalan.do/v1/marshal.go
@@ -31,7 +31,8 @@ func (m *MaintenanceWindow) UnmarshalJSON(data []byte) error {
 		err error
 	)
 
-	parts := strings.Split(string(data), "-")
+	dataStr := strings.Trim(string(data), "\"")
+	parts := strings.Split(dataStr, "-")
 	if len(parts) != 2 {
 		return fmt.Errorf("incorrect maintenance window format")
 	}
diff --git a/pkg/apis/acid.zalan.do/v1/util_test.go b/pkg/apis/acid.zalan.do/v1/util_test.go
index 9f3fe9bde..e060379fd 100644
--- a/pkg/apis/acid.zalan.do/v1/util_test.go
+++ b/pkg/apis/acid.zalan.do/v1/util_test.go
@@ -91,6 +91,13 @@ var maintenanceWindows = []struct {
 		StartTime: mustParseTime("10:00"),
 		EndTime:   mustParseTime("20:00"),
 	}, nil},
+	{"regular every day scenario",
+		[]byte(`"05:00-07:00"`),
+		MaintenanceWindow{
+			Everyday:  true,
+			StartTime: mustParseTime("05:00"),
+			EndTime:   mustParseTime("07:00"),
+		}, nil},
 	{"starts and ends at the same time",
 		[]byte(`"Mon:10:00-10:00"`),
 		MaintenanceWindow{