Respond to code reviews

This commit is contained in:
Sergey Dudoladov 2018-03-16 15:36:42 +01:00
parent 386d7b6bdb
commit 931b48fcbb
2 changed files with 7 additions and 5 deletions

View File

@ -12,7 +12,7 @@ spec:
zalando: zalando:
- superuser - superuser
- createdb - createdb
enableMasterLoadBalancer: true # enableMasterLoadBalancer: true
# enableReplicaLoadBalancer: true # enableReplicaLoadBalancer: true
allowedSourceRanges: # load balancers' source ranges for both master and replica services allowedSourceRanges: # load balancers' source ranges for both master and replica services
- 127.0.0.1/32 - 127.0.0.1/32

View File

@ -94,7 +94,6 @@ type PostgresSpec struct {
Resources `json:"resources,omitempty"` Resources `json:"resources,omitempty"`
TeamID string `json:"teamId"` TeamID string `json:"teamId"`
AllowedSourceRanges []string `json:"allowedSourceRanges"`
DockerImage string `json:"dockerImage,omitempty"` DockerImage string `json:"dockerImage,omitempty"`
// vars that enable load balancers are pointers because it is important to know if any of them is omitted from the Postgres manifest // vars that enable load balancers are pointers because it is important to know if any of them is omitted from the Postgres manifest
@ -103,10 +102,13 @@ type PostgresSpec struct {
EnableReplicaLoadBalancer *bool `json:"enableReplicaLoadBalancer,omitempty"` EnableReplicaLoadBalancer *bool `json:"enableReplicaLoadBalancer,omitempty"`
// deprecated load balancer settings mantained for backward compatibility // deprecated load balancer settings mantained for backward compatibility
// see "Load balancers" operator docs (PR #258) // see "Load balancers" operator docs
UseLoadBalancer *bool `json:"useLoadBalancer,omitempty"` UseLoadBalancer *bool `json:"useLoadBalancer,omitempty"`
ReplicaLoadBalancer *bool `json:"replicaLoadBalancer,omitempty"` ReplicaLoadBalancer *bool `json:"replicaLoadBalancer,omitempty"`
// load balancers' source ranges are the same for master and replica services
AllowedSourceRanges []string `json:"allowedSourceRanges"`
NumberOfInstances int32 `json:"numberOfInstances"` NumberOfInstances int32 `json:"numberOfInstances"`
Users map[string]UserFlags `json:"users"` Users map[string]UserFlags `json:"users"`
MaintenanceWindows []MaintenanceWindow `json:"maintenanceWindows,omitempty"` MaintenanceWindows []MaintenanceWindow `json:"maintenanceWindows,omitempty"`