fix: db row close error be ignored (#2578)

This commit is contained in:
yangw 2024-03-14 19:22:56 +08:00 committed by GitHub
parent 6653b8f9c6
commit 773c0392a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 2 deletions

View File

@ -205,8 +205,12 @@ func (c *Cluster) readPgUsersFromDatabase(userNames []string) (users spec.PgUser
}
defer func() {
if err2 := rows.Close(); err2 != nil {
if err != nil {
err = fmt.Errorf("error when closing query cursor: %v, previous error: %v", err2, err)
} else {
err = fmt.Errorf("error when closing query cursor: %v", err2)
}
}
}()
for rows.Next() {
@ -252,8 +256,12 @@ func findUsersFromRotation(rotatedUsers []string, db *sql.DB) (map[string]string
}
defer func() {
if err2 := rows.Close(); err2 != nil {
if err != nil {
err = fmt.Errorf("error when closing query cursor: %v, previous error: %v", err2, err)
} else {
err = fmt.Errorf("error when closing query cursor: %v", err2)
}
}
}()
for rows.Next() {