pass cluster by reference
This commit is contained in:
parent
356be8f0f1
commit
6e5d7abcc5
|
|
@ -248,7 +248,7 @@ func (c *Cluster) Create(stopCh <-chan struct{}) error {
|
|||
return nil
|
||||
}
|
||||
|
||||
func (c Cluster) sameServiceWith(service *v1.Service) (match bool, reason string) {
|
||||
func (c *Cluster) sameServiceWith(service *v1.Service) (match bool, reason string) {
|
||||
//TODO: improve comparison
|
||||
if !reflect.DeepEqual(c.Service.Spec.LoadBalancerSourceRanges, service.Spec.LoadBalancerSourceRanges) {
|
||||
reason = "new service's LoadBalancerSourceRange doesn't match the current one"
|
||||
|
|
@ -258,7 +258,7 @@ func (c Cluster) sameServiceWith(service *v1.Service) (match bool, reason string
|
|||
return
|
||||
}
|
||||
|
||||
func (c Cluster) sameVolumeWith(volume spec.Volume) (match bool, reason string) {
|
||||
func (c *Cluster) sameVolumeWith(volume spec.Volume) (match bool, reason string) {
|
||||
if !reflect.DeepEqual(c.Spec.Volume, volume) {
|
||||
reason = "new volume's specification doesn't match the current one"
|
||||
} else {
|
||||
|
|
@ -267,7 +267,7 @@ func (c Cluster) sameVolumeWith(volume spec.Volume) (match bool, reason string)
|
|||
return
|
||||
}
|
||||
|
||||
func (c Cluster) compareStatefulSetWith(statefulSet *v1beta1.StatefulSet) (match, needsRollUpdate bool, reason string) {
|
||||
func (c *Cluster) compareStatefulSetWith(statefulSet *v1beta1.StatefulSet) (match, needsRollUpdate bool, reason string) {
|
||||
match = true
|
||||
//TODO: improve me
|
||||
if *c.Statefulset.Spec.Replicas != *statefulSet.Spec.Replicas {
|
||||
|
|
|
|||
Loading…
Reference in New Issue