reflect review
This commit is contained in:
parent
5d58314a16
commit
6da03db41c
|
|
@ -459,6 +459,8 @@ func (c *Cluster) compareStatefulSetWith(statefulSet *appsv1.StatefulSet) *compa
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// we assume any change in priority happens by rolling out a new priority class
|
||||||
|
// changing the priority value in an existing class is not supproted
|
||||||
if c.Statefulset.Spec.Template.Spec.PriorityClassName != statefulSet.Spec.Template.Spec.PriorityClassName {
|
if c.Statefulset.Spec.Template.Spec.PriorityClassName != statefulSet.Spec.Template.Spec.PriorityClassName {
|
||||||
match = false
|
match = false
|
||||||
needsReplace = true
|
needsReplace = true
|
||||||
|
|
@ -466,13 +468,6 @@ func (c *Cluster) compareStatefulSetWith(statefulSet *appsv1.StatefulSet) *compa
|
||||||
reasons = append(reasons, "new statefulset's pod priority class in spec doesn't match the current one")
|
reasons = append(reasons, "new statefulset's pod priority class in spec doesn't match the current one")
|
||||||
}
|
}
|
||||||
|
|
||||||
if c.Statefulset.Spec.Template.Spec.Priority != statefulSet.Spec.Template.Spec.Priority {
|
|
||||||
match = false
|
|
||||||
needsReplace = true
|
|
||||||
needsRollUpdate = true
|
|
||||||
reasons = append(reasons, "new statefulset's pod priority value in spec doesn't match the current one")
|
|
||||||
}
|
|
||||||
|
|
||||||
// lazy Spilo update: modify the image in the statefulset itself but let its pods run with the old image
|
// lazy Spilo update: modify the image in the statefulset itself but let its pods run with the old image
|
||||||
// until they are re-created for other reasons, for example node rotation
|
// until they are re-created for other reasons, for example node rotation
|
||||||
if c.OpConfig.EnableLazySpiloUpgrade && !reflect.DeepEqual(c.Statefulset.Spec.Template.Spec.Containers[0].Image, statefulSet.Spec.Template.Spec.Containers[0].Image) {
|
if c.OpConfig.EnableLazySpiloUpgrade && !reflect.DeepEqual(c.Statefulset.Spec.Template.Spec.Containers[0].Image, statefulSet.Spec.Template.Spec.Containers[0].Image) {
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue