public_git/postgres-operator
1
0
Fork 0
mirror of https://github.com/zalando/postgres-operator.git synced 2026-10-19 11:30:19 +02:00
Code Issues Projects Releases Wiki Activity

code optimization (#1350)

Browse Source 
* pre-allocate cap for slice structure
* if clause is no need because of range, and kubelet also use range
  method to get each capability so there is no side-effect

Signed-off-by: Jeff Zvier <zvier20@gmail.com>
This commit is contained in:
zvier
2021-02-09 09:35:24 +01:00
committed by GitHub
parent 2c3cd3ae02
commit 6aeb92f024
2 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/cluster/k8sres.go
+6 -9
View File
@@ -321,16 +321,13 @@ func getLocalAndBoostrapPostgreSQLParameters(parameters map[string]string) (loca
} }
func generateCapabilities(capabilities []string) v1.Capabilities { func generateCapabilities(capabilities []string) v1.Capabilities {
if len(capabilities) > 0 { additionalCapabilities := make([]v1.Capability, 0, len(capabilities))
additionalCapabilities := []v1.Capability{} for _, capability := range capabilities {
for _, capability := range capabilities { additionalCapabilities = append(additionalCapabilities, v1.Capability(strings.ToUpper(capability)))
additionalCapabilities = append(additionalCapabilities, v1.Capability(strings.ToUpper(capability))) }
} return v1.Capabilities{
return v1.Capabilities{ Add: additionalCapabilities,
Add: additionalCapabilities,
}
} }
return v1.Capabilities{}
} }
func nodeAffinity(nodeReadinessLabel map[string]string, nodeAffinity *v1.NodeAffinity) *v1.Affinity { func nodeAffinity(nodeReadinessLabel map[string]string, nodeAffinity *v1.NodeAffinity) *v1.Affinity {
pkg/cluster/k8sres_test.go
+2 -2
View File
@@ -1502,13 +1502,13 @@ func TestGenerateCapabilities(t *testing.T) {
{ {
subTest: "no capabilities", subTest: "no capabilities",
configured: nil, configured: nil,
capabilities: v1.Capabilities{}, capabilities: v1.Capabilities{Add: []v1.Capability{}},
err: fmt.Errorf("could not parse capabilities configuration of nil"), err: fmt.Errorf("could not parse capabilities configuration of nil"),
}, },
{ {
subTest: "empty capabilities", subTest: "empty capabilities",
configured: []string{}, configured: []string{},
capabilities: v1.Capabilities{}, capabilities: v1.Capabilities{Add: []v1.Capability{}},
err: fmt.Errorf("could not parse empty capabilities configuration"), err: fmt.Errorf("could not parse empty capabilities configuration"),
}, },
{ {