Periodically sync roles with the running clusters. (#102)

The sync adds or alters database roles based on the roles defined
in the cluster's TPR, Team API and operator's infrastructure roles.
At the moment, roles are not deleted, as it would be dangerous for
the robot roles in case TPR is misconfigured. In addition, ALTER
ROLE does not remove role options, i.e. SUPERUSER or CREATEROLE,
neither it removes role membership: only new options are added and
new role membership is granted. So far, options like NOSUPERUSER
and NOCREATEROLE won't be handed correctly, when mixed with the
non-negative counterparts, also NOLOGIN should be processed correctly.
The code assumes that only MD5 passwords are stored in the DB and
will likely break with the new SCRAM auth in PostgreSQL 10.

On the implementation side, create the new interface to abstract
roles merge and creation, move most of the role-based functionality
from cluster/pg into the new 'users' module, strip create user code
of special cases related to human-based users (moving them to init
instead) and fixed the password md5 generator to avoid processing
already encrypted passwords. In addition, moved the system roles
off the slice containing all other roles in order to avoid extra
efforts to avoid creating them.

Also, fix a leak in DB connections when the new connection is not
considered healthy and discarded without being closed. Initialize
the database during the sync phase before syncing users.

pkg/cluster/cluster.go

@@ -26,6 +26,7 @@ import (
 	"github.bus.zalan.do/acid/postgres-operator/pkg/util/constants"
 	"github.bus.zalan.do/acid/postgres-operator/pkg/util/k8sutil"
 	"github.bus.zalan.do/acid/postgres-operator/pkg/util/teams"
+	"github.bus.zalan.do/acid/postgres-operator/pkg/util/users"
 )
 
 var (
@@ -58,6 +59,7 @@ type Cluster struct {
 	Config
 	logger               *logrus.Entry
 	pgUsers              map[string]spec.PgUser
+	systemUsers          map[string]spec.PgUser
 	podEvents            chan spec.PodEvent
 	podSubscribers       map[spec.NamespacedName]chan spec.PodEvent
 	podSubscribersMu     sync.RWMutex
@@ -65,6 +67,7 @@ type Cluster struct {
 	mu                   sync.Mutex
 	masterLess           bool
 	podDispatcherRunning bool
+	userSyncStrategy     spec.UserSyncer
 	deleteOptions        *v1.DeleteOptions
 }
 
@@ -78,11 +81,13 @@ func New(cfg Config, pgSpec spec.Postgresql, logger *logrus.Entry) *Cluster {
 		Postgresql:           pgSpec,
 		logger:               lg,
 		pgUsers:              make(map[string]spec.PgUser),
+		systemUsers:          make(map[string]spec.PgUser),
 		podEvents:            make(chan spec.PodEvent),
 		podSubscribers:       make(map[spec.NamespacedName]chan spec.PodEvent),
 		kubeResources:        kubeResources,
 		masterLess:           false,
 		podDispatcherRunning: false,
+		userSyncStrategy:     users.DefaultUserSyncStrategy{},
 		deleteOptions:        &v1.DeleteOptions{OrphanDependents: &orphanDependents},
 	}
 
@@ -426,12 +431,15 @@ func (c *Cluster) ReceivePodEvent(event spec.PodEvent) {
 }
 
 func (c *Cluster) initSystemUsers() {
-	c.pgUsers[c.OpConfig.SuperUsername] = spec.PgUser{
+	// We don't actually use that to create users, delegating this
+	// task to Patroni. Those definitions are only used to create
+	// secrets, therefore, setting flags like SUPERUSER or REPLICATION
+	// is not necessary here
+	c.systemUsers[constants.SuperuserKeyName] = spec.PgUser{
 		Name:     c.OpConfig.SuperUsername,
 		Password: util.RandomPassword(constants.PasswordLength),
 	}
-
-	c.pgUsers[c.OpConfig.ReplicationUsername] = spec.PgUser{
+	c.systemUsers[constants.ReplicationUserKeyName] = spec.PgUser{
 		Name:     c.OpConfig.ReplicationUsername,
 		Password: util.RandomPassword(constants.PasswordLength),
 	}
@@ -464,7 +472,9 @@ func (c *Cluster) initHumanUsers() error {
 		return fmt.Errorf("Can't get list of team members: %s", err)
 	} else {
 		for _, username := range teamMembers {
-			c.pgUsers[username] = spec.PgUser{Name: username}
+			flags := []string{constants.RoleFlagLogin, constants.RoleFlagSuperuser}
+			memberOf := []string{c.OpConfig.PamRoleName}
+			c.pgUsers[username] = spec.PgUser{Name: username, Flags: flags, MemberOf: memberOf}
 		}
 	}
 
@@ -477,6 +487,11 @@ func (c *Cluster) initInfrastructureRoles() error {
 		if !isValidUsername(username) {
 			return fmt.Errorf("Invalid username: '%s'", username)
 		}
+		if flags, err := normalizeUserFlags(data.Flags); err != nil {
+			return fmt.Errorf("Invalid flags for user '%s': %s", username, err)
+		} else {
+			data.Flags = flags
+		}
 		c.pgUsers[username] = data
 	}
 	return nil