From 510985ffd8d6eced07ff736cf0877213bccddab9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Mu=C3=9Fler?= Date: Tue, 23 Feb 2021 13:20:51 +0100 Subject: [PATCH] Fix patroni test with mock. --- pkg/util/patroni/patroni.go | 2 +- pkg/util/patroni/patroni_test.go | 11 ++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/pkg/util/patroni/patroni.go b/pkg/util/patroni/patroni.go index 7912adde3..b63912e55 100644 --- a/pkg/util/patroni/patroni.go +++ b/pkg/util/patroni/patroni.go @@ -144,7 +144,7 @@ type MemberData struct { State string `json:"state"` Role string `json:"role"` ServerVersion int `json:"server_version"` - PendingRestart string `json:"pending_restart"` + PendingRestart bool `json:"pending_restart"` ClusterUnlocked bool `json:"cluster_unlocked"` Patroni MemberDataPatroni `json:"patroni"` } diff --git a/pkg/util/patroni/patroni_test.go b/pkg/util/patroni/patroni_test.go index 40537aa5e..939270453 100644 --- a/pkg/util/patroni/patroni_test.go +++ b/pkg/util/patroni/patroni_test.go @@ -93,13 +93,18 @@ func TestPatroniAPI(t *testing.T) { } mockClient := mocks.NewMockHTTPClient(ctrl) - mockClient.EXPECT().Get(gomock.Any()).Return(&response) + mockClient.EXPECT().Get(gomock.Any()).Return(&response, nil) p := New(nil, mockClient) - _, err := p.GetMemberData(nil) + pod := v1.Pod{ + Status: v1.PodStatus{ + PodIP: "192.168.100.1", + }, + } + _, err := p.GetMemberData(&pod) if err != nil { - t.Errorf("Could not read Patroni data") + t.Errorf("Could not read Patroni data: %v", err) } }