From 273c8e3bcb92dc61ea6c21dc3c0c420e55988941 Mon Sep 17 00:00:00 2001 From: Sergey Dudoladov Date: Tue, 16 Apr 2019 14:12:23 +0200 Subject: [PATCH] address static checks --- pkg/cluster/sync.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/cluster/sync.go b/pkg/cluster/sync.go index 3fb72fb3d..1d677b089 100644 --- a/pkg/cluster/sync.go +++ b/pkg/cluster/sync.go @@ -540,8 +540,11 @@ func (c *Cluster) syncLogicalBackupJob() error { c.setProcessName("syncing the logical backup job") // operator pod at startup syncs all clusters, logicalBackupJob will be nil at this point - if (c.Postgresql.Spec.EnableLogicalBackup == true) && (c.logicalBackupJob == nil) { + if c.Postgresql.Spec.EnableLogicalBackup && c.logicalBackupJob == nil { c.logicalBackupJob, err = c.generateLogicalBackupJob() + if err != nil { + return fmt.Errorf("could not generate the desired cron job state, presumably during the first Sync on operator pod start-up: %v", err) + } } if job, err = c.KubeClient.CronJobsGetter.CronJobs(c.Namespace).Get(c.logicalBackupJob.Name, metav1.GetOptions{}); err == nil {