From 25a6417d479b6319b307135e2aa22d3f7e3f5694 Mon Sep 17 00:00:00 2001 From: Rafia Sabih Date: Thu, 27 May 2021 14:28:57 +0200 Subject: [PATCH] add more test cases for valid usernames --- pkg/cluster/cluster_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cluster/cluster_test.go b/pkg/cluster/cluster_test.go index df46a38f3..c118e82a4 100644 --- a/pkg/cluster/cluster_test.go +++ b/pkg/cluster/cluster_test.go @@ -920,7 +920,7 @@ func TestCrossNamespacedSecrets(t *testing.T) { func TestValidUsernames(t *testing.T) { testName := "test username validity" - invalidUsernames := []string{"_", ".", ".user", "appspace.", "appspace.user.extra", "user_", "_user", "-user", "user-"} + invalidUsernames := []string{"_", ".", ".user", "appspace.", "appspace.user.extra", "user_", "_user", "-user", "user-", ",", ",user", "user,", "namespace,user"} for _, username := range invalidUsernames { if isValidUsername(username) {