From 22fa0875e2378466aed60eab6c94fe0f807caf2e Mon Sep 17 00:00:00 2001
From: Felix Kunde <felix-kunde@gmx.de>
Date: Thu, 22 Oct 2020 08:44:04 +0200
Subject: [PATCH] add maxLength constraint for CRD (#1175)

* add maxLength constraint for CRD
---
 charts/postgres-operator/crds/postgresqls.yaml |  9 +++++++++
 docs/user.md                                   |  2 +-
 manifests/postgresql.crd.yaml                  |  9 +++++++++
 pkg/apis/acid.zalan.do/v1/crds.go              | 13 ++++++++++++-
 4 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/charts/postgres-operator/crds/postgresqls.yaml b/charts/postgres-operator/crds/postgresqls.yaml
index 0d444e568..488f17c2b 100644
--- a/charts/postgres-operator/crds/postgresqls.yaml
+++ b/charts/postgres-operator/crds/postgresqls.yaml
@@ -57,6 +57,7 @@ spec:
       required:
         - kind
         - apiVersion
+        - metadata
         - spec
       properties:
         kind:
@@ -67,6 +68,14 @@ spec:
           type: string
           enum:
             - acid.zalan.do/v1
+        metadata:
+          type: object
+          required:
+            - name
+          properties:
+            name:
+              type: string
+              maxLength: 53
         spec:
           type: object
           required:
diff --git a/docs/user.md b/docs/user.md
index a4b1424b8..9a9e01b9a 100644
--- a/docs/user.md
+++ b/docs/user.md
@@ -49,7 +49,7 @@ Note, that the name of the cluster must start with the `teamId` and `-`. At
 Zalando we use team IDs (nicknames) to lower the chance of duplicate cluster
 names and colliding entities. The team ID would also be used to query an API to
 get all members of a team and create [database roles](#teams-api-roles) for
-them.
+them. Besides, the maximum cluster name length is 53 characters.
 
 ## Watch pods being created
 
diff --git a/manifests/postgresql.crd.yaml b/manifests/postgresql.crd.yaml
index 97b72a8ca..56c010739 100644
--- a/manifests/postgresql.crd.yaml
+++ b/manifests/postgresql.crd.yaml
@@ -53,6 +53,7 @@ spec:
       required:
         - kind
         - apiVersion
+        - metadata
         - spec
       properties:
         kind:
@@ -63,6 +64,14 @@ spec:
           type: string
           enum:
             - acid.zalan.do/v1
+        metadata:
+          type: object
+          required:
+            - name
+          properties:
+            name:
+              type: string
+              maxLength: 53
         spec:
           type: object
           required:
diff --git a/pkg/apis/acid.zalan.do/v1/crds.go b/pkg/apis/acid.zalan.do/v1/crds.go
index 2cfc28856..a7d9bccf0 100644
--- a/pkg/apis/acid.zalan.do/v1/crds.go
+++ b/pkg/apis/acid.zalan.do/v1/crds.go
@@ -107,12 +107,13 @@ var min0 = 0.0
 var min1 = 1.0
 var min2 = 2.0
 var minDisable = -1.0
+var maxLength = int64(53)
 
 // PostgresCRDResourceValidation to check applied manifest parameters
 var PostgresCRDResourceValidation = apiextv1beta1.CustomResourceValidation{
 	OpenAPIV3Schema: &apiextv1beta1.JSONSchemaProps{
 		Type:     "object",
-		Required: []string{"kind", "apiVersion", "spec"},
+		Required: []string{"kind", "apiVersion", "metadata", "spec"},
 		Properties: map[string]apiextv1beta1.JSONSchemaProps{
 			"kind": {
 				Type: "string",
@@ -130,6 +131,16 @@ var PostgresCRDResourceValidation = apiextv1beta1.CustomResourceValidation{
 					},
 				},
 			},
+			"metadata": {
+				Type:     "object",
+				Required: []string{"name"},
+				Properties: map[string]apiextv1beta1.JSONSchemaProps{
+					"name": {
+						Type:      "string",
+						MaxLength: &maxLength,
+					},
+				},
+			},
 			"spec": {
 				Type:     "object",
 				Required: []string{"numberOfInstances", "teamId", "postgresql", "volume"},