public_git
/
postgres-operator
mirror of https://github.com/zalando/postgres-operator.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Avoid reading the namespace file every time the NamespacedName value is decoded. (#243)

This commit is contained in:
Oleksii Kliukin 2018-02-20 17:41:11 +01:00 committed by GitHub
parent b0549c3c9c
commit 1f71c8d72f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/spec/types.go
View File

@ -154,6 +154,9 @@ type ControllerConfig struct {
Namespace string Namespace string
} }
// cached value for the GetOperatorNamespace
var operatorNamespace string
func (n NamespacedName) String() string { func (n NamespacedName) String() string {
return types.NamespacedName(n).String() return types.NamespacedName(n).String()
} }
@ -192,11 +195,12 @@ func (n *NamespacedName) DecodeWorker(value, operatorNamespace string) error {
// GetOperatorNamespace assumes serviceaccount secret is mounted by kubernetes // GetOperatorNamespace assumes serviceaccount secret is mounted by kubernetes
// Placing this func here instead of pgk/util avoids circular import // Placing this func here instead of pgk/util avoids circular import
func GetOperatorNamespace() string { func GetOperatorNamespace() string {
if operatorNamespace == "" {
operatorNamespaceBytes, err := ioutil.ReadFile(fileWithNamespace) operatorNamespaceBytes, err := ioutil.ReadFile(fileWithNamespace)
if err != nil { if err != nil {
log.Fatalf("Unable to detect operator namespace from within its pod due to: %v", err) log.Fatalf("Unable to detect operator namespace from within its pod due to: %v", err)
}
operatorNamespace = string(operatorNamespaceBytes)
} }
return operatorNamespace
return string(operatorNamespaceBytes)
} }