Address code review by @zerg-junior

- new info messages, rename the annotation flag.
This commit is contained in:
Oleksii Kliukin
2018-05-15 16:50:03 +02:00
parent 0c616a802f
commit 11d568bf65
4 changed files with 14 additions and 4 deletions
+7 -2
View File
@@ -131,8 +131,13 @@ func SameService(cur, new *v1.Service) (match bool, reason string) {
oldELBAnnotation := cur.Annotations[constants.ElbTimeoutAnnotationName]
newELBAnnotation := new.Annotations[constants.ElbTimeoutAnnotationName]
if oldDNSAnnotation != newDNSAnnotation || oldELBAnnotation != newELBAnnotation {
return false, fmt.Sprintf("new service's %q annotation doesn't match the current one", constants.ZalandoDNSNameAnnotation)
if oldDNSAnnotation != newDNSAnnotation {
return false, fmt.Sprintf("new service's %q annotation value %q doesn't match the current one %q",
constants.ZalandoDNSNameAnnotation, newDNSAnnotation, oldDNSAnnotation)
}
if oldELBAnnotation != newELBAnnotation {
return false, fmt.Sprintf("new service's %q annotation value %q doesn't match the current one %q",
constants.ElbTimeoutAnnotationName, oldELBAnnotation, newELBAnnotation)
}
return true, ""