public_git
/
postgres-operator
mirror of https://github.com/zalando/postgres-operator.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

add SET ROLE to extension SQL commands

This commit is contained in:
Felix Kunde 2021-06-23 11:16:30 +02:00
parent 71f1e97306
commit 03bf9f7a81
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/cluster/database.go
View File

@ -36,8 +36,8 @@ const (
createDatabaseSQL = `CREATE DATABASE "%s" OWNER "%s";` createDatabaseSQL = `CREATE DATABASE "%s" OWNER "%s";`
createDatabaseSchemaSQL = `SET ROLE TO "%s"; CREATE SCHEMA IF NOT EXISTS "%s" AUTHORIZATION "%s"` createDatabaseSchemaSQL = `SET ROLE TO "%s"; CREATE SCHEMA IF NOT EXISTS "%s" AUTHORIZATION "%s"`
alterDatabaseOwnerSQL = `ALTER DATABASE "%s" OWNER TO "%s";` alterDatabaseOwnerSQL = `ALTER DATABASE "%s" OWNER TO "%s";`
createExtensionSQL = `CREATE EXTENSION IF NOT EXISTS "%s" SCHEMA "%s"` createExtensionSQL = `SET ROLE TO "%s"; CREATE EXTENSION IF NOT EXISTS "%s" SCHEMA "%s"`
alterExtensionSQL = `ALTER EXTENSION "%s" SET SCHEMA "%s"` alterExtensionSQL = `SET ROLE TO "%s"; ALTER EXTENSION "%s" SET SCHEMA "%s"`
globalDefaultPrivilegesSQL = `SET ROLE TO "%s"; globalDefaultPrivilegesSQL = `SET ROLE TO "%s";
ALTER DEFAULT PRIVILEGES GRANT USAGE ON SCHEMAS TO "%s","%s"; ALTER DEFAULT PRIVILEGES GRANT USAGE ON SCHEMAS TO "%s","%s";
@ -504,22 +504,22 @@ func (c *Cluster) getExtensions() (dbExtensions map[string]string, err error) {
// executeCreateExtension creates new extension in the given schema. // executeCreateExtension creates new extension in the given schema.
// The caller is responsible for opening and closing the database connection. // The caller is responsible for opening and closing the database connection.
func (c *Cluster) executeCreateExtension(extName, schemaName string) error { func (c *Cluster) executeCreateExtension(extName, schemaName, schemaOwner string) error {
return c.execCreateOrAlterExtension(extName, schemaName, createExtensionSQL, return c.execCreateOrAlterExtension(extName, schemaName, schemaOwner, createExtensionSQL,
"creating extension", "create extension") "creating extension", "create extension")
} }
// executeAlterExtension changes the schema of the given extension. // executeAlterExtension changes the schema of the given extension.
// The caller is responsible for opening and closing the database connection. // The caller is responsible for opening and closing the database connection.
func (c *Cluster) executeAlterExtension(extName, schemaName string) error { func (c *Cluster) executeAlterExtension(extName, schemaName, schemaOwner string) error {
return c.execCreateOrAlterExtension(extName, schemaName, alterExtensionSQL, return c.execCreateOrAlterExtension(extName, schemaName, schemaOwner, alterExtensionSQL,
"changing schema for extension", "alter extension schema") "changing schema for extension", "alter extension schema")
} }
func (c *Cluster) execCreateOrAlterExtension(extName, schemaName, statement, doing, operation string) error { func (c *Cluster) execCreateOrAlterExtension(extName, schemaName, schemaOwner, statement, doing, operation string) error {
c.logger.Infof("%s %q schema %q", doing, extName, schemaName) c.logger.Infof("%s %q schema %q", doing, extName, schemaName)
if _, err := c.pgDb.Exec(fmt.Sprintf(statement, extName, schemaName)); err != nil { if _, err := c.pgDb.Exec(fmt.Sprintf(statement, schemaOwner, extName, schemaName)); err != nil {
return fmt.Errorf("could not execute %s: %v", operation, err) return fmt.Errorf("could not execute %s: %v", operation, err)
} }

4
pkg/cluster/sync.go
View File

@ -833,7 +833,7 @@ func (c *Cluster) syncExtensions(databaseName string, extensions map[string]stri
} }
for extName, schema := range createExtensions { for extName, schema := range createExtensions {
if err = c.executeCreateExtension(extName, schema); err != nil { if err = c.executeCreateExtension(extName, schema, databaseName+constants.OwnerRoleNameSuffix); err != nil {
return err return err
} }
// grant privileges on objects created by the extension to default database roles // grant privileges on objects created by the extension to default database roles
@ -846,7 +846,7 @@ func (c *Cluster) syncExtensions(databaseName string, extensions map[string]stri
} }
} }
for extName, schema := range alterExtensions { for extName, schema := range alterExtensions {
if err = c.executeAlterExtension(extName, schema); err != nil { if err = c.executeAlterExtension(extName, schema, databaseName+constants.OwnerRoleNameSuffix); err != nil {
return err return err
} }
} }