mirror of
https://github.com/cirruslabs/orchard.git
synced 2026-10-07 23:41:33 +02:00
Fedor Korotkov
86f0afb5a3
* Small timout for worker notification It seems at the moment if a worker re-establishes notify stream (for example, if network flips or proxy breaks the connection) then we can see "no worker registered with this name" errors. This change makes Notifier to wait for 30 seconds before failing, at the time of calling `Notifier#Notify` we know such worker exists. PS not sure if we need to make the timeout configurable. * Wait via context * Make sure all `context`s for `Notify` is time bounded * Lint issues
77 lines
2.0 KiB
Go
77 lines
2.0 KiB
Go
package controller
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"github.com/cirruslabs/orchard/internal/responder"
|
|
v1 "github.com/cirruslabs/orchard/pkg/resource/v1"
|
|
"github.com/cirruslabs/orchard/rpc"
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/google/uuid"
|
|
"net/http"
|
|
"strconv"
|
|
"time"
|
|
)
|
|
|
|
func (controller *Controller) ip(ctx *gin.Context) responder.Responder {
|
|
if responder := controller.authorize(ctx, v1.ServiceAccountRoleComputeWrite); responder != nil {
|
|
return responder
|
|
}
|
|
|
|
// Retrieve and parse path and query parameters
|
|
name := ctx.Param("name")
|
|
|
|
waitRaw := ctx.DefaultQuery("wait", "0")
|
|
wait, err := strconv.ParseUint(waitRaw, 10, 16)
|
|
if err != nil {
|
|
return responder.Code(http.StatusBadRequest)
|
|
}
|
|
waitDuration := time.Duration(wait) * time.Second
|
|
waitContext, waitContextCancel := context.WithTimeout(ctx, waitDuration)
|
|
defer waitContextCancel()
|
|
|
|
// Look-up the VM
|
|
vm, responderImpl := controller.waitForVM(waitContext, name)
|
|
if responderImpl != nil {
|
|
return responderImpl
|
|
}
|
|
|
|
// Send an IP resolution request and wait for the result
|
|
session := uuid.New().String()
|
|
boomerangConnCh, cancel := controller.ipRendezvous.Request(ctx, session)
|
|
defer cancel()
|
|
|
|
err = controller.workerNotifier.Notify(waitContext, vm.Worker, &rpc.WatchInstruction{
|
|
Action: &rpc.WatchInstruction_ResolveIpAction{
|
|
ResolveIpAction: &rpc.WatchInstruction_ResolveIP{
|
|
Session: session,
|
|
VmUid: vm.UID,
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
controller.logger.Warnf("failed to request VM's IP from the worker %s: %v",
|
|
vm.Worker, err)
|
|
|
|
return responder.Code(http.StatusServiceUnavailable)
|
|
}
|
|
|
|
select {
|
|
case rendezvousResponse := <-boomerangConnCh:
|
|
if rendezvousResponse.ErrorMessage != "" {
|
|
return responder.Error(fmt.Errorf("VM's IP resolution on the worker %s failed: %s",
|
|
vm.Worker, rendezvousResponse.ErrorMessage))
|
|
}
|
|
|
|
result := struct {
|
|
IP string `json:"ip"`
|
|
}{
|
|
IP: rendezvousResponse.Result,
|
|
}
|
|
|
|
return responder.JSON(http.StatusOK, &result)
|
|
case <-ctx.Done():
|
|
return responder.Error(ctx.Err())
|
|
}
|
|
}
|