public_git
/
orchard
mirror of https://github.com/cirruslabs/orchard.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor VM listing logic: rename variables for clarity and update error messages

This commit is contained in:
Fedor Korotkov 2026-02-05 11:39:35 +01:00
parent f07ed68a84
commit fda1376ab2
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/controller/api_vms.go
View File

@ -312,7 +312,7 @@ func (controller *Controller) listVMs(ctx *gin.Context) responder.Responder {
}
}
allVMs, err, _ := controller.single.Do("list-vms", func() (interface{}, error) {
computedVMs, err, _ := controller.single.Do("list-vms", func() (interface{}, error) {
var vms []v1.VM
viewErr := controller.store.View(func(txn storepkg.Transaction) (err error) {
@ -327,16 +327,16 @@ func (controller *Controller) listVMs(ctx *gin.Context) responder.Responder {
return responder.Error(err)
}
vmList, ok := allVMs.([]v1.VM)
allVMs, ok := computedVMs.([]v1.VM)
if !ok {
controller.logger.Errorf("failed to cast list-vms result to []v1.VM: %T", allVMs)
controller.logger.Errorf("failed to compute vms: %T", computedVMs)
return responder.Code(http.StatusInternalServerError)
}
vms := make([]v1.VM, 0, len(vmList))
vms := make([]v1.VM, 0, len(allVMs))
Outer:
for _, vm := range vmList {
for _, vm := range allVMs {
for _, filter := range filters {
if !vm.Match(filter) {
continue Outer