public_git/orchard
1
0
Fork 0
mirror of https://github.com/cirruslabs/orchard.git synced 2026-09-29 19:41:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

/exec API: drop session reconnection support (#487)

Browse Source
This commit is contained in:
edi-oai
2026-09-09 08:05:08 +01:00
committed by GitHub
parent 9ac6ca6326
commit 4cd43d2b5a
14 changed files with 106 additions and 1880 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/client/vms.go
-4
View File
@@ -71,7 +71,6 @@ type ExecSessionOptions struct {
Env map[string]string
Workdir string
WaitSeconds uint16
Session string
}
func (service *VMsService) Create(ctx context.Context, vm *v1.VM) error {
@@ -253,9 +252,6 @@ func (service *VMsService) ExecSession(
if options.Workdir != "" {
params["workdir"] = options.Workdir
}
if options.Session != "" {
params["session"] = options.Session
}
return service.client.wsRequestRaw(ctx, fmt.Sprintf("vms/%s/exec", url.PathEscape(name)),
params)
pkg/client/vms_test.go
+1 -3
View File
@@ -20,7 +20,7 @@ func TestHTTPClientForWebSocketHonorsWait(t *testing.T) {
require.Same(t, devClient.httpClient.Transport, httpClient.Transport)
}
func TestExecSessionBuildsReconnectableQuery(t *testing.T) {
func TestExecSessionBuildsQuery(t *testing.T) {
var query map[string][]string
server := httptest.NewServer(
@@ -51,7 +51,6 @@ func TestExecSessionBuildsReconnectableQuery(t *testing.T) {
Env: map[string]string{"GREETING": "hello"},
Workdir: "/tmp",
WaitSeconds: 7,
Session: "resume-me",
})
require.NoError(t, err)
defer conn.CloseNow()
@@ -64,5 +63,4 @@ func TestExecSessionBuildsReconnectableQuery(t *testing.T) {
require.Equal(t, []string{"hello"}, query["env[GREETING]"])
require.Equal(t, []string{"/tmp"}, query["workdir"])
require.Equal(t, []string{"7"}, query[waitParameterName])
require.Equal(t, []string{"resume-me"}, query["session"])
}