From f46f7a39f3f1c437893b1d98e3d51434fc45ed41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anderson=20Val=C3=A9rio?= Date: Fri, 27 Dec 2024 12:02:26 -0300 Subject: [PATCH] update test for refresh token change --- pkg/middleware/stored_session.go | 2 +- pkg/middleware/stored_session_test.go | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/pkg/middleware/stored_session.go b/pkg/middleware/stored_session.go index 3d0bdacf..92dbdb4e 100644 --- a/pkg/middleware/stored_session.go +++ b/pkg/middleware/stored_session.go @@ -190,7 +190,7 @@ func (s *storedSessionLoader) refreshSessionIfNeeded(rw http.ResponseWriter, req if err := s.refreshSession(rw, req, session); err != nil { // If a preemptive refresh fails, we still keep the session // if validateSession succeeds. - logger.Errorf("Unable to refresh session: %v", err) + // PICS: We will clean the session if the refresh fails. return fmt.Errorf("unable to refresh session: %v", err) } diff --git a/pkg/middleware/stored_session_test.go b/pkg/middleware/stored_session_test.go index 904c2028..2d3a6f66 100644 --- a/pkg/middleware/stored_session_test.go +++ b/pkg/middleware/stored_session_test.go @@ -295,17 +295,12 @@ var _ = Describe("Stored Session Suite", func() { refreshSession: defaultRefreshFunc, validateSession: defaultValidateFunc, }), - Entry("when the provider refresh fails but validation succeeds", storedSessionLoaderTableInput{ + Entry("when the provider refresh fails", storedSessionLoaderTableInput{ requestHeaders: http.Header{ "Cookie": []string{"_oauth2_proxy=RefreshError"}, }, existingSession: nil, - expectedSession: &sessionsapi.SessionState{ - RefreshToken: "RefreshError", - CreatedAt: &createdPast, - ExpiresOn: &createdFuture, - Lock: &sessionsapi.NoOpLock{}, - }, + expectedSession: nil, store: defaultSessionStore, refreshPeriod: 1 * time.Minute, refreshSession: defaultRefreshFunc,