public_git
/
oauth2-proxy
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use pagewriter to render robots txt page

This commit is contained in:
Joel Speed 2021-03-13 09:55:54 +00:00
parent 9782fc7fa4
commit f3bd61b371
No known key found for this signature in database
GPG Key ID: 6E80578D6751DEFB
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
oauthproxy.go
View File

@ -577,13 +577,7 @@ func (p *OAuthProxy) serveHTTP(rw http.ResponseWriter, req *http.Request) {
// RobotsTxt disallows scraping pages from the OAuthProxy // RobotsTxt disallows scraping pages from the OAuthProxy
func (p *OAuthProxy) RobotsTxt(rw http.ResponseWriter, req *http.Request) { func (p *OAuthProxy) RobotsTxt(rw http.ResponseWriter, req *http.Request) {
_, err := fmt.Fprintf(rw, "User-agent: *\nDisallow: /") p.pageWriter.WriteRobotsTxt(rw, req)
if err != nil {
logger.Printf("Error writing robots.txt: %v", err)
p.ErrorPage(rw, req, http.StatusInternalServerError, err.Error())
return
}
rw.WriteHeader(http.StatusOK)
} }
// ErrorPage writes an error response // ErrorPage writes an error response

2
oauthproxy_test.go
View File

@ -57,7 +57,7 @@ func TestRobotsTxt(t *testing.T) {
req, _ := http.NewRequest("GET", "/robots.txt", nil) req, _ := http.NewRequest("GET", "/robots.txt", nil)
proxy.ServeHTTP(rw, req) proxy.ServeHTTP(rw, req)
assert.Equal(t, 200, rw.Code) assert.Equal(t, 200, rw.Code)
assert.Equal(t, "User-agent: *\nDisallow: /", rw.Body.String()) assert.Equal(t, "User-agent: *\nDisallow: /\n", rw.Body.String())
} }
func TestIsValidRedirect(t *testing.T) { func TestIsValidRedirect(t *testing.T) {