From f16d64ee6732c83cd2c10dde3bdb1a684c484a59 Mon Sep 17 00:00:00 2001 From: Eduardo Vozniak Date: Mon, 2 Oct 2023 12:09:25 -0300 Subject: [PATCH] Removing lint from make test, running in parallel --- .github/workflows/ci.yaml | 7 ++++--- Makefile | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index dc120cf3..9f81d3bf 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -19,7 +19,7 @@ on: jobs: Lint: - name: lint + name: Lint - golangci-lint runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 @@ -33,7 +33,7 @@ jobs: version: v1.54 Tests: - needs: [Lint] + name: Tests - Executing unit tests runs-on: ubuntu-22.04 steps: - name: Checkout @@ -66,7 +66,8 @@ jobs: make test Build: - needs: [Tests] + needs: [Tests, Lint] + name: Build - Building and publishig Docker images runs-on: ubuntu-22.04 outputs: oauth2proxyPRTag: ${{ steps.setVariables.outputs.prTag }} diff --git a/Makefile b/Makefile index 40a23ed6..c9c1433e 100644 --- a/Makefile +++ b/Makefile @@ -88,11 +88,11 @@ verify-generate: generate git diff --exit-code .PHONY: test -test: lint +test: GO111MODULE=on $(GO) test $(TESTCOVER) -v ./... .PHONY: release -release: validate-go-version lint test +release: validate-go-version test BINARY=${BINARY} VERSION=${VERSION} ./dist.sh .PHONY: validate-go-version