From e2755624eccc039c2be7287059df4fc2b7348e8b Mon Sep 17 00:00:00 2001 From: timothy-spencer Date: Mon, 25 Mar 2019 10:03:22 -0700 Subject: [PATCH] made gcp healthcheck test better --- http_test.go | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/http_test.go b/http_test.go index 49e9791d..9b663deb 100644 --- a/http_test.go +++ b/http_test.go @@ -40,32 +40,17 @@ func TestGCPHealthcheckReadiness(t *testing.T) { assert.Equal(t, "OK", rw.Body.String()) } -func TestGCPHealthcheckNotReadiness(t *testing.T) { +func TestGCPHealthcheckNotHealthcheck(t *testing.T) { handler := func(w http.ResponseWriter, req *http.Request) { w.Write([]byte("test")) } h := gcpHealthcheck(http.HandlerFunc(handler)) rw := httptest.NewRecorder() - r, _ := http.NewRequest("GET", "/NOT_readiness_check", nil) + r, _ := http.NewRequest("GET", "/NOT_any_check", nil) r.RemoteAddr = "127.0.0.1" r.Host = "test-server" h.ServeHTTP(rw, r) - assert.NotEqual(t, "OK", rw.Body.String()) -} - -func TestGCPHealthcheckNotLiveness(t *testing.T) { - handler := func(w http.ResponseWriter, req *http.Request) { - w.Write([]byte("test")) - } - - h := gcpHealthcheck(http.HandlerFunc(handler)) - rw := httptest.NewRecorder() - r, _ := http.NewRequest("GET", "/NOT_liveness_check", nil) - r.RemoteAddr = "127.0.0.1" - r.Host = "test-server" - h.ServeHTTP(rw, r) - - assert.NotEqual(t, "OK", rw.Body.String()) + assert.Equal(t, "test", rw.Body.String()) }