From ccd7a91b2bc9b43070cb320d04b8efa9c49284e5 Mon Sep 17 00:00:00 2001 From: Kevin Kreitner Date: Wed, 29 Sep 2021 17:14:31 +0200 Subject: [PATCH] Add more specific error when updating from store --- pkg/middleware/stored_session.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/pkg/middleware/stored_session.go b/pkg/middleware/stored_session.go index f0e39dd7..e5601214 100644 --- a/pkg/middleware/stored_session.go +++ b/pkg/middleware/stored_session.go @@ -132,11 +132,8 @@ func (s *storedSessionLoader) refreshSessionIfNeeded(rw http.ResponseWriter, req // If session was locked, fetch current state, because // it should be updated after lock is released. if wasLocked { - err = s.updateSessionFromStore(req, session) - if err != nil { - logger.Errorf("Unable to load updated session from store: %v", err) - } - return err + logger.Printf("update session from store") + return s.updateSessionFromStore(req, session) } logger.Printf("Refreshing session - User: %s; SessionAge: %s", session.User, session.Age()) @@ -200,11 +197,11 @@ func (s *storedSessionLoader) refreshSession(rw http.ResponseWriter, req *http.R func (s *storedSessionLoader) updateSessionFromStore(req *http.Request, session *sessionsapi.SessionState) error { sessionStored, err := s.store.Load(req) if err != nil { - return err + return fmt.Errorf("unable to load updated session from store: %v", err) } if session == nil || sessionStored == nil { - return nil + return fmt.Errorf("no session available to udpate from store") } *session = *sessionStored