fix: filter empty strings from allowed groups
When parsing allowed groups from configuration (e.g., via environment variable OAUTH2_PROXY_ALLOWED_GROUPS), viper may include empty strings in the parsed slice when trailing commas are present (e.g., "group2," becomes ["group2", ""]). The setAllowedGroups function now filters out empty strings before adding them to the AllowedGroups map, ensuring that only valid group names are checked during authorization. Fixes #3123
This commit is contained in:
parent
88075737a6
commit
bdac7a6640
|
|
@ -179,7 +179,9 @@ func regexpForRule(rule options.URLParameterRule) string {
|
|||
func (p *ProviderData) setAllowedGroups(groups []string) {
|
||||
p.AllowedGroups = make(map[string]struct{}, len(groups))
|
||||
for _, group := range groups {
|
||||
p.AllowedGroups[group] = struct{}{}
|
||||
if group != "" {
|
||||
p.AllowedGroups[group] = struct{}{}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -102,6 +102,18 @@ func TestProviderDataAuthorize(t *testing.T) {
|
|||
groups: []string{"baz", "foo"},
|
||||
expectedAuthZ: false,
|
||||
},
|
||||
{
|
||||
name: "AllowedGroupsWithEmptyString",
|
||||
allowedGroups: []string{"group2", ""},
|
||||
groups: []string{"group1", "group2"},
|
||||
expectedAuthZ: true,
|
||||
},
|
||||
{
|
||||
name: "AllowedGroupsOnlyEmptyString",
|
||||
allowedGroups: []string{""},
|
||||
groups: []string{"group1", "group2"},
|
||||
expectedAuthZ: true,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range testCases {
|
||||
|
|
|
|||
Loading…
Reference in New Issue