public_git/oauth2-proxy
1
0
Fork 0
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git synced 2026-10-18 13:18:26 +02:00
Code Issues Projects Releases Wiki Activity

feat: add support for setting a unix binding's socket file mode (#3376)

Browse Source 
fix: linter issues and set default unix socket permissions to 0660

Signed-off-by: Jan Larwig <jan@larwig.com>
Co-authored-by: Tristan <tristan@mangadex.org>
This commit is contained in:
Jan Larwig
2026-03-19 00:08:50 +08:00
committed by GitHub
co-authored by Tristan
parent cdbdb1128d
commit 9ae0b325a6
6 changed files with 113 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/proxyhttp/server_test.go
+50
View File
@@ -28,6 +28,8 @@ var _ = Describe("Server", func() {
expectedErr error
expectHTTPListener bool
expectTLSListener bool
expectedSocketMode os.FileMode
socketPath string
fdAddr string
ipv6 bool
}
@@ -57,6 +59,12 @@ var _ = Describe("Server", func() {
s, ok := srv.(*server)
Expect(ok).To(BeTrue())
if in.socketPath != "" {
fileInfo, err := os.Stat(in.socketPath)
Expect(err).ToNot(HaveOccurred())
Expect(fileInfo.Mode().Perm()).To(Equal(in.expectedSocketMode.Perm()))
}
Expect(s.listener != nil).To(Equal(in.expectHTTPListener))
if in.expectHTTPListener {
Expect(s.listener.Close()).To(Succeed())
@@ -648,6 +656,48 @@ var _ = Describe("Server", func() {
expectTLSListener: true,
ipv6: true,
}),
Entry("with a valid unix socket path", &newServerTableInput{
opts: Opts{
Handler: handler,
BindAddress: "unix:///tmp/oauth2-proxy.sock",
},
expectedErr: nil,
expectHTTPListener: true,
expectTLSListener: false,
ipv6: false,
}),
Entry("with a valid unix socket path and a valid socket file mode", &newServerTableInput{
opts: Opts{
Handler: handler,
BindAddress: "unix:///tmp/oauth2-proxy.sock,mode=0777",
},
expectedErr: nil,
expectHTTPListener: true,
expectTLSListener: false,
expectedSocketMode: 0o777,
socketPath: "/tmp/oauth2-proxy.sock",
ipv6: false,
}),
Entry("with a valid unix socket path and a value-less socket file mode argument", &newServerTableInput{
opts: Opts{
Handler: handler,
BindAddress: "unix:///tmp/oauth2-proxy.sock,mode",
},
expectedErr: errors.New("error setting up listener: listen (unix, /tmp/oauth2-proxy.sock,mode) failed: unix socket option mode expects a value"),
expectHTTPListener: false,
expectTLSListener: false,
ipv6: false,
}),
Entry("with a valid unix socket path and an invalid socket file mode value", &newServerTableInput{
opts: Opts{
Handler: handler,
BindAddress: "unix:///tmp/oauth2-proxy.sock,mode=-1",
},
expectedErr: errors.New("error setting up listener: listen (unix, /tmp/oauth2-proxy.sock,mode=-1) failed: unix socket file mode has invalid value -1"),
expectHTTPListener: false,
expectTLSListener: false,
ipv6: false,
}),
)
})