public_git
/
oauth2-proxy
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Ensure Cipher.Encrypt doesn't mangle input data []byte

This commit is contained in:
Nick Meves 2020-05-11 12:33:11 -07:00
parent 7bb5fc0a81
commit 9382293b0b
No known key found for this signature in database
GPG Key ID: 93BA8A3CEDCDD1CF
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/encryption/cipher_test.go
View File

@ -80,20 +80,26 @@ func TestEncryptAndDecrypt(t *testing.T) {
_, err := io.ReadFull(rand.Reader, data) _, err := io.ReadFull(rand.Reader, data)
assert.Equal(t, nil, err) assert.Equal(t, nil, err)
// Ensure our Encrypt function doesn't encrypt in place
immutableData := make([]byte, len(data))
copy(immutableData, data)
encrypted, err := c.Encrypt(data) encrypted, err := c.Encrypt(data)
assert.Equal(t, nil, err) assert.Equal(t, nil, err)
assert.NotEqual(t, encrypted, data) assert.NotEqual(t, encrypted, data)
// Encrypt didn't operate in-place on []byte
assert.Equal(t, data, immutableData)
// Ensure our Decrypt function doesn't decrypt in place // Ensure our Decrypt function doesn't decrypt in place
immutable := make([]byte, len(encrypted)) immutableEnc := make([]byte, len(encrypted))
copy(immutable, encrypted) copy(immutableEnc, encrypted)
decrypted, err := c.Decrypt(encrypted) decrypted, err := c.Decrypt(encrypted)
assert.Equal(t, nil, err) assert.Equal(t, nil, err)
// Original data back // Original data back
assert.Equal(t, data, decrypted) assert.Equal(t, data, decrypted)
// Decrypt didn't operate in-place on []byte // Decrypt didn't operate in-place on []byte
assert.Equal(t, encrypted, immutable) assert.Equal(t, encrypted, immutableEnc)
// Encrypt/Decrypt actually did something // Encrypt/Decrypt actually did something
assert.NotEqual(t, encrypted, decrypted) assert.NotEqual(t, encrypted, decrypted)
}) })