public_git
/
oauth2-proxy
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #447 from Miouge1/master 

Use read_user as default scope for GitLab
This commit is contained in:
Jehiah Czebotar 2017-09-13 10:27:36 -04:00 committed by GitHub
parent e87c3eee13 a32ff08d68
commit 7b26256df6
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
providers/gitlab.go
View File

@ -36,7 +36,7 @@ func NewGitLabProvider(p *ProviderData) *GitLabProvider {
} }
} }
if p.Scope == "" { if p.Scope == "" {
p.Scope = "api" p.Scope = "read_user"
} }
return &GitLabProvider{ProviderData: p} return &GitLabProvider{ProviderData: p}
} }

2
providers/gitlab_test.go
View File

@ -53,7 +53,7 @@ func TestGitLabProviderDefaults(t *testing.T) {
p.Data().RedeemURL.String()) p.Data().RedeemURL.String())
assert.Equal(t, "https://gitlab.com/api/v3/user", assert.Equal(t, "https://gitlab.com/api/v3/user",
p.Data().ValidateURL.String()) p.Data().ValidateURL.String())
assert.Equal(t, "api", p.Data().Scope) assert.Equal(t, "read_user", p.Data().Scope)
} }
func TestGitLabProviderOverrides(t *testing.T) { func TestGitLabProviderOverrides(t *testing.T) {