public_git
/
oauth2-proxy
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use const for delay and expire time

This commit is contained in:
Kevin Kreitner 2021-09-29 12:01:16 +02:00 committed by Joel Speed
parent 0f545e14d4
commit 76e3cb3e9a
No known key found for this signature in database
GPG Key ID: 6E80578D6751DEFB
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/middleware/stored_session.go
View File

@ -14,6 +14,11 @@ import (
"github.com/oauth2-proxy/oauth2-proxy/v7/providers" "github.com/oauth2-proxy/oauth2-proxy/v7/providers"
) )
const (
SessionLockExpireTime = 5 * time.Second
SessionLockPeekDelay = 50 * time.Millisecond
)
// StoredSessionLoaderOptions contains all of the requirements to construct // StoredSessionLoaderOptions contains all of the requirements to construct
// a stored session loader. // a stored session loader.
// All options must be provided. // All options must be provided.
@ -137,7 +142,7 @@ func (s *storedSessionLoader) refreshSession(rw http.ResponseWriter, req *http.R
for isLocked, err = session.PeekLock(req.Context()); isLocked; isLocked, err = session.PeekLock(req.Context()) { for isLocked, err = session.PeekLock(req.Context()); isLocked; isLocked, err = session.PeekLock(req.Context()) {
wasLocked = true wasLocked = true
// delay next peek lock // delay next peek lock
time.Sleep(50 * time.Millisecond) time.Sleep(SessionLockPeekDelay)
} }
if err != nil { if err != nil {
@ -160,7 +165,7 @@ func (s *storedSessionLoader) refreshSession(rw http.ResponseWriter, req *http.R
return nil return nil
} }
err = session.ObtainLock(req.Context(), 5*time.Second) err = session.ObtainLock(req.Context(), SessionLockExpireTime)
if err != nil { if err != nil {
logger.Errorf("unable to obtain lock (skipping refresh): %v", err) logger.Errorf("unable to obtain lock (skipping refresh): %v", err)
return nil return nil