public_git
/
oauth2-proxy
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update LinkedIn provider validate URL (#1444) 

* update LinkedIn validate URL

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>

* update changelog

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>

* update failed unit test

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
This commit is contained in:
Jeeva Kandasamy 2021-11-20 03:06:33 +05:30 committed by GitHub
parent 0693856bc3
commit 6e54ac2745
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -10,6 +10,7 @@
- [#1433](https://github.com/oauth2-proxy/oauth2-proxy/pull/1433) Let authentication fail when session validation fails (@stippi2) - [#1433](https://github.com/oauth2-proxy/oauth2-proxy/pull/1433) Let authentication fail when session validation fails (@stippi2)
- [#1445](https://github.com/oauth2-proxy/oauth2-proxy/pull/1445) Fix docker container multi arch build issue by passing GOARCH details to make build (@jkandasa) - [#1445](https://github.com/oauth2-proxy/oauth2-proxy/pull/1445) Fix docker container multi arch build issue by passing GOARCH details to make build (@jkandasa)
- [#1444](https://github.com/oauth2-proxy/oauth2-proxy/pull/1444) Update LinkedIn provider validate URL (@jkandasa)
# V7.2.0 # V7.2.0

9
providers/linkedin.go
View File

@ -46,6 +46,13 @@ var (
Host: "api.linkedin.com", Host: "api.linkedin.com",
Path: "/v2/emailAddress", Path: "/v2/emailAddress",
} }
// Default Validate URL for LinkedIn.
linkedinDefaultValidateURL = &url.URL{
Scheme: "https",
Host: "api.linkedin.com",
Path: "/v2/me",
}
) )
// NewLinkedInProvider initiates a new LinkedInProvider // NewLinkedInProvider initiates a new LinkedInProvider
@ -55,7 +62,7 @@ func NewLinkedInProvider(p *ProviderData) *LinkedInProvider {
loginURL: linkedinDefaultLoginURL, loginURL: linkedinDefaultLoginURL,
redeemURL: linkedinDefaultRedeemURL, redeemURL: linkedinDefaultRedeemURL,
profileURL: linkedinDefaultProfileURL, profileURL: linkedinDefaultProfileURL,
validateURL: linkedinDefaultProfileURL, validateURL: linkedinDefaultValidateURL,
scope: linkedinDefaultScope, scope: linkedinDefaultScope,
}) })
return &LinkedInProvider{ProviderData: p} return &LinkedInProvider{ProviderData: p}

2
providers/linkedin_test.go
View File

@ -54,7 +54,7 @@ func TestNewLinkedInProvider(t *testing.T) {
g.Expect(providerData.LoginURL.String()).To(Equal("https://www.linkedin.com/oauth/v2/authorization")) g.Expect(providerData.LoginURL.String()).To(Equal("https://www.linkedin.com/oauth/v2/authorization"))
g.Expect(providerData.RedeemURL.String()).To(Equal("https://www.linkedin.com/uas/oauth2/accessToken")) g.Expect(providerData.RedeemURL.String()).To(Equal("https://www.linkedin.com/uas/oauth2/accessToken"))
g.Expect(providerData.ProfileURL.String()).To(Equal("https://api.linkedin.com/v2/emailAddress")) g.Expect(providerData.ProfileURL.String()).To(Equal("https://api.linkedin.com/v2/emailAddress"))
g.Expect(providerData.ValidateURL.String()).To(Equal("https://api.linkedin.com/v2/emailAddress")) g.Expect(providerData.ValidateURL.String()).To(Equal("https://api.linkedin.com/v2/me"))
g.Expect(providerData.Scope).To(Equal("r_emailaddress r_liteprofile")) g.Expect(providerData.Scope).To(Equal("r_emailaddress r_liteprofile"))
} }