From 57a8ef06b48f1e92c32c4a7ffba13761bfd49809 Mon Sep 17 00:00:00 2001 From: Nick Meves Date: Thu, 26 Nov 2020 11:53:41 -0800 Subject: [PATCH] Fix method renaming in comments and tests --- providers/oidc_test.go | 2 +- providers/provider_default.go | 3 +-- providers/provider_default_test.go | 7 +++++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/providers/oidc_test.go b/providers/oidc_test.go index a4048d89..54df1b31 100644 --- a/providers/oidc_test.go +++ b/providers/oidc_test.go @@ -299,7 +299,7 @@ func TestOIDCProviderRefreshSessionIfNeededWithIdToken(t *testing.T) { assert.Equal(t, refreshToken, existingSession.RefreshToken) } -func TestCreateSessionStateFromBearerToken(t *testing.T) { +func TestOIDCProviderCreateSessionFromToken(t *testing.T) { const profileURLEmail = "janed@me.com" testCases := map[string]struct { diff --git a/providers/provider_default.go b/providers/provider_default.go index 415cdd73..e7f00917 100644 --- a/providers/provider_default.go +++ b/providers/provider_default.go @@ -124,8 +124,7 @@ func (p *ProviderData) RefreshSessionIfNeeded(_ context.Context, _ *sessions.Ses return false, nil } -// CreateSessionStateFromBearerToken should be implemented to allow providers -// to convert ID tokens into sessions +// CreateSessionFromToken converts Bearer IDTokens into sessions func (p *ProviderData) CreateSessionFromToken(ctx context.Context, token string) (*sessions.SessionState, error) { if p.Verifier != nil { return middleware.CreateTokenToSessionFunc(p.Verifier.Verify)(ctx, token) diff --git a/providers/provider_default_test.go b/providers/provider_default_test.go index 5f02ecbb..df1525cf 100644 --- a/providers/provider_default_test.go +++ b/providers/provider_default_test.go @@ -49,10 +49,13 @@ func TestAcrValuesConfigured(t *testing.T) { assert.Contains(t, result, "acr_values=testValue") } -func TestEnrichSessionState(t *testing.T) { +func TestProviderDataEnrichSession(t *testing.T) { + g := NewWithT(t) p := &ProviderData{} s := &sessions.SessionState{} - assert.NoError(t, p.EnrichSession(context.Background(), s)) + + err := p.EnrichSession(context.Background(), s) + g.Expect(err).ToNot(HaveOccurred()) } func TestProviderDataAuthorize(t *testing.T) {