Merge pull request #1039 from oauth2-proxy/fix-test-logging

Ensure errors in tests are logged to the GinkgoWriter

CHANGELOG.md

@@ -8,6 +8,8 @@
 
 ## Changes since v7.0.1
 
+- [#1039](https://github.com/oauth2-proxy/oauth2-proxy/pull/1039) Ensure errors in tests are logged to the GinkgoWriter (@JoelSpeed)
+
 # V7.0.1
 
 ## Release Highlights

main_suite_test.go

@@ -10,6 +10,7 @@ import (
 
 func TestMainSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Main Suite")

pkg/apis/middleware/middleware_suite_test.go

@@ -13,6 +13,7 @@ import (
 // this functionality
 func TestMiddlewareSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Middleware API")

pkg/apis/options/options_suite_test.go

@@ -10,6 +10,7 @@ import (
 
 func TestOptionsSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Options Suite")

pkg/apis/options/util/util_suite_test.go

@@ -10,6 +10,7 @@ import (
 
 func TestUtilSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Options Util Suite")

pkg/authentication/basic/basic_suite_test.go

@@ -10,6 +10,7 @@ import (
 
 func TestBasicSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Basic")

pkg/header/header_suite_test.go

@@ -17,6 +17,7 @@ var (
 
 func TestHeaderSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Header")

pkg/middleware/middleware_suite_test.go

@@ -11,6 +11,7 @@ import (
 
 func TestMiddlewareSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Middleware")

pkg/requests/requests_suite_test.go

@@ -21,6 +21,7 @@ var (
 
 func TestRequetsSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 	log.SetOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)

pkg/requests/util/util_suite_test.go

@@ -13,6 +13,7 @@ import (
 // this functionality
 func TestRequestUtilSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Request Utils")

pkg/sessions/cookie/session_store_test.go

@@ -19,6 +19,8 @@ import (
 
 func TestSessionStore(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
+
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Cookie SessionStore")
 }

pkg/sessions/persistence/persistence_suite_test.go

@@ -10,6 +10,8 @@ import (
 
 func TestPersistenceSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
+
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Persistence")
 }

pkg/sessions/redis/redis_store_test.go

@@ -33,6 +33,7 @@ func (l *wrappedRedisLogger) Printf(_ context.Context, format string, v ...inter
 
 func TestSessionStore(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	redisLogger := &wrappedRedisLogger{Logger: log.New(os.Stderr, "redis: ", log.LstdFlags|log.Lshortfile)}
 	redisLogger.SetOutput(GinkgoWriter)

pkg/sessions/session_store_test.go

@@ -18,6 +18,7 @@ import (
 
 func TestSessionStore(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "SessionStore")

pkg/upstream/upstream_suite_test.go

@@ -26,6 +26,7 @@ var (
 
 func TestUpstreamSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 	log.SetOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)

pkg/validation/validation_suite_test.go

@@ -10,6 +10,7 @@ import (
 
 func TestValidationSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Validation Suite")

providers/providers_suite_test.go

@@ -10,6 +10,7 @@ import (
 
 func TestProviderSuite(t *testing.T) {
 	logger.SetOutput(GinkgoWriter)
+	logger.SetErrOutput(GinkgoWriter)
 
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Providers")