From 44236f0314ebaeed8d9f57ece7e2ab05a80b81e6 Mon Sep 17 00:00:00 2001 From: artificiosus Date: Mon, 23 Mar 2026 05:27:49 -0400 Subject: [PATCH] fix: do not log error for backend logout 204 (#3381) * Don't log error for backend logout 204 Signed-off-by: artificiosus * doc: add changelog entry for #3381 Signed-off-by: Jan Larwig * refactor: use http.StatusOK and http.StatusNoContent instead of integers Signed-off-by: Jan Larwig --------- Signed-off-by: artificiosus Signed-off-by: Jan Larwig Co-authored-by: Jan Larwig --- CHANGELOG.md | 1 + oauthproxy.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index aabc1385..9cffcc91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ - [#3382](https://github.com/oauth2-proxy/oauth2-proxy/pull/3382) chore(deps): update gomod and golangci/golangci-lint to v2.11.4 (@tuunit) - [#3374](https://github.com/oauth2-proxy/oauth2-proxy/pull/3374) fix: handle Unix socket RemoteAddr in IP resolution (@H1net) +- [#3381](https://github.com/oauth2-proxy/oauth2-proxy/pull/3381) fix: do not log error for backend logout 204 (@artificiosus) ## Release Highlights diff --git a/oauthproxy.go b/oauthproxy.go index f260acc6..3efe66fd 100644 --- a/oauthproxy.go +++ b/oauthproxy.go @@ -798,7 +798,7 @@ func (p *OAuthProxy) backendLogout(rw http.ResponseWriter, req *http.Request) { } defer resp.Body.Close() - if resp.StatusCode != 200 { + if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNoContent { logger.Errorf("error while calling backend logout url, returned error code %v", resp.StatusCode) } }