apply review suggestions
This commit is contained in:
parent
31a4c34726
commit
202de3a05e
2
main.go
2
main.go
|
|
@ -70,7 +70,7 @@ func main() {
|
|||
func loadConfiguration(config, yamlConfig string, extraFlags *pflag.FlagSet, args []string) (*options.Options, error) {
|
||||
opts, err := loadLegacyOptions(config, extraFlags, args)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
return nil, fmt.Errorf("couldn't load legacy options: %w", err)
|
||||
}
|
||||
|
||||
if yamlConfig != "" {
|
||||
|
|
|
|||
|
|
@ -83,12 +83,11 @@ func Decode(input interface{}, result interface{}) error {
|
|||
DecodeHook: mapstructure.ComposeDecodeHookFunc(toDurationHookFunc()),
|
||||
Metadata: nil, // Don't track any metadata
|
||||
Result: result, // Decode the result into the prefilled options
|
||||
TagName: "json", // Parse all fields that use the yaml tag
|
||||
TagName: "json", // Parse all fields that use the json tag
|
||||
ZeroFields: false, // Don't clean the default values from the result map (options)
|
||||
ErrorUnused: true, // Throw an error if keys have been used that aren't mapped to any struct fields
|
||||
IgnoreUntaggedFields: true, // Ignore fields in structures that aren't tagged with yaml
|
||||
IgnoreUntaggedFields: true, // Ignore fields in structures that aren't tagged with json
|
||||
})
|
||||
|
||||
if err != nil {
|
||||
return fmt.Errorf("error creating decoder for config: %w", err)
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue