public_git
/
oauth2-proxy
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix tests

This commit is contained in:
Kevin Kreitner 2025-01-12 18:14:29 +01:00 committed by Jan Larwig
parent 5ee1951f03
commit 1441449b81
No known key found for this signature in database
GPG Key ID: C2172BFA220A037A
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
providers/cidaas.go
View File

@ -72,7 +72,7 @@ func (p *CIDAASProvider) EnrichSession(ctx context.Context, s *sessions.SessionS
// Try to get missing emails or groups from a profileURL // Try to get missing emails or groups from a profileURL
if err := p.enrichFromUserinfoEndpoint(ctx, s); err != nil { if err := p.enrichFromUserinfoEndpoint(ctx, s); err != nil {
logger.Errorf("Warning: Profile URL request failed: %w", err) logger.Errorf("Warning: Profile URL request failed: %s", err)
} }
// If a mandatory email wasn't set, error at this point. // If a mandatory email wasn't set, error at this point.

18
providers/cidaas_test.go
View File

@ -5,6 +5,7 @@ import (
"encoding/json" "encoding/json"
"errors" "errors"
"fmt" "fmt"
"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/apis/options"
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
"net/url" "net/url"
@ -46,8 +47,11 @@ func newCidaasProvider(serverURL *url.URL) *CIDAASProvider {
&oidc.Config{ClientID: oidcClientID}, &oidc.Config{ClientID: oidcClientID},
), ),
} }
cfg := options.Provider{
Type: options.CidaasProvider,
}
p := NewCIDAASProvider(providerData) p := NewCIDAASProvider(providerData, cfg)
return p return p
} }
@ -394,7 +398,11 @@ func TestCidaasProvider_EnrichSession(t *testing.T) {
defer server.Close() defer server.Close()
err = provider.EnrichSession(context.Background(), tc.ExistingSession) err = provider.EnrichSession(context.Background(), tc.ExistingSession)
assert.Equal(t, tc.ExpectedError, err) if tc.ExpectedError != nil {
assert.EqualError(t, err, tc.ExpectedError.Error())
} else {
assert.NoError(t, err)
}
assert.Equal(t, *tc.ExpectedSession, *tc.ExistingSession) assert.Equal(t, *tc.ExpectedSession, *tc.ExistingSession)
}) })
} }
@ -471,7 +479,11 @@ func TestCidaasProvider_RefreshSession(t *testing.T) {
var refreshed bool var refreshed bool
refreshed, err = provider.RefreshSession(context.Background(), tc.ExistingSession) refreshed, err = provider.RefreshSession(context.Background(), tc.ExistingSession)
assert.Equal(t, tc.ExpectedError, err) if tc.ExpectedError != nil {
assert.EqualError(t, err, tc.ExpectedError.Error())
} else {
assert.NoError(t, err)
}
assert.Equal(t, tc.ExpectedRefreshed, refreshed) assert.Equal(t, tc.ExpectedRefreshed, refreshed)
assert.Equal(t, tc.ExpectedEmail, tc.ExistingSession.Email) assert.Equal(t, tc.ExpectedEmail, tc.ExistingSession.Email)
assert.Equal(t, tc.ExpectedUser, tc.ExistingSession.User) assert.Equal(t, tc.ExpectedUser, tc.ExistingSession.User)