Nikolay1 and Claude Opus 4.8
bf7eba8898
room-library: Theben-benchmark corrections (dogfood on 5 official ETS examples)
...
Ran KNX Association-ecosystem vendor (Theben) 5 official ETS example .knxproj
through our QA. Findings folded back into the product:
- repair.py _infer_dpt: relative dimming (Brighter/darker, heller/dunkler,
светлее/темнее) now infers 3.007 DPT_Control_Dimming instead of falling to
1.001; explicit '% / value' stays 5.001; scene checked before the broad
value branch. DPTs verified against XKNX/xknx via deepwiki.
- room_library.py: new reusable blocks distilled from vendor patterns —
shutter_venetian (slat + slat-status + wind/frost safety-lock), climate_floor
modulating actuating-value + status, ventilation (airing stage + CO2 +
humidity), lighting_dali, multisensor_air, central scene/all-off/all-on.
- project.py classifier: airing/Lüftung/проветривание -> hvac (was unknown).
- analyze.py: safety_input_no_status INFO exemption for write-only wind/frost
lock inputs (Theben central wind-safety pattern).
- SCHEMA.md: new function rows; automation_intents implementation: knx|external
with safety_related => knx rule; DPT-tolerance note (missing-DPT hard error
applies to generated output; ETS4 object-derived DPT on import is legitimate).
- templates: ventilation slot (bathroom/kitchen), opt-in venetian + wind/frost
safety intent (living/bedroom), new house-level central.yaml.
- tests: +test_theben_corrections.py (10); golden bedroom 26->28 GA (climate
actuating-value). pytest 20 passed (pre-existing unrelated test_protocol
collection error untouched). senior-code-audit: APPROVED.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-07-16 11:21:18 +02:00
Nikolay1 and Claude Opus 4.8
9b337a4882
room-library R1: tests (golden RU/EN, idempotency, invariance, round-trip, oracle)
...
tests/test_room_library.py covers all R1-required cases: exact golden RU/EN
object maps for one template; idempotency; room permutation invariance;
sub-address exhaustion raising a clear error; round-trip (generated house ->
load_project -> 0 errors AND 0 warnings across validate_naming /
detect_missing_status / detect_dpt_issues / check_policy); a hand-written
negative-oracle manifest vs fact; plus per-slot preset override, template
rejection and BOM proposal checks.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-07-15 21:26:23 +02:00
