From aca10bf343e8412b0be7ccc063fa82f8bd83aeca Mon Sep 17 00:00:00 2001 From: Florian Winkler Date: Fri, 10 Jun 2022 11:13:43 +0200 Subject: [PATCH] There was no option to set the volumeBindingMode for the StorageClass. Added the option in nfs-subdir-external-provisioner/charts/nfs-subdir-external-provisioner/templates/storageclass.yaml and nfs-subdir-external-provisioner/charts/nfs-subdir-external-provisioner/values.yaml as well as updated charts/nfs-subdir-external-provisioner/README.md This fixes Issue #172 --- charts/nfs-subdir-external-provisioner/README.md | 1 + .../templates/storageclass.yaml | 1 + charts/nfs-subdir-external-provisioner/values.yaml | 3 +++ 3 files changed, 5 insertions(+) diff --git a/charts/nfs-subdir-external-provisioner/README.md b/charts/nfs-subdir-external-provisioner/README.md index 411703dd..9e58ffb7 100644 --- a/charts/nfs-subdir-external-provisioner/README.md +++ b/charts/nfs-subdir-external-provisioner/README.md @@ -65,6 +65,7 @@ The following tables lists the configurable parameters of this chart and their d | `storageClass.onDelete` | Strategy on PVC deletion. Overrides archiveOnDelete when set to lowercase values 'delete' or 'retain' | null | | `storageClass.pathPattern` | Specifies a template for the directory name | null | | `storageClass.accessModes` | Set access mode for PV | `ReadWriteOnce` | +| `storageClass.volumeBindingMode` | Set volume binding mode for Storage Class | `Immediate` | | `storageClass.annotations` | Set additional annotations for the StorageClass | `{}` | | `leaderElection.enabled` | Enables or disables leader election | `true` | | `nfs.server` | Hostname of the NFS server (required) | null (ip or hostname) | diff --git a/charts/nfs-subdir-external-provisioner/templates/storageclass.yaml b/charts/nfs-subdir-external-provisioner/templates/storageclass.yaml index 698d32b9..fc360cef 100644 --- a/charts/nfs-subdir-external-provisioner/templates/storageclass.yaml +++ b/charts/nfs-subdir-external-provisioner/templates/storageclass.yaml @@ -15,6 +15,7 @@ metadata: provisioner: {{ template "nfs-subdir-external-provisioner.provisionerName" . }} allowVolumeExpansion: {{ .Values.storageClass.allowVolumeExpansion }} reclaimPolicy: {{ .Values.storageClass.reclaimPolicy }} +volumeBindingMode: {{ .Values.storageClass.volumeBindingMode }} parameters: archiveOnDelete: "{{ .Values.storageClass.archiveOnDelete }}" {{- if .Values.storageClass.pathPattern }} diff --git a/charts/nfs-subdir-external-provisioner/values.yaml b/charts/nfs-subdir-external-provisioner/values.yaml index e7d4a78d..f6260238 100644 --- a/charts/nfs-subdir-external-provisioner/values.yaml +++ b/charts/nfs-subdir-external-provisioner/values.yaml @@ -51,6 +51,9 @@ storageClass: # Set access mode - ReadWriteOnce, ReadOnlyMany or ReadWriteMany accessModes: ReadWriteOnce + # Set volume bindinng mode - Immediate or WaitForFirstConsumer + volumeBindingMode: Immediate + # Storage class annotations annotations: {}