diff --git a/pkg/configuration/base/reconcile_test.go b/pkg/configuration/base/reconcile_test.go index c36e1ae9..2c39c175 100644 --- a/pkg/configuration/base/reconcile_test.go +++ b/pkg/configuration/base/reconcile_test.go @@ -445,7 +445,6 @@ func Test_compareEnv(t *testing.T) { var actual []corev1.EnvVar got := compareEnv(expected, actual) - assert.True(t, got) }) t.Run("same", func(t *testing.T) { diff --git a/pkg/configuration/base/reconciler.go b/pkg/configuration/base/reconciler.go index 0e033594..431aec8a 100644 --- a/pkg/configuration/base/reconciler.go +++ b/pkg/configuration/base/reconciler.go @@ -264,7 +264,7 @@ func compareMap(expected, actual map[string]string) bool { } func compareEnv(expected, actual []corev1.EnvVar) bool { - actualEnv := []corev1.EnvVar{} + var actualEnv []corev1.EnvVar for _, env := range actual { if env.Name == "KUBERNETES_PORT_443_TCP_ADDR" || env.Name == "KUBERNETES_PORT" || env.Name == "KUBERNETES_PORT_443_TCP" || env.Name == "KUBERNETES_SERVICE_HOST" { @@ -289,7 +289,7 @@ func CompareContainerVolumeMounts(expected corev1.Container, actual corev1.Conta // compareVolumes returns true if Jenkins pod and Jenkins CR volumes are the same func (r *JenkinsBaseConfigurationReconciler) compareVolumes(actualPod corev1.Pod) bool { - toCompare := []corev1.Volume{} + var toCompare []corev1.Volume for _, volume := range actualPod.Spec.Volumes { // filter out service account if strings.HasPrefix(volume.Name, actualPod.Spec.ServiceAccountName) {