public_git/kubernetes-operator
1
0
Fork 0
mirror of https://github.com/jenkinsci/kubernetes-operator.git synced 2026-10-22 07:02:58 +02:00
Code Issues Releases Wiki Activity

Change signature of CreateOrUpdateJob function

Browse Source
This commit is contained in:
Tomasz Sęk
2019-01-17 21:45:23 +01:00
parent 88d4f82e48
commit d318bea4a1
5 changed files with 26 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/controller/jenkins/configuration/user/seedjobs/seedjobs.go
+4 -1
View File
@@ -63,10 +63,13 @@ func (s *SeedJobs) EnsureSeedJobs(jenkins *virtuslabv1alpha1.Jenkins) (done bool
// createJob is responsible for creating jenkins job which configures jenkins seed jobs and deploy keys
func (s *SeedJobs) createJob() error {
_, err := s.jenkinsClient.CreateOrUpdateJob(seedJobConfigXML, ConfigureSeedJobsName)
_, created, err := s.jenkinsClient.CreateOrUpdateJob(seedJobConfigXML, ConfigureSeedJobsName)
if err != nil {
return err
}
if created {
s.logger.Info(fmt.Sprintf("'%s' job has been created", ConfigureSeedJobsName))
}
return nil
}
pkg/controller/jenkins/configuration/user/seedjobs/seedjobs_test.go
+2 -2
View File
@@ -47,7 +47,7 @@ func TestEnsureSeedJobs(t *testing.T) {
jenkinsClient.
EXPECT().
CreateOrUpdateJob(seedJobConfigXML, ConfigureSeedJobsName).
Return(nil, nil)
Return(nil, true, nil)
jenkinsClient.
EXPECT().
@@ -69,7 +69,7 @@ func TestEnsureSeedJobs(t *testing.T) {
jenkinsClient.
EXPECT().
CreateOrUpdateJob(seedJobConfigXML, ConfigureSeedJobsName).
Return(nil, nil)
Return(nil, false, nil)
jenkinsClient.
EXPECT().