From ae31901022f36b3cf3e1b86658d91bac98b757d9 Mon Sep 17 00:00:00 2001 From: antoniaklja Date: Mon, 14 Jan 2019 19:14:57 +0100 Subject: [PATCH] Minor improvements, code quality --- test/e2e/user_configuration_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/e2e/user_configuration_test.go b/test/e2e/user_configuration_test.go index aafa66a6..6a954847 100644 --- a/test/e2e/user_configuration_test.go +++ b/test/e2e/user_configuration_test.go @@ -33,18 +33,22 @@ func TestUserConfiguration(t *testing.T) { func verifyJenkinsSeedJobs(t *testing.T, client *gojenkins.Jenkins, jenkins *virtuslabv1alpha1.Jenkins) { t.Logf("Attempting to get configure seed job status '%v'", seedjobs.ConfigureSeedJobsName) + configureSeedJobs, err := client.GetJob(seedjobs.ConfigureSeedJobsName) assert.NoError(t, err) assert.NotNil(t, configureSeedJobs) build, err := configureSeedJobs.GetLastSuccessfulBuild() + assert.NoError(t, err) assert.NotNil(t, build) seedJobName := "jenkins-operator-configure-seed-job" t.Logf("Attempting to verify if seed job has been created '%v'", seedJobName) seedJob, err := client.GetJob(seedJobName) - assert.NoError(t, err) + assert.NoError(t, err, ) assert.NotNil(t, seedJob) + build, err = seedJob.GetLastSuccessfulBuild() + assert.NoError(t, err) assert.NotNil(t, build) err = framework.Global.Client.Get(context.TODO(), types.NamespacedName{Namespace: jenkins.Namespace, Name: jenkins.Name}, jenkins)