#129 Fix plugin version validation
This commit is contained in:
parent
bad8236104
commit
9b25919d7c
|
|
@ -23,7 +23,7 @@ func (p Plugin) String() string {
|
|||
|
||||
var (
|
||||
namePattern = regexp.MustCompile(`(?i)^[0-9a-z-_]+$`)
|
||||
versionPattern = regexp.MustCompile(`^[0-9\\.]+$`)
|
||||
versionPattern = regexp.MustCompile(`^[0-9\\.-]+$`)
|
||||
)
|
||||
|
||||
// New creates plugin from string, for example "name-of-plugin:0.0.1"
|
||||
|
|
|
|||
|
|
@ -108,4 +108,13 @@ func TestVerifyDependencies(t *testing.T) {
|
|||
got := VerifyDependencies(basePlugins, extraPlugins)
|
||||
assert.Equal(t, false, got)
|
||||
})
|
||||
t.Run("happy with dash in version", func(t *testing.T) {
|
||||
basePlugins := map[Plugin][]Plugin{
|
||||
Must(New("first-root-plugin:1.0.0-1")): {
|
||||
Must(New("first-plugin:0.0.1-1")),
|
||||
},
|
||||
}
|
||||
got := VerifyDependencies(basePlugins)
|
||||
assert.Equal(t, true, got)
|
||||
})
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue