From 9285e294ddd9ad5283deb0ab8f07c831359ba6d0 Mon Sep 17 00:00:00 2001 From: Akram Ben Aissi Date: Wed, 26 Jun 2019 03:15:52 -0400 Subject: [PATCH] Jenkins OpenShift image requirements --- openshit-jenkins.yaml | 16 ++++++++++++++++ .../jenkins/configuration/base/reconcile.go | 4 ++-- .../jenkins/configuration/base/resources/pod.go | 4 ++-- 3 files changed, 20 insertions(+), 4 deletions(-) create mode 100644 openshit-jenkins.yaml diff --git a/openshit-jenkins.yaml b/openshit-jenkins.yaml new file mode 100644 index 00000000..9fdca028 --- /dev/null +++ b/openshit-jenkins.yaml @@ -0,0 +1,16 @@ +apiVersion: jenkins.io/v1alpha2 +kind: Jenkins +metadata: + name: jenkins +spec: + master: + containers: + - name: jenkins-master + image: quay.io/openshift/origin-jenkins:latest + resources: + limits: + cpu: 1500m + memory: 3Gi + requests: + cpu: "1" + memory: 500Mi diff --git a/pkg/controller/jenkins/configuration/base/reconcile.go b/pkg/controller/jenkins/configuration/base/reconcile.go index 5be3e62f..2b68106c 100644 --- a/pkg/controller/jenkins/configuration/base/reconcile.go +++ b/pkg/controller/jenkins/configuration/base/reconcile.go @@ -546,10 +546,10 @@ func (r *ReconcileJenkinsBaseConfiguration) compareContainers(expected corev1.Co r.logger.Info(fmt.Sprintf("Resources have changed to '%+v' in container '%s', recreating pod", expected.Resources, expected.Name)) return true } - if !reflect.DeepEqual(expected.SecurityContext, actual.SecurityContext) { +/* if !reflect.DeepEqual(expected.SecurityContext, actual.SecurityContext) { r.logger.Info(fmt.Sprintf("Security context has changed to '%+v' in container '%s', recreating pod", expected.SecurityContext, expected.Name)) return true - } + }*/ if !reflect.DeepEqual(expected.WorkingDir, actual.WorkingDir) { r.logger.Info(fmt.Sprintf("Working directory has changed to '%+v' in container '%s', recreating pod", expected.WorkingDir, expected.Name)) return true diff --git a/pkg/controller/jenkins/configuration/base/resources/pod.go b/pkg/controller/jenkins/configuration/base/resources/pod.go index faadfcbc..889e4fd0 100644 --- a/pkg/controller/jenkins/configuration/base/resources/pod.go +++ b/pkg/controller/jenkins/configuration/base/resources/pod.go @@ -202,10 +202,10 @@ func NewJenkinsMasterContainer(jenkins *v1alpha2.Jenkins) corev1.Container { Name: JenkinsMasterContainerName, Image: jenkinsContainer.Image, ImagePullPolicy: jenkinsContainer.ImagePullPolicy, - Command: []string{ + /*Command: []string{ "bash", fmt.Sprintf("%s/%s", jenkinsScriptsVolumePath, initScriptName), - }, + },*/ LivenessProbe: jenkinsContainer.LivenessProbe, ReadinessProbe: jenkinsContainer.ReadinessProbe, Ports: []corev1.ContainerPort{