#96 Improve pod unit tests

pkg/controller/jenkins/configuration/base/resources/pod_test.go

@@ -49,6 +49,123 @@ func TestGetJenkinsMasterPodBaseVolumes(t *testing.T) {
 			}
 		}
 
-		assert.True(t, groovyExists && cascExists)
+		assert.True(t, groovyExists)
+		assert.True(t, cascExists)
+	})
+	t.Run("groovy script without secret name", func(t *testing.T) {
+		jenkins := &v1alpha2.Jenkins{
+			Spec: v1alpha2.JenkinsSpec{
+				ConfigurationAsCode: v1alpha2.ConfigurationAsCode{
+					Customization: v1alpha2.Customization{
+						Configurations: []v1alpha2.ConfigMapRef{
+							{
+								Name: "casc-scripts",
+							},
+						},
+						Secret: v1alpha2.SecretRef{
+							Name: "jenkins-secret",
+						},
+					},
+				},
+				GroovyScripts: v1alpha2.GroovyScripts{
+					Customization: v1alpha2.Customization{
+						Configurations: []v1alpha2.ConfigMapRef{
+							{
+								Name: "groovy-scripts",
+							},
+						},
+					},
+				},
+			},
+		}
+
+		volumeExists := false
+		for _, volume := range GetJenkinsMasterPodBaseVolumes(jenkins) {
+			if volume.Name == ("casc-" + jenkins.Spec.ConfigurationAsCode.Secret.Name) {
+				volumeExists = true
+			}
+		}
+
+		assert.True(t, volumeExists)
+	})
+	t.Run("casc without secret name", func(t *testing.T) {
+		jenkins := &v1alpha2.Jenkins{
+			Spec: v1alpha2.JenkinsSpec{
+				ConfigurationAsCode: v1alpha2.ConfigurationAsCode{
+					Customization: v1alpha2.Customization{
+						Configurations: []v1alpha2.ConfigMapRef{
+							{
+								Name: "casc-scripts",
+							},
+						},
+					},
+				},
+				GroovyScripts: v1alpha2.GroovyScripts{
+					Customization: v1alpha2.Customization{
+						Configurations: []v1alpha2.ConfigMapRef{
+							{
+								Name: "groovy-scripts",
+							},
+						},
+						Secret: v1alpha2.SecretRef{
+							Name: "jenkins-secret",
+						},
+					},
+				},
+			},
+		}
+
+		volumeExists := false
+		for _, volume := range GetJenkinsMasterPodBaseVolumes(jenkins) {
+			if volume.Name == ("gs-" + jenkins.Spec.GroovyScripts.Secret.Name) {
+				volumeExists = true
+			}
+		}
+
+		assert.True(t, volumeExists)
+	})
+	t.Run("casc and groovy script shared secret name", func(t *testing.T) {
+		jenkins := &v1alpha2.Jenkins{
+			Spec: v1alpha2.JenkinsSpec{
+				ConfigurationAsCode: v1alpha2.ConfigurationAsCode{
+					Customization: v1alpha2.Customization{
+						Configurations: []v1alpha2.ConfigMapRef{
+							{
+								Name: "casc-scripts",
+							},
+						},
+						Secret: v1alpha2.SecretRef{
+							Name: "jenkins-secret",
+						},
+					},
+				},
+				GroovyScripts: v1alpha2.GroovyScripts{
+					Customization: v1alpha2.Customization{
+						Configurations: []v1alpha2.ConfigMapRef{
+							{
+								Name: "groovy-scripts",
+							},
+						},
+						Secret: v1alpha2.SecretRef{
+							Name: "jenkins-secret",
+						},
+					},
+				},
+			},
+		}
+
+		groovyExists := false
+		cascExists := false
+
+		for _, volume := range GetJenkinsMasterPodBaseVolumes(jenkins) {
+			if volume.Name == ("gs-" + jenkins.Spec.GroovyScripts.Secret.Name) {
+				groovyExists = true
+			} else if volume.Name == ("casc-" + jenkins.Spec.ConfigurationAsCode.Secret.Name) {
+				cascExists = true
+			}
+		}
+
+		assert.True(t, groovyExists)
+		assert.True(t, cascExists)
 	})
 }