Merge branch 'master' into fix-1014
This commit is contained in:
		
						commit
						3b957cf874
					
				|  | @ -14,8 +14,8 @@ | |||
|             "minikube": "none" | ||||
|         }, | ||||
|         "ghcr.io/devcontainers/features/go:1": { | ||||
|             "version": "1.15", | ||||
|             "golangciLintVersion": "1.26.0" | ||||
|             "version": "1.22", | ||||
|             "golangciLintVersion": "1.58.2" | ||||
|         }, | ||||
|         "ghcr.io/mpriscella/features/kind:1": { | ||||
|             "version": "latest" | ||||
|  |  | |||
|  | @ -33,14 +33,14 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     if: github.event_name == 'pull_request' || (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') | ||||
|     steps: | ||||
|       - uses: DeterminateSystems/nix-installer-action@v13 | ||||
|       - uses: DeterminateSystems/nix-installer-action@ab6bcb2d5af0e904d04aea750e2089e9dc4cbfdd # v13 | ||||
|         with: | ||||
|           diagnostic-endpoint: "" | ||||
|       - uses: DeterminateSystems/magic-nix-cache-action@v7 | ||||
|       - uses: DeterminateSystems/magic-nix-cache-action@b46e247b898aa56e6d2d2e728dc6df6c84fdb738 # v7 | ||||
|         with: | ||||
|           diagnostic-endpoint: "" | ||||
|       - name: Checkout code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Check for changes | ||||
|         run: | | ||||
|  | @ -54,7 +54,7 @@ jobs: | |||
|           | sed -e 's/\(.*\)/"\1"/' | xargs sed -i "/date:/c\date: $(date +'%Y-%m-%d')" | ||||
| 
 | ||||
|       - name: Create Pull Request | ||||
|         uses: peter-evans/create-pull-request@v6 | ||||
|         uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # v6 | ||||
|         if: env.IS_CHANGED == 'true' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') | ||||
|         with: | ||||
|           commit-message: Auto-updated docs | ||||
|  | @ -68,14 +68,14 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     if: github.event_name == 'pull_request' || (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') | ||||
|     steps: | ||||
|       - uses: DeterminateSystems/nix-installer-action@v13 | ||||
|       - uses: DeterminateSystems/nix-installer-action@ab6bcb2d5af0e904d04aea750e2089e9dc4cbfdd # v13 | ||||
|         with: | ||||
|           diagnostic-endpoint: "" | ||||
|       - uses: DeterminateSystems/magic-nix-cache-action@v7 | ||||
|       - uses: DeterminateSystems/magic-nix-cache-action@b46e247b898aa56e6d2d2e728dc6df6c84fdb738 # v7 | ||||
|         with: | ||||
|           diagnostic-endpoint: "" | ||||
|       - name: Checkout code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
|       - name: nix checks | ||||
|         run: nix flake check | ||||
|       - name: nix build | ||||
|  | @ -85,9 +85,9 @@ jobs: | |||
|         run: nix build .#website | ||||
|       - name: Setup Pages | ||||
|         id: pages | ||||
|         uses: actions/configure-pages@v5 | ||||
|         uses: actions/configure-pages@983d7736d9b0ae728b81ab479565c72886d7745b # v5 | ||||
|       - name: Upload artifact | ||||
|         uses: actions/upload-pages-artifact@v3 | ||||
|         uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa # v3 | ||||
|         with: | ||||
|           path: ./result | ||||
| 
 | ||||
|  | @ -102,4 +102,4 @@ jobs: | |||
|     steps: | ||||
|       - name: Deploy to GitHub Pages | ||||
|         id: deployment | ||||
|         uses: actions/deploy-pages@v4 | ||||
|         uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4 | ||||
|  |  | |||
|  | @ -20,7 +20,7 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - name: Check out code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Set up env vars | ||||
|         run: | | ||||
|  | @ -51,7 +51,7 @@ jobs: | |||
|           cp chart/jenkins-operator/crds/jenkins-crd.yaml deploy/crds/jenkins.io_jenkins_crd.yaml | ||||
| 
 | ||||
|       - name: Create Pull Request | ||||
|         uses: peter-evans/create-pull-request@v6 | ||||
|         uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # v6 | ||||
|         with: | ||||
|           commit-message: Auto-updated Kubernetes Manifests | ||||
|           branch: manifest-deploy-update | ||||
|  |  | |||
|  | @ -12,7 +12,7 @@ jobs: | |||
|   stale: | ||||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - uses: actions/stale@v9 | ||||
|       - uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9 | ||||
|         with: | ||||
|           repo-token: ${{ secrets.GITHUB_TOKEN }} | ||||
|           operations-per-run: 200 | ||||
|  |  | |||
|  | @ -27,7 +27,7 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - name: Check out code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Set up env vars | ||||
|         run: | | ||||
|  | @ -38,7 +38,7 @@ jobs: | |||
|           echo "GOPATH=/home/runner/go" >> $GITHUB_ENV | ||||
| 
 | ||||
|       - name: Prepare go environment | ||||
|         uses: actions/setup-go@v5 | ||||
|         uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5 | ||||
|         with: | ||||
|           go-version: ${{ env.GO_VERSION }} | ||||
| 
 | ||||
|  | @ -46,7 +46,7 @@ jobs: | |||
|         run: make go-dependencies | ||||
| 
 | ||||
|       - name: Setup Bats and libs | ||||
|         uses: bats-core/bats-action@2.0.0 | ||||
|         uses: bats-core/bats-action@e424f8b8f722bf06a64acb1e10d8c437cd4170e6 # 2.0.0 | ||||
|         with: | ||||
|           support-path: "${{ github.workspace }}/.bats/bats-support" | ||||
|           assert-path: "${{ github.workspace }}/.bats/bats-assert" | ||||
|  | @ -54,7 +54,7 @@ jobs: | |||
|           file-path: "${{ github.workspace }}/.bats/bats-file" | ||||
| 
 | ||||
|       - name: Kind setup | ||||
|         uses: helm/kind-action@v1.10.0 | ||||
|         uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0 | ||||
|         with: | ||||
|           cluster_name: ${{env.KIND_CLUSTER_NAME}} | ||||
| 
 | ||||
|  |  | |||
|  | @ -26,7 +26,7 @@ jobs: | |||
|     outputs: | ||||
|       matrix: ${{ steps.matrix.outputs.matrix }} | ||||
|     steps: | ||||
|       - uses: actions/checkout@v4 | ||||
|       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
|       - id: matrix | ||||
|         run: | | ||||
|           script=$(./test/make_matrix_ginkgo.sh e2e) | ||||
|  | @ -37,7 +37,7 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     needs: [create-e2e-list] | ||||
|     steps: | ||||
|       - uses: actions/checkout@v4 | ||||
|       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Set up env vars | ||||
|         run: | | ||||
|  | @ -46,7 +46,7 @@ jobs: | |||
|           echo "GOPATH=/home/runner/go" >> $GITHUB_ENV | ||||
| 
 | ||||
|       - name: Prepare go environment | ||||
|         uses: actions/setup-go@v5 | ||||
|         uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5 | ||||
|         with: | ||||
|           go-version: ${{ env.GO_VERSION }} | ||||
| 
 | ||||
|  | @ -66,7 +66,7 @@ jobs: | |||
|       matrix: ${{ fromJSON(needs.create-e2e-list.outputs.matrix) }} | ||||
|     steps: | ||||
|       - name: Check out code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Set up env vars | ||||
|         run: | | ||||
|  | @ -76,7 +76,7 @@ jobs: | |||
|           echo "GOPATH=/home/runner/go" >> $GITHUB_ENV | ||||
| 
 | ||||
|       - name: Prepare go environment | ||||
|         uses: actions/setup-go@v5 | ||||
|         uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5 | ||||
|         with: | ||||
|           go-version: ${{ env.GO_VERSION }} | ||||
| 
 | ||||
|  | @ -84,7 +84,7 @@ jobs: | |||
|         run: make go-dependencies | ||||
| 
 | ||||
|       - name: Kind setup | ||||
|         uses: helm/kind-action@v1.10.0 | ||||
|         uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0 | ||||
|         with: | ||||
|           cluster_name: ${{env.KIND_CLUSTER_NAME}} | ||||
|           config: kind-cluster.yaml | ||||
|  |  | |||
|  | @ -26,7 +26,7 @@ jobs: | |||
|     outputs: | ||||
|       matrix: ${{ steps.matrix.outputs.matrix }} | ||||
|     steps: | ||||
|     - uses: actions/checkout@v4 | ||||
|     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
|     - id: matrix | ||||
|       run: | | ||||
|         script=$(./test/make_matrix_ginkgo.sh helm) | ||||
|  | @ -37,7 +37,7 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     needs: [create-helm-list] | ||||
|     steps: | ||||
|     - uses: actions/checkout@v4 | ||||
|     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|     - name: Set up env vars | ||||
|       run: | | ||||
|  | @ -46,7 +46,7 @@ jobs: | |||
|         echo "GOPATH=/home/runner/go" >> $GITHUB_ENV | ||||
| 
 | ||||
|     - name: Prepare go environment | ||||
|       uses: actions/setup-go@v5 | ||||
|       uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5 | ||||
|       with: | ||||
|         go-version: ${{ env.GO_VERSION }} | ||||
| 
 | ||||
|  | @ -66,7 +66,7 @@ jobs: | |||
|       matrix: ${{ fromJSON(needs.create-helm-list.outputs.matrix) }} | ||||
|     steps: | ||||
|       - name: Check out code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Set up env vars | ||||
|         run: | | ||||
|  | @ -77,7 +77,7 @@ jobs: | |||
|           echo "GOPATH=/home/runner/go" >> $GITHUB_ENV | ||||
| 
 | ||||
|       - name: Prepare go environment | ||||
|         uses: actions/setup-go@v5 | ||||
|         uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5 | ||||
|         with: | ||||
|           go-version: ${{ env.GO_VERSION }} | ||||
| 
 | ||||
|  | @ -85,7 +85,7 @@ jobs: | |||
|         run: make go-dependencies | ||||
| 
 | ||||
|       - name: Kind setup | ||||
|         uses: helm/kind-action@v1.10.0 | ||||
|         uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0 | ||||
|         with: | ||||
|           cluster_name: ${{env.KIND_CLUSTER_NAME}} | ||||
|           config: kind-cluster.yaml | ||||
|  |  | |||
|  | @ -20,7 +20,7 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - name: Checkout code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Check envs | ||||
|         run: make -C backup/pvc check-env | ||||
|  | @ -46,7 +46,7 @@ jobs: | |||
| 
 | ||||
|       - name: Login to Quay.io | ||||
|         if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' | ||||
|         uses: docker/login-action@v3 | ||||
|         uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3 | ||||
|         with: | ||||
|           registry: quay.io | ||||
|           username: ${{ secrets.QUAYIO_USERNAME }} | ||||
|  |  | |||
|  | @ -17,7 +17,7 @@ jobs: | |||
| 
 | ||||
|     steps: | ||||
|       - name: Checkout code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Deploy Helm chart | ||||
|         run: | | ||||
|  | @ -31,10 +31,10 @@ jobs: | |||
| 
 | ||||
|       # Creates pull request with new chart version | ||||
|       - name: Create Pull Request | ||||
|         uses: peter-evans/create-pull-request@v6 | ||||
|         uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # v6 | ||||
|         with: | ||||
|           commit-message: Release Helm chart ${{ github.event.inputs.chartVersion }} | ||||
|           branch: helm-chart-release-${{ github.event.inputs.chartVersion }} | ||||
|           title: Release ${{ github.event.inputs.chartVersion }} Helm Chart | ||||
|           body: | | ||||
|             Release ${{ github.event.inputs.chartVersion }} Helm Chart | ||||
|             Release ${{ github.event.inputs.chartVersion }} Helm Chart | ||||
|  |  | |||
|  | @ -14,7 +14,7 @@ jobs: | |||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - name: Prep - check out code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
| 
 | ||||
|       - name: Prep - Set up env vars | ||||
|         run: | | ||||
|  | @ -26,7 +26,7 @@ jobs: | |||
| 
 | ||||
|       - name: Prep - setup Bats and bats libs | ||||
|         if: ${{ github.event.inputs.skipTests != 'true' }} | ||||
|         uses: bats-core/bats-action@2.0.0 | ||||
|         uses: bats-core/bats-action@e424f8b8f722bf06a64acb1e10d8c437cd4170e6 # 2.0.0 | ||||
|         with: | ||||
|           support-path: "${{ github.workspace }}/.bats/bats-support" | ||||
|           assert-path: "${{ github.workspace }}/.bats/bats-assert" | ||||
|  | @ -34,7 +34,7 @@ jobs: | |||
|           file-path: "${{ github.workspace }}/.bats/bats-file" | ||||
| 
 | ||||
|       - name: Prep - go environment | ||||
|         uses: actions/setup-go@v5 | ||||
|         uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5 | ||||
|         with: | ||||
|           go-version: ${{ env.GO_VERSION }} | ||||
| 
 | ||||
|  | @ -54,7 +54,7 @@ jobs: | |||
| 
 | ||||
|       - name: Prep - Kind setup | ||||
|         if: ${{ github.event.inputs.skipTests != 'true' }} | ||||
|         uses: helm/kind-action@v1.10.0 | ||||
|         uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0 | ||||
|         with: | ||||
|           cluster_name: ${{env.KIND_CLUSTER_NAME}} | ||||
|           config: kind-cluster.yaml | ||||
|  | @ -77,7 +77,7 @@ jobs: | |||
|         run: make bats-tests | ||||
| 
 | ||||
|       - name: Post - Login to Quay.io | ||||
|         uses: docker/login-action@v3 | ||||
|         uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3 | ||||
|         with: | ||||
|           registry: quay.io | ||||
|           username: ${{ secrets.QUAYIO_USERNAME }} | ||||
|  |  | |||
|  | @ -9,7 +9,7 @@ jobs: | |||
| 
 | ||||
|     steps: | ||||
|       - name: Checkout code | ||||
|         uses: actions/checkout@v4 | ||||
|         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||||
|         with: | ||||
|           fetch-depth: 0 | ||||
| 
 | ||||
|  | @ -20,7 +20,7 @@ jobs: | |||
|           echo "GOPATH=/home/runner/go" >> $GITHUB_ENV | ||||
| 
 | ||||
|       - name: Prepare go environment | ||||
|         uses: actions/setup-go@v5 | ||||
|         uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5 | ||||
|         with: | ||||
|           go-version: ${{ env.GO_VERSION }} | ||||
| 
 | ||||
|  | @ -40,12 +40,12 @@ jobs: | |||
|           echo "VERSION=$(cat VERSION.txt)" >> $GITHUB_ENV | ||||
| 
 | ||||
|       - name: Release | ||||
|         uses: softprops/action-gh-release@v2 | ||||
|         uses: softprops/action-gh-release@c95fe1489396fe8a9eb87c0abf8aa5b2ef267fda # v2 | ||||
|         with: | ||||
|           tag_name: ${{ env.VERSION }} | ||||
| 
 | ||||
|       - name: Login to Quay.io | ||||
|         uses: docker/login-action@v3 | ||||
|         uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3 | ||||
|         with: | ||||
|           registry: quay.io | ||||
|           username: ${{ secrets.QUAYIO_USERNAME }} | ||||
|  |  | |||
|  | @ -1,30 +1,41 @@ | |||
| run: | ||||
|   deadline: 10m | ||||
|   deadline: 5m | ||||
|   allow-parallel-runners: true | ||||
|   skip-files: | ||||
|     - api/v1alpha2/zz_generated.deepcopy.go | ||||
| linters-settings: | ||||
|   errcheck: | ||||
|     check-blank: false | ||||
|     ignore: fmt:.*,io/ioutil:^Read.*,Write | ||||
| issues: | ||||
|   exclude-use-default: false | ||||
|   exclude-rules: | ||||
|     - path: "internal/*" | ||||
|       linters: | ||||
|         - dupl | ||||
|     - path: (.+)_test.go | ||||
|       linters: | ||||
|         - dupl | ||||
| linters: | ||||
|   enable-all: true | ||||
|   disable: | ||||
|     - funlen | ||||
|     - gocognit | ||||
|     - godox | ||||
|     - gomnd | ||||
|     - gochecknoglobals | ||||
|     - gochecknoinits | ||||
|     - lll | ||||
|     - prealloc | ||||
|     - wsl | ||||
|     - gocyclo | ||||
|     - scopelint | ||||
|   disable-all: true | ||||
|   enable: | ||||
|     - dupl | ||||
|     - gosec | ||||
|     - maligned | ||||
|     - testpackage | ||||
|     - goerr113 | ||||
|     - errcheck | ||||
|     - exportloopref | ||||
|     - goconst | ||||
|     - gocyclo | ||||
|     - gofmt | ||||
|     - goimports | ||||
|     - gosimple | ||||
|     - govet | ||||
|     - ineffassign | ||||
|     - loggercheck | ||||
|     - misspell | ||||
|     - nakedret | ||||
|     - nestif | ||||
|     - godot | ||||
|     - staticcheck | ||||
|     - typecheck | ||||
|     - unconvert | ||||
|     - unparam | ||||
|     - unused | ||||
| output: | ||||
|   sort-results: true | ||||
|   sort-order: | ||||
|     - file | ||||
|     - severity | ||||
|     - linter | ||||
|  |  | |||
|  | @ -1,21 +1,26 @@ | |||
| repos: | ||||
|   - repo: https://github.com/sirosen/check-jsonschema | ||||
|     rev: 0.28.0 | ||||
|     rev: a167de9d5f4e87e1cdb16cb560aa704b79b6f655  # frozen: 0.32.1 | ||||
|     hooks: | ||||
|       - id: check-github-workflows | ||||
|   - repo: https://github.com/pre-commit/pre-commit-hooks | ||||
|     rev: v4.4.0 | ||||
|     rev: cef0300fd0fc4d2a87a85fa2093c6b283ea36f4b  # frozen: v5.0.0 | ||||
|     hooks: | ||||
|       - id: detect-private-key | ||||
|       - id: trailing-whitespace | ||||
|       - id: end-of-file-fixer | ||||
|   - repo: https://github.com/gruntwork-io/pre-commit | ||||
|     rev: "v0.1.19" | ||||
|     rev: "d9196b3a0a6fbc530f2bacea36c11a3b0214ff13"  # frozen: v0.1.28 | ||||
|     hooks: | ||||
|       - id: helmlint | ||||
|   - repo: https://github.com/norwoodj/helm-docs | ||||
|     rev: "v1.11.0" | ||||
|     rev: "37d3055fece566105cf8cff7c17b7b2355a01677"  # frozen: v1.14.2 | ||||
|     hooks: | ||||
|       - id: helm-docs | ||||
|         args: | ||||
|           - --chart-search-root=chart/jenkins-operator | ||||
|   - repo: https://github.com/brokenpip3/pre-commit-hooks | ||||
|     rev: dd7b3821637ba3c3a8628ad487fd84edec8006f2  # frozen: 0.0.1 | ||||
|     hooks: | ||||
|       - id: github-actions-hash | ||||
|         files: ^.github/workflows/.*\.(yml|yaml)$ # limit only to github workflows | ||||
|  |  | |||
|  | @ -16,14 +16,14 @@ RUN go mod download | |||
| 
 | ||||
| # Copy the go source | ||||
| COPY api/ api/ | ||||
| COPY controllers/ controllers/ | ||||
| COPY internal/controller/ internal/controller/ | ||||
| COPY internal/ internal/ | ||||
| COPY pkg/ pkg/ | ||||
| COPY version/ version/ | ||||
| COPY main.go main.go | ||||
| COPY cmd/main.go cmd/main.go | ||||
| 
 | ||||
| # Build | ||||
| RUN CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH GO111MODULE=on go build -ldflags "-w $CTIMEVAR" -o manager main.go | ||||
| RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -a -o manager cmd/main.go | ||||
| 
 | ||||
| # Use distroless as minimal base image to package the manager binary | ||||
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||||
|  |  | |||
							
								
								
									
										145
									
								
								Makefile
								
								
								
								
							
							
						
						
									
										145
									
								
								Makefile
								
								
								
								
							|  | @ -70,16 +70,20 @@ HAS_GOLINT := $(shell which $(PROJECT_DIR)/bin/golangci-lint) | |||
| lint: ## Verifies `golint` passes
 | ||||
| 	@echo "+ $@" | ||||
| ifndef HAS_GOLINT | ||||
| 	$(call go-get-tool,$(PROJECT_DIR)/bin/golangci-lint,github.com/golangci/golangci-lint/cmd/golangci-lint@v1.26.0) | ||||
| 	GOBIN=$(PROJECT_DIR)/bin go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.0 | ||||
| endif | ||||
| 	@bin/golangci-lint run | ||||
| 
 | ||||
| .PHONY: lint-fix | ||||
| lint-fix: golangci-lint ## Run golangci-lint linter and perform fixes
 | ||||
| 	@bin/golangci-lint run --fix | ||||
| 
 | ||||
| .PHONY: goimports | ||||
| HAS_GOIMPORTS := $(shell which $(PROJECT_DIR)/bin/goimports) | ||||
| goimports: ## Verifies `goimports` passes
 | ||||
| 	@echo "+ $@" | ||||
| ifndef HAS_GOIMPORTS | ||||
| 	$(call go-get-tool,$(PROJECT_DIR)/bin/goimports,golang.org/x/tools/cmd/goimports@v0.1.0) | ||||
| 	$(call GOBIN=$(PROJECT_DIR)/bin go install golang.org/x/tools/cmd/goimports@v0.1.0) | ||||
| endif | ||||
| 	@bin/goimports -l -e $(shell find . -type f -name '*.go' -not -path "./vendor/*") | ||||
| 
 | ||||
|  | @ -108,11 +112,11 @@ HAS_HELM := $(shell command -v helm 2> /dev/null) | |||
| helm: ## Download helm if it's not present, otherwise symlink
 | ||||
| 	@echo "+ $@" | ||||
| ifeq ($(strip $(HAS_HELM)),) | ||||
|     mkdir -p $(PROJECT_DIR)/bin | ||||
|     curl -Lo $(PROJECT_DIR)/bin/helm.tar.gz https://get.helm.sh/helm-v$(HELM_VERSION)-$(PLATFORM)-amd64.tar.gz && tar xzfv $(PROJECT_DIR)/bin/helm.tar.gz -C $(PROJECT_DIR)/bin | ||||
|     mv $(PROJECT_DIR)/bin/$(PLATFORM)-amd64/helm $(PROJECT_DIR)/bin/helm | ||||
|     rm -rf $(PROJECT_DIR)/bin/$(PLATFORM)-amd64 | ||||
|     rm -rf $(PROJECT_DIR)/bin/helm.tar.gz | ||||
| 	mkdir -p $(PROJECT_DIR)/bin | ||||
| 	curl -Lo $(PROJECT_DIR)/bin/helm.tar.gz https://get.helm.sh/helm-v$(HELM_VERSION)-$(PLATFORM)-amd64.tar.gz && tar xzfv $(PROJECT_DIR)/bin/helm.tar.gz -C $(PROJECT_DIR)/bin | ||||
| 	mv $(PROJECT_DIR)/bin/$(PLATFORM)-amd64/helm $(PROJECT_DIR)/bin/helm | ||||
| 	rm -rf $(PROJECT_DIR)/bin/$(PLATFORM)-amd64 | ||||
| 	rm -rf $(PROJECT_DIR)/bin/helm.tar.gz | ||||
| else | ||||
| 	mkdir -p $(PROJECT_DIR)/bin | ||||
| 	test -L $(PROJECT_DIR)/bin/helm || ln -sf $(shell command -v helm) $(PROJECT_DIR)/bin/helm | ||||
|  | @ -152,7 +156,7 @@ staticcheck: ## Verifies `staticcheck` passes | |||
| 	@echo "+ $@" | ||||
| ifndef HAS_STATICCHECK | ||||
| 	$(eval TMP_DIR := $(shell mktemp -d)) | ||||
| 	wget -O $(TMP_DIR)/staticcheck_$(PLATFORM)_amd64.tar.gz https://github.com/dominikh/go-tools/releases/download/2020.1.3/staticcheck_$(PLATFORM)_amd64.tar.gz | ||||
| 	wget -O $(TMP_DIR)/staticcheck_$(PLATFORM)_amd64.tar.gz https://github.com/dominikh/go-tools/releases/download/2023.1.7/staticcheck_$(PLATFORM)_amd64.tar.gz | ||||
| 	tar zxvf $(TMP_DIR)/staticcheck_$(PLATFORM)_amd64.tar.gz -C $(TMP_DIR) | ||||
| 	mkdir -p $(PROJECT_DIR)/bin | ||||
| 	mv $(TMP_DIR)/staticcheck/staticcheck $(PROJECT_DIR)/bin | ||||
|  | @ -164,7 +168,8 @@ endif | |||
| cover: ## Runs go test with coverage
 | ||||
| 	@echo "" > coverage.txt | ||||
| 	@for d in $(PACKAGES); do \
 | ||||
| 		IMG_RUNNING_TESTS=1 go test -race -coverprofile=profile.out -covermode=atomic "$$d"; \
 | ||||
| 		ENVTEST_K8S_VERSION = 1.26 | ||||
| 		KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" IMG_RUNNING_TESTS=1 go test -race -coverprofile=profile.out -covermode=atomic "$$d"; \
 | ||||
| 		if [ -f profile.out ]; then \
 | ||||
| 			cat profile.out >> coverage.txt; \
 | ||||
| 			rm profile.out; \
 | ||||
|  | @ -327,7 +332,7 @@ container-runtime-release: container-runtime-release-version container-runtime-r | |||
| # so that the user can send e.g. ^C through.
 | ||||
| INTERACTIVE := $(shell [ -t 0 ] && echo 1 || echo 0) | ||||
| ifeq ($(INTERACTIVE), 1) | ||||
|     DOCKER_FLAGS += -t | ||||
| 	DOCKER_FLAGS += -t | ||||
| endif | ||||
| 
 | ||||
| .PHONY: container-runtime-run | ||||
|  | @ -377,6 +382,10 @@ kind-clean: ## Delete kind cluster | |||
| 	@echo "+ $@" | ||||
| 	kind delete cluster --name $(KIND_CLUSTER_NAME) | ||||
| 
 | ||||
| .PHONY: kind-revamp | ||||
| kind-revamp: kind-clean kind-setup## Delete and recreate kind cluster
 | ||||
| 	@echo "+ $@" | ||||
| 
 | ||||
| .PHONY: bats-tests | ||||
| IMAGE_NAME := quay.io/$(QUAY_ORGANIZATION)/$(QUAY_REGISTRY):$(GITCOMMIT)-amd64 | ||||
| BUILD_PRESENT := $(shell docker images |grep -q ${IMAGE_NAME}) | ||||
|  | @ -452,7 +461,7 @@ ifneq ($(GITUNTRACKEDCHANGES),) | |||
| endif | ||||
| ifneq ($(GITIGNOREDBUTTRACKEDCHANGES),) | ||||
| 	@echo "Ignored but tracked files:" | ||||
| 	@git ls-files -i -c --exclude-standard | ||||
| 	@git ls-files -i -o --exclude-standard | ||||
| 	@echo | ||||
| endif | ||||
| 	@echo "Dependencies:" | ||||
|  | @ -464,6 +473,7 @@ endif | |||
| HUGO_PATH = $(shell pwd)/bin/hugo | ||||
| HUGO_VERSION = v0.99.1 | ||||
| HAS_HUGO := $(shell $(HUGO_PATH)/hugo version 2>&- | grep $(HUGO_VERSION)) | ||||
| .PHONY: hugo | ||||
| hugo: | ||||
| ifeq ($(HAS_HUGO), ) | ||||
| 	@echo "Installing Hugo $(HUGO_VERSION)" | ||||
|  | @ -486,59 +496,77 @@ run-docs: hugo | |||
| 
 | ||||
| ##################### FROM OPERATOR SDK ########################
 | ||||
| # Install CRDs into a cluster
 | ||||
| .PHONY: install-crds | ||||
| install-crds: manifests kustomize | ||||
| 	$(KUSTOMIZE) build config/crd | kubectl apply -f - | ||||
| 
 | ||||
| # Uninstall CRDs from a cluster
 | ||||
| ifndef ignore-not-found | ||||
|   ignore-not-found = false | ||||
| endif | ||||
| .PHONY: uninstall-crds | ||||
| uninstall-crds: manifests kustomize | ||||
| 	$(KUSTOMIZE) build config/crd | kubectl delete -f - | ||||
| 	$(KUSTOMIZE) build config/crd | kubectl delete --ignore-not-found=$(ignore-not-found) -f - | ||||
| 
 | ||||
| # Deploy controller in the configured Kubernetes cluster in ~/.kube/config
 | ||||
| .PHONY: deploy | ||||
| deploy: manifests kustomize | ||||
| 	cd config/manager && $(KUSTOMIZE) edit set image controller=quay.io/$(QUAY_ORGANIZATION)/$(QUAY_REGISTRY):$(GITCOMMIT) | ||||
| 	$(KUSTOMIZE) build config/default | kubectl apply -f - | ||||
| 
 | ||||
| # UnDeploy controller from the configured Kubernetes cluster in ~/.kube/config
 | ||||
| .PHONY: undeploy | ||||
| undeploy: | ||||
| 	$(KUSTOMIZE) build config/default | kubectl delete -f - | ||||
| 	$(KUSTOMIZE) build config/default | kubectl delete --ignore-not-found=$(ignore-not-found) -f - | ||||
| 
 | ||||
| # Generate manifests e.g. CRD, RBAC etc.
 | ||||
| .PHONY: manifests | ||||
| manifests: controller-gen | ||||
| 	$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases | ||||
| 	$(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases | ||||
| 
 | ||||
| # Generate code
 | ||||
| .PHONY: generate | ||||
| generate: controller-gen | ||||
| 	$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..." | ||||
| 
 | ||||
| # Download controller-gen locally if necessary
 | ||||
| CONTROLLER_GEN = $(shell pwd)/bin/controller-gen | ||||
| controller-gen: | ||||
| 	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.4.1) | ||||
| ##@ Build Dependencies
 | ||||
| 
 | ||||
| # Download kustomize locally if necessary
 | ||||
| KUSTOMIZE = $(shell pwd)/bin/kustomize | ||||
| kustomize: | ||||
| 	$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/v3@v3.8.7) | ||||
| ## Location to install dependencies to
 | ||||
| LOCALBIN ?= $(shell pwd)/bin | ||||
| $(LOCALBIN): | ||||
| 	mkdir -p $(LOCALBIN) | ||||
| 
 | ||||
| # go-get-tool will 'go get' any package $2 and install it to $1.
 | ||||
| define go-get-tool | ||||
| @[ -f $(1) ] || { \ | ||||
| set -e ;\ | ||||
| TMP_DIR=$$(mktemp -d) ;\
 | ||||
| cd $$TMP_DIR ;\ | ||||
| go mod init tmp ;\ | ||||
| echo "Downloading $(2)" ;\ | ||||
| GOBIN=$(PROJECT_DIR)/bin go get $(2) ;\
 | ||||
| rm -rf $$TMP_DIR ;\ | ||||
| } | ||||
| endef | ||||
| ## Tool Binaries
 | ||||
| KUSTOMIZE ?= $(LOCALBIN)/kustomize | ||||
| CONTROLLER_GEN ?= $(LOCALBIN)/controller-gen | ||||
| ENVTEST ?= $(LOCALBIN)/setup-envtest | ||||
| 
 | ||||
| ## Tool Versions
 | ||||
| KUSTOMIZE_VERSION ?= v5.3.0 | ||||
| CONTROLLER_TOOLS_VERSION ?= v0.14.0 | ||||
| 
 | ||||
| KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | ||||
| .PHONY: kustomize | ||||
| kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.
 | ||||
| $(KUSTOMIZE): $(LOCALBIN) | ||||
| 	test -s $(LOCALBIN)/kustomize || { curl -s $(KUSTOMIZE_INSTALL_SCRIPT) | bash -s -- $(subst v,,$(KUSTOMIZE_VERSION)) $(LOCALBIN); } | ||||
| 
 | ||||
| .PHONY: controller-gen | ||||
| controller-gen: $(CONTROLLER_GEN) ## Download controller-gen locally if necessary.
 | ||||
| $(CONTROLLER_GEN): $(LOCALBIN) | ||||
| 	test -s $(LOCALBIN)/controller-gen || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_TOOLS_VERSION) | ||||
| 
 | ||||
| .PHONY: envtest | ||||
| envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
 | ||||
| $(ENVTEST): $(LOCALBIN) | ||||
| 	test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.17 | ||||
| 
 | ||||
| .PHONY: operator-sdk | ||||
| HAS_OPERATOR_SDK := $(shell which $(PROJECT_DIR)/bin/operator-sdk) | ||||
| operator-sdk: # Download operator-sdk locally if necessary
 | ||||
| 	@echo "+ $@" | ||||
| ifndef HAS_OPERATOR_SDK | ||||
| 	wget -O $(PROJECT_DIR)/bin/operator-sdk https://github.com/operator-framework/operator-sdk/releases/download/v1.3.0/operator-sdk_$(PLATFORM)_amd64 | ||||
| 	wget -O $(PROJECT_DIR)/bin/operator-sdk https://github.com/operator-framework/operator-sdk/releases/download/v${OPERATOR_SDK_VERSION}/operator-sdk_$(PLATFORM)_amd64 | ||||
| 	chmod +x $(PROJECT_DIR)/bin/operator-sdk | ||||
| endif | ||||
| 
 | ||||
|  | @ -547,7 +575,7 @@ endif | |||
| bundle: manifests operator-sdk kustomize | ||||
| 	bin/operator-sdk generate kustomize manifests -q | ||||
| 	cd config/manager && $(KUSTOMIZE) edit set image controller=quay.io/$(QUAY_ORGANIZATION)/$(QUAY_REGISTRY):$(VERSION_TAG) | ||||
| 	$(KUSTOMIZE) build config/manifests | bin/operator-sdk generate bundle -q --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS) | ||||
| 	$(KUSTOMIZE) build config/manifests | bin/operator-sdk generate bundle $(BUNDLE_GEN_FLAGS) | ||||
| 	bin/operator-sdk bundle validate ./bundle | ||||
| 
 | ||||
| # Build the bundle image.
 | ||||
|  | @ -556,6 +584,7 @@ bundle-build: | |||
| 	docker build -f bundle.Dockerfile -t $(BUNDLE_IMG) . | ||||
| 
 | ||||
| # Download kubebuilder
 | ||||
| .PHONY: kubebuilder | ||||
| kubebuilder: | ||||
| 	mkdir -p ${ENVTEST_ASSETS_DIR} | ||||
| 	test -f ${ENVTEST_ASSETS_DIR}/setup-envtest.sh || curl -sSLo ${ENVTEST_ASSETS_DIR}/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.7.0/hack/setup-envtest.sh | ||||
|  | @ -569,6 +598,50 @@ uninstall-cert-manager: kind-setup | |||
| 	kubectl delete -f https://github.com/jetstack/cert-manager/releases/download/v1.5.1/cert-manager.yaml | ||||
| 
 | ||||
| # Deploy the operator locally along with webhook using helm charts
 | ||||
| .PHONY: deploy-webhook | ||||
| deploy-webhook: container-runtime-build-amd64 | ||||
| 	@echo "+ $@" | ||||
| 	bin/helm upgrade jenkins chart/jenkins-operator --install --set-string operator.image=${IMAGE_NAME} --set webhook.enabled=true --set jenkins.enabled=false | ||||
| 
 | ||||
| # https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.6.1/#gov2-gov3-ansiblev1-helmv1-add-opm-and-catalog-build-makefile-targets
 | ||||
| .PHONY: opm | ||||
| OPM = ./bin/opm | ||||
| opm: | ||||
| ifeq (,$(wildcard $(OPM))) | ||||
| ifeq (,$(shell which opm 2>/dev/null)) | ||||
| 	@{ \
 | ||||
| 	set -e ;\
 | ||||
| 	mkdir -p $(dir $(OPM)) ;\
 | ||||
| 	curl -sSLo $(OPM) https://github.com/operator-framework/operator-registry/releases/download/v1.23.0/$${OS}-$${ARCH}-opm ;\
 | ||||
| 	chmod +x $(OPM) ;\
 | ||||
| 	} | ||||
| else | ||||
| OPM = $(shell which opm) | ||||
| endif | ||||
| endif | ||||
| BUNDLE_IMGS ?= $(BUNDLE_IMG) | ||||
| CATALOG_IMG ?= $(IMAGE_TAG_BASE)-catalog:v$(VERSION) ifneq ($(origin CATALOG_BASE_IMG), undefined) FROM_INDEX_OPT := --from-index $(CATALOG_BASE_IMG) endif | ||||
| .PHONY: catalog-build | ||||
| catalog-build: opm | ||||
| 	$(OPM) index add --container-tool docker --mode semver --tag $(CATALOG_IMG) --bundles $(BUNDLE_IMGS) $(FROM_INDEX_OPT) | ||||
| 
 | ||||
| .PHONY: catalog-push | ||||
| catalog-push: ## Push the catalog image.
 | ||||
| 	$(MAKE) docker-push IMG=$(CATALOG_IMG) | ||||
| 
 | ||||
| # PLATFORMS defines the target platforms for  the manager image be build to provide support to multiple
 | ||||
| # architectures. (i.e. make docker-buildx IMG=myregistry/mypoperator:0.0.1). To use this option you need to:
 | ||||
| # - able to use docker buildx . More info: https://docs.docker.com/build/buildx/
 | ||||
| # - have enable BuildKit, More info: https://docs.docker.com/develop/develop-images/build_enhancements/
 | ||||
| # - be able to push the image for your registry (i.e. if you do not inform a valid value via IMG=<myregistry/image:<tag>> than the export will fail)
 | ||||
| # To properly provided solutions that supports more than one platform you should use this option.
 | ||||
| PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le | ||||
| .PHONY: docker-buildx | ||||
| docker-buildx: test ## Build and push docker image for the manager for cross-platform support
 | ||||
| 	# copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile | ||||
| 	sed -e '1 s/\(^FROM\)/FROM --platform=\$$\{BUILDPLATFORM\}/; t' -e ' 1,// s//FROM --platform=\$$\{BUILDPLATFORM\}/' Dockerfile > Dockerfile.cross | ||||
| 	- docker buildx create --name project-v3-builder | ||||
| 	docker buildx use project-v3-builder | ||||
| 	- docker buildx build --push --platform=$(PLATFORMS) --tag ${IMG} -f Dockerfile.cross | ||||
| 	- docker buildx rm project-v3-builder | ||||
| 	rm Dockerfile.cross | ||||
|  |  | |||
							
								
								
									
										15
									
								
								PROJECT
								
								
								
								
							
							
						
						
									
										15
									
								
								PROJECT
								
								
								
								
							|  | @ -1,14 +1,21 @@ | |||
| domain: jenkins.io | ||||
| layout: go.kubebuilder.io/v3 | ||||
| layout: go.kubebuilder.io/v4 | ||||
| projectName: jenkins-operator | ||||
| repo: github.com/jenkinsci/kubernetes-operator | ||||
| resources: | ||||
| - crdVersion: v1 | ||||
| - api: | ||||
|     crdVersion: v1 | ||||
|     namespaced: true | ||||
|   # TODO(user): Uncomment the below line if this resource implements a controller, else delete it. | ||||
|   # controller: true | ||||
|   domain: jenkins.io | ||||
|   group: jenkins.io | ||||
|   kind: Jenkins | ||||
|   path: github.com/jenkinsci/kubernetes-operator/api/v1alpha2 | ||||
|   version: v1alpha2 | ||||
|   webhookVersion: v1 | ||||
| version: 3-alpha | ||||
|   webhooks: | ||||
|     webhookVersion: v1 | ||||
| version: "3" | ||||
| plugins: | ||||
|   manifests.sdk.operatorframework.io/v2: {} | ||||
|   scorecard.sdk.operatorframework.io/v2: {} | ||||
|  |  | |||
|  | @ -1 +1 @@ | |||
| v0.8.1 | ||||
| v0.9.0-beta1 | ||||
|  |  | |||
|  | @ -21,7 +21,6 @@ import ( | |||
| 	"encoding/json" | ||||
| 	"errors" | ||||
| 	"io" | ||||
| 	"io/ioutil" | ||||
| 	"net/http" | ||||
| 	"os" | ||||
| 	"time" | ||||
|  | @ -34,6 +33,7 @@ import ( | |||
| 	ctrl "sigs.k8s.io/controller-runtime" | ||||
| 	logf "sigs.k8s.io/controller-runtime/pkg/log" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/webhook" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission" | ||||
| ) | ||||
| 
 | ||||
| var ( | ||||
|  | @ -44,11 +44,11 @@ var ( | |||
| ) | ||||
| 
 | ||||
| const ( | ||||
| 	Hosturl                 = "https://ci.jenkins.io/job/Infra/job/plugin-site-api/job/generate-data/lastSuccessfulBuild/artifact/plugins.json.gzip" | ||||
| 	CompressedFilePath      = "/tmp/plugins.json.gzip" | ||||
| 	PluginDataFile          = "/tmp/plugins.json" | ||||
| 	shortenedCheckingPeriod = 1 * time.Hour | ||||
| 	defaultCheckingPeriod   = 12 * time.Minute | ||||
| 	Hosturl                      = "https://ci.jenkins.io/job/Infra/job/plugin-site-api/job/generate-data/lastSuccessfulBuild/artifact/plugins.json.gzip" | ||||
| 	PluginDataFileCompressedPath = "/tmp/plugins.json.gzip" | ||||
| 	PluginDataFile               = "/tmp/plugins.json" | ||||
| 	shortenedCheckingPeriod      = 1 * time.Hour | ||||
| 	defaultCheckingPeriod        = 12 * time.Minute | ||||
| ) | ||||
| 
 | ||||
| func (in *Jenkins) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||||
|  | @ -58,30 +58,31 @@ func (in *Jenkins) SetupWebhookWithManager(mgr ctrl.Manager) error { | |||
| } | ||||
| 
 | ||||
| // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
 | ||||
| // +kubebuilder:webhook:path=/validate-jenkins-io-jenkins-io-v1alpha2-jenkins,mutating=false,failurePolicy=fail,sideEffects=None,groups=jenkins.io.jenkins.io,resources=jenkins,verbs=create;update,versions=v1alpha2,name=vjenkins.kb.io,admissionReviewVersions={v1,v1beta1}
 | ||||
| // +kubebuilder:webhook:path=/validate-jenkins-io-jenkins-io-v1alpha2-jenkins,mutating=false,failurePolicy=fail,sideEffects=None,groups=jenkins.io.jenkins.io,resources=jenkins,verbs=create;update,versions=v1alpha2,name=vjenkins.kb.io,admissionReviewVersions={v1}
 | ||||
| 
 | ||||
| // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 | ||||
| func (in *Jenkins) ValidateCreate() error { | ||||
| func (in *Jenkins) ValidateCreate() (admission.Warnings, error) { | ||||
| 	if in.Spec.ValidateSecurityWarnings { | ||||
| 		jenkinslog.Info("validate create", "name", in.Name) | ||||
| 		return Validate(*in) | ||||
| 		err := Validate(*in) | ||||
| 		return nil, err | ||||
| 	} | ||||
| 
 | ||||
| 	return nil | ||||
| 	return nil, nil | ||||
| } | ||||
| 
 | ||||
| // ValidateUpdate implements webhook.Validator so a webhook will be registered for the type
 | ||||
| func (in *Jenkins) ValidateUpdate(old runtime.Object) error { | ||||
| func (in *Jenkins) ValidateUpdate(old runtime.Object) (admission.Warnings, error) { | ||||
| 	if in.Spec.ValidateSecurityWarnings { | ||||
| 		jenkinslog.Info("validate update", "name", in.Name) | ||||
| 		return Validate(*in) | ||||
| 		return nil, Validate(*in) | ||||
| 	} | ||||
| 
 | ||||
| 	return nil | ||||
| 	return nil, nil | ||||
| } | ||||
| 
 | ||||
| func (in *Jenkins) ValidateDelete() error { | ||||
| 	return nil | ||||
| func (in *Jenkins) ValidateDelete() (admission.Warnings, error) { | ||||
| 	return nil, nil | ||||
| } | ||||
| 
 | ||||
| type SecurityValidator struct { | ||||
|  | @ -263,11 +264,17 @@ func (in *SecurityValidator) fetchPluginData() error { | |||
| } | ||||
| 
 | ||||
| func (in *SecurityValidator) download() error { | ||||
| 	out, err := os.Create(CompressedFilePath) | ||||
| 	pluginDataFileCompressed, err := os.Create(PluginDataFileCompressedPath) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	defer out.Close() | ||||
| 
 | ||||
| 	// ensure pluginDataFileCompressed is closed
 | ||||
| 	defer func() { | ||||
| 		if err := pluginDataFileCompressed.Close(); err != nil { | ||||
| 			jenkinslog.V(log.VDebug).Info("Failed to close SecurityValidator.download io", "error", err) | ||||
| 		} | ||||
| 	}() | ||||
| 
 | ||||
| 	req, err := http.NewRequest(http.MethodGet, Hosturl, nil) | ||||
| 	if err != nil { | ||||
|  | @ -284,30 +291,45 @@ func (in *SecurityValidator) download() error { | |||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	defer response.Body.Close() | ||||
| 	defer httpResponseCloser(response) | ||||
| 
 | ||||
| 	_, err = io.Copy(pluginDataFileCompressed, response.Body) | ||||
| 
 | ||||
| 	_, err = io.Copy(out, response.Body) | ||||
| 	return err | ||||
| } | ||||
| 
 | ||||
| func (in *SecurityValidator) extract() error { | ||||
| 	reader, err := os.Open(CompressedFilePath) | ||||
| 	reader, err := os.Open(PluginDataFileCompressedPath) | ||||
| 
 | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	defer reader.Close() | ||||
| 	defer func() { | ||||
| 		if err := reader.Close(); err != nil { | ||||
| 			log.Log.Error(err, "failed to close SecurityValidator.extract.reader ") | ||||
| 		} | ||||
| 	}() | ||||
| 
 | ||||
| 	archive, err := gzip.NewReader(reader) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	defer archive.Close() | ||||
| 	defer func() { | ||||
| 		if err := archive.Close(); err != nil { | ||||
| 			log.Log.Error(err, "failed to close SecurityValidator.extract.archive ") | ||||
| 		} | ||||
| 	}() | ||||
| 	writer, err := os.Create(PluginDataFile) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	defer writer.Close() | ||||
| 
 | ||||
| 	defer func() { | ||||
| 		if err := writer.Close(); err != nil { | ||||
| 			log.Log.Error(err, "failed to close SecurityValidator.extract.writer") | ||||
| 		} | ||||
| 	}() | ||||
| 
 | ||||
| 	_, err = io.Copy(writer, archive) | ||||
| 	return err | ||||
|  | @ -319,8 +341,12 @@ func (in *SecurityValidator) cache() error { | |||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	defer jsonFile.Close() | ||||
| 	byteValue, err := ioutil.ReadAll(jsonFile) | ||||
| 	defer func() { | ||||
| 		if err := jsonFile.Close(); err != nil { | ||||
| 			log.Log.Error(err, "failed to close SecurityValidator.cache.jsonFile") | ||||
| 		} | ||||
| 	}() | ||||
| 	byteValue, err := io.ReadAll(jsonFile) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
|  | @ -346,3 +372,9 @@ func compareVersions(firstVersion string, lastVersion string, pluginVersion stri | |||
| 	} | ||||
| 	return true | ||||
| } | ||||
| 
 | ||||
| func httpResponseCloser(response *http.Response) { | ||||
| 	if err := response.Body.Close(); err != nil { | ||||
| 		log.Log.Error(err, "failed to close http response body") | ||||
| 	} | ||||
| } | ||||
|  |  | |||
|  | @ -79,7 +79,7 @@ func TestValidate(t *testing.T) { | |||
| 	t.Run("Validating when plugins data file is not fetched", func(t *testing.T) { | ||||
| 		userplugins := []Plugin{{Name: "script-security", Version: "1.77"}, {Name: "git-client", Version: "3.9"}, {Name: "git", Version: "4.8.1"}, {Name: "plain-credentials", Version: "1.7"}} | ||||
| 		jenkinscr := *createJenkinsCR(userplugins, true) | ||||
| 		got := jenkinscr.ValidateCreate() | ||||
| 		_, got := jenkinscr.ValidateCreate() | ||||
| 		assert.Equal(t, got, errors.New("plugins data has not been fetched")) | ||||
| 	}) | ||||
| 
 | ||||
|  | @ -95,7 +95,7 @@ func TestValidate(t *testing.T) { | |||
| 			{Name: "plain-credentials"}}} | ||||
| 		userplugins := []Plugin{{Name: "script-security", Version: "1.77"}, {Name: "git-client", Version: "3.9"}, {Name: "git", Version: "4.8.1"}, {Name: "plain-credentials", Version: "1.7"}} | ||||
| 		jenkinscr := *createJenkinsCR(userplugins, true) | ||||
| 		got := jenkinscr.ValidateCreate() | ||||
| 		_, got := jenkinscr.ValidateCreate() | ||||
| 		assert.Nil(t, got) | ||||
| 	}) | ||||
| 
 | ||||
|  | @ -113,7 +113,7 @@ func TestValidate(t *testing.T) { | |||
| 		}} | ||||
| 		userplugins := []Plugin{{Name: "google-login", Version: "1.2"}, {Name: "mailer", Version: "1.1"}, {Name: "git", Version: "4.8.1"}, {Name: "command-launcher", Version: "1.6"}, {Name: "workflow-cps", Version: "2.59"}} | ||||
| 		jenkinscr := *createJenkinsCR(userplugins, true) | ||||
| 		got := jenkinscr.ValidateCreate() | ||||
| 		_, got := jenkinscr.ValidateCreate() | ||||
| 		assert.Equal(t, got, errors.New("security vulnerabilities detected in the following user-defined plugins: \nworkflow-cps:2.59\ngoogle-login:1.2\nmailer:1.1")) | ||||
| 	}) | ||||
| 
 | ||||
|  | @ -136,19 +136,19 @@ func TestValidate(t *testing.T) { | |||
| 
 | ||||
| 		userplugins = []Plugin{{Name: "handy-uri-templates-2-api", Version: "2.1.8-1.0"}, {Name: "resource-disposer", Version: "0.8"}, {Name: "jjwt-api", Version: "0.11.2-9.c8b45b8bb173"}, {Name: "blueocean-github-pipeline", Version: "1.2.0-beta-3"}, {Name: "ghprb", Version: "1.39"}} | ||||
| 		newjenkinscr := *createJenkinsCR(userplugins, true) | ||||
| 		got := newjenkinscr.ValidateUpdate(&oldjenkinscr) | ||||
| 		_, got := newjenkinscr.ValidateUpdate(&oldjenkinscr) | ||||
| 		assert.Equal(t, got, errors.New("security vulnerabilities detected in the following user-defined plugins: \nhandy-uri-templates-2-api:2.1.8-1.0\nresource-disposer:0.8\nblueocean-github-pipeline:1.2.0-beta-3\nghprb:1.39")) | ||||
| 	}) | ||||
| 
 | ||||
| 	t.Run("Validation is turned off", func(t *testing.T) { | ||||
| 		userplugins := []Plugin{{Name: "google-login", Version: "1.2"}, {Name: "mailer", Version: "1.1"}, {Name: "git", Version: "4.8.1"}, {Name: "command-launcher", Version: "1.6"}, {Name: "workflow-cps", Version: "2.59"}} | ||||
| 		jenkinscr := *createJenkinsCR(userplugins, false) | ||||
| 		got := jenkinscr.ValidateCreate() | ||||
| 		_, got := jenkinscr.ValidateCreate() | ||||
| 		assert.Nil(t, got) | ||||
| 
 | ||||
| 		userplugins = []Plugin{{Name: "google-login", Version: "1.2"}, {Name: "mailer", Version: "1.1"}, {Name: "git", Version: "4.8.1"}, {Name: "command-launcher", Version: "1.6"}, {Name: "workflow-cps", Version: "2.59"}} | ||||
| 		newjenkinscr := *createJenkinsCR(userplugins, false) | ||||
| 		got = newjenkinscr.ValidateUpdate(&jenkinscr) | ||||
| 		_, got = newjenkinscr.ValidateUpdate(&jenkinscr) | ||||
| 		assert.Nil(t, got) | ||||
| 	}) | ||||
| } | ||||
|  |  | |||
|  | @ -1,4 +1,4 @@ | |||
| // +build !ignore_autogenerated
 | ||||
| //go:build !ignore_autogenerated
 | ||||
| 
 | ||||
| /* | ||||
| Copyright 2021. | ||||
|  |  | |||
|  | @ -25,7 +25,7 @@ RUN apt update \ | |||
|     "$USER" | ||||
| 
 | ||||
| COPY bin/*.sh /home/user/bin/ | ||||
| RUN chmod +x /home/user/bin/*.sh | ||||
| RUN chmod -R a+rx /home/user | ||||
| WORKDIR /home/user/bin | ||||
| USER user | ||||
| 
 | ||||
|  |  | |||
|  | @ -1 +1 @@ | |||
| v0.4.0 | ||||
| v0.4.2 | ||||
|  |  | |||
|  | @ -24,6 +24,7 @@ is_backup_not_exist() { | |||
| 
 | ||||
| # Check if we have any backup | ||||
| if is_backup_not_exist "${BACKUP_DIR}"; then | ||||
|   _log "No backups exist in ${BACKUP_DIR}" | ||||
|   echo "-1" | ||||
|   exit 0 | ||||
| fi | ||||
|  | @ -32,6 +33,7 @@ fi | |||
| latest=$(find "${BACKUP_DIR}"/*.tar.* -maxdepth 0 -exec basename {} \; | sort -g | tail -n 1) | ||||
| 
 | ||||
| if [[ "${latest}" == "" ]]; then | ||||
|   _log "Could not get the latest backup." | ||||
|   echo "-1" | ||||
| else | ||||
|   echo "${latest%%.*}" | ||||
|  |  | |||
|  | @ -54,7 +54,7 @@ Kubernetes native operator which fully manages Jenkins on Kubernetes | |||
| | jenkins.enabled | bool | `true` |  | | ||||
| | jenkins.env | list | `[]` |  | | ||||
| | jenkins.hostAliases | object | `{}` |  | | ||||
| | jenkins.image | string | `"jenkins/jenkins:2.462.3-lts"` |  | | ||||
| | jenkins.image | string | `"jenkins/jenkins:2.479.2-lts"` |  | | ||||
| | jenkins.imagePullPolicy | string | `"Always"` |  | | ||||
| | jenkins.imagePullSecrets | list | `[]` |  | | ||||
| | jenkins.labels | object | `{}` |  | | ||||
|  | @ -113,4 +113,4 @@ Kubernetes native operator which fully manages Jenkins on Kubernetes | |||
| | webhook.enabled | bool | `false` |  | | ||||
| 
 | ||||
| ---------------------------------------------- | ||||
| Autogenerated from chart metadata using [helm-docs v1.11.2](https://github.com/norwoodj/helm-docs/releases/v1.11.2) | ||||
| Autogenerated from chart metadata using [helm-docs v1.13.1](https://github.com/norwoodj/helm-docs/releases/v1.13.1) | ||||
|  |  | |||
|  | @ -36,7 +36,7 @@ jenkins: | |||
|   # image is the name (and tag) of the Jenkins instance | ||||
|   # Default: jenkins/jenkins:lts | ||||
|   # It's recommended to use LTS (tag: "lts") version | ||||
|   image: jenkins/jenkins:2.462.3-lts | ||||
|   image: jenkins/jenkins:2.479.2-lts | ||||
| 
 | ||||
|   # env contains jenkins container environment variables | ||||
|   env: [] | ||||
|  |  | |||
|  | @ -23,7 +23,7 @@ import ( | |||
| 	r "runtime" | ||||
| 
 | ||||
| 	"github.com/jenkinsci/kubernetes-operator/api/v1alpha2" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/controllers" | ||||
| 	controllers "github.com/jenkinsci/kubernetes-operator/internal/controller" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/client" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/configuration/base/resources" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/constants" | ||||
|  | @ -40,7 +40,10 @@ import ( | |||
| 	utilruntime "k8s.io/apimachinery/pkg/util/runtime" | ||||
| 	"k8s.io/client-go/kubernetes" | ||||
| 	clientgoscheme "k8s.io/client-go/kubernetes/scheme" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/cache" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/client/config" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/metrics/server" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/webhook" | ||||
| 
 | ||||
| 	// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
 | ||||
| 	// to ensure that exec-entrypoint and run can make use of them.
 | ||||
|  | @ -126,14 +129,23 @@ func main() { | |||
| 		fatal(errors.Wrap(err, "failed to get config"), *debug) | ||||
| 	} | ||||
| 
 | ||||
| 	cacheNamespace := map[string]cache.Config{} | ||||
| 	cacheNamespace[namespace] = cache.Config{} | ||||
| 	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ | ||||
| 		Scheme:                 scheme, | ||||
| 		MetricsBindAddress:     fmt.Sprintf("%s:%d", metricsHost, metricsPort), | ||||
| 		Port:                   9443, | ||||
| 		// MetricsBindAddress:      fmt.Sprintf("%s:%d", metricsHost, metricsPort),
 | ||||
| 		Metrics: server.Options{ | ||||
| 			BindAddress: fmt.Sprintf("%s:%d", metricsHost, metricsPort), | ||||
| 		}, | ||||
| 		Scheme: scheme, | ||||
| 		// Port:                    9443,
 | ||||
| 		WebhookServer: webhook.NewServer(webhook.Options{ | ||||
| 			Port: 9443, | ||||
| 		}), | ||||
| 		HealthProbeBindAddress: probeAddr, | ||||
| 		LeaderElection:         enableLeaderElection, | ||||
| 		LeaderElectionID:       "c674355f.jenkins.io", | ||||
| 		Namespace:              namespace, | ||||
| 		// Namespace:              namespace,
 | ||||
| 		Cache: cache.Options{DefaultNamespaces: cacheNamespace}, | ||||
| 	}) | ||||
| 	if err != nil { | ||||
| 		fatal(errors.Wrap(err, "unable to start manager"), *debug) | ||||
|  | @ -3,14 +3,14 @@ API_VERSION_NEXT="v1alpha3" | |||
| API_VERSION="v1alpha2" | ||||
| CLUSTER_DOMAIN="cluster.local" | ||||
| GEN_CRD_API="gen-crd-api-reference-docs" | ||||
| GO_VERSION="1.15.6" | ||||
| GO_VERSION="1.22" | ||||
| HELM_VERSION="3.12.3" | ||||
| IMAGE_PULL_MODE="local" | ||||
| KIND_CLUSTER_NAME="jenkins" | ||||
| LATEST_LTS_VERSION="2.462.3" | ||||
| LATEST_LTS_VERSION="2.479.2" | ||||
| NAME="kubernetes-operator" | ||||
| NAMESPACE="default" | ||||
| OPERATOR_SDK_VERSION="1.3.0" | ||||
| OPERATOR_SDK_VERSION="1.35.0" | ||||
| PKG="github.com/jenkinsci/kubernetes-operator" | ||||
| QUAY_ORGANIZATION="jenkins-kubernetes-operator" | ||||
| QUAY_REGISTRY="operator" | ||||
|  |  | |||
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							|  | @ -28,7 +28,9 @@ patchesStrategicMerge: | |||
| # Protect the /metrics endpoint by putting it behind auth. | ||||
| # If you want your controller-manager to expose the /metrics | ||||
| # endpoint w/o any authn/z, please comment the following line. | ||||
| - manager_auth_proxy_patch.yaml | ||||
| # Mount the controller config file for loading manager configurations | ||||
| # through a ComponentConfig type | ||||
| - manager_config_patch.yaml | ||||
| 
 | ||||
| # Mount the controller config file for loading manager configurations | ||||
| # through a ComponentConfig type | ||||
|  |  | |||
|  | @ -10,15 +10,23 @@ spec: | |||
|     spec: | ||||
|       containers: | ||||
|       - name: kube-rbac-proxy | ||||
|         image: gcr.io/kubebuilder/kube-rbac-proxy:v0.5.0 | ||||
|         image: gcr.io/kubebuilder/kube-rbac-proxy:v0.13.1 | ||||
|         args: | ||||
|         - "--secure-listen-address=0.0.0.0:8443" | ||||
|         - "--upstream=http://127.0.0.1:8080/" | ||||
|         - "--logtostderr=true" | ||||
|         - "--v=10" | ||||
|         - "--v=0" | ||||
|         ports: | ||||
|         - containerPort: 8443 | ||||
|           protocol: TCP | ||||
|           name: https | ||||
|         resources: | ||||
|           limits: | ||||
|             cpu: 500m | ||||
|             memory: 128Mi | ||||
|           requests: | ||||
|             cpu: 5m | ||||
|             memory: 64Mi | ||||
|       - name: manager | ||||
|         args: | ||||
|         - "--health-probe-bind-address=:8081" | ||||
|  |  | |||
|  | @ -14,6 +14,8 @@ spec: | |||
|     metadata: | ||||
|       labels: | ||||
|         control-plane: controller-manager | ||||
|       annotations: | ||||
|         kubectl.kubernetes.io/default-container: manager | ||||
|     spec: | ||||
|       serviceAccountName: jenkins-operator | ||||
|       securityContext: | ||||
|  | @ -23,7 +25,7 @@ spec: | |||
|         - /manager | ||||
|         args: | ||||
|         - --leader-elect | ||||
|         image: virtuslab/jenkins-operator:v0.7.1 | ||||
|         image: quay.io/jenkins-kubernetes-operator/operator:v0.8.0 | ||||
|         name: jenkins-operator | ||||
|         imagePullPolicy: IfNotPresent | ||||
|         securityContext: | ||||
|  | @ -42,8 +44,8 @@ spec: | |||
|           periodSeconds: 10 | ||||
|         resources: | ||||
|           limits: | ||||
|             cpu: 100m | ||||
|             memory: 30Mi | ||||
|             cpu: 200m | ||||
|             memory: 100Mi | ||||
|           requests: | ||||
|             cpu: 100m | ||||
|             memory: 20Mi | ||||
|  | @ -52,4 +54,5 @@ spec: | |||
|             valueFrom: | ||||
|               fieldRef: | ||||
|                 fieldPath: metadata.namespace | ||||
|       serviceAccountName: controller-manager | ||||
|       terminationGracePeriodSeconds: 10 | ||||
|  |  | |||
|  | @ -1,4 +1,3 @@ | |||
| 
 | ||||
| # Prometheus Monitor Service (Metrics) | ||||
| apiVersion: monitoring.coreos.com/v1 | ||||
| kind: ServiceMonitor | ||||
|  | @ -11,6 +10,10 @@ spec: | |||
|   endpoints: | ||||
|     - path: /metrics | ||||
|       port: https | ||||
|       scheme: https | ||||
|       bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token | ||||
|       tlsConfig: | ||||
|         insecureSkipVerify: true | ||||
|   selector: | ||||
|     matchLabels: | ||||
|       control-plane: controller-manager | ||||
|  |  | |||
|  | @ -8,5 +8,5 @@ roleRef: | |||
|   name: proxy-role | ||||
| subjects: | ||||
| - kind: ServiceAccount | ||||
|   name: default | ||||
|   name: controller-manager | ||||
|   namespace: default | ||||
|  |  | |||
|  | @ -9,6 +9,7 @@ spec: | |||
|   ports: | ||||
|   - name: https | ||||
|     port: 8443 | ||||
|     protocol: TCP | ||||
|     targetPort: https | ||||
|   selector: | ||||
|     control-plane: controller-manager | ||||
|  |  | |||
|  | @ -10,3 +10,4 @@ resources: | |||
| - auth_proxy_role.yaml | ||||
| - auth_proxy_role_binding.yaml | ||||
| - auth_proxy_client_clusterrole.yaml | ||||
| - service_account.yaml | ||||
|  |  | |||
|  | @ -7,9 +7,19 @@ metadata: | |||
| rules: | ||||
| - apiGroups: | ||||
|   - "" | ||||
|   - coordination.k8s.io | ||||
|   resources: | ||||
|   - configmaps | ||||
|   verbs: | ||||
|   - get | ||||
|   - list | ||||
|   - watch | ||||
|   - create | ||||
|   - update | ||||
|   - patch | ||||
|   - delete | ||||
| - apiGroups: | ||||
|   - coordination.k8s.io | ||||
|   resources: | ||||
|   - leases | ||||
|   verbs: | ||||
|   - get | ||||
|  |  | |||
|  | @ -1,9 +1,7 @@ | |||
| 
 | ||||
| --- | ||||
| apiVersion: rbac.authorization.k8s.io/v1 | ||||
| kind: ClusterRole | ||||
| metadata: | ||||
|   creationTimestamp: null | ||||
|   name: manager-role | ||||
| rules: | ||||
| - apiGroups: | ||||
|  |  | |||
|  | @ -0,0 +1,5 @@ | |||
| apiVersion: v1 | ||||
| kind: ServiceAccount | ||||
| metadata: | ||||
|   name: controller-manager | ||||
|   namespace: system | ||||
|  | @ -1,14 +1,11 @@ | |||
| 
 | ||||
| --- | ||||
| apiVersion: admissionregistration.k8s.io/v1 | ||||
| kind: ValidatingWebhookConfiguration | ||||
| metadata: | ||||
|   creationTimestamp: null | ||||
|   name: validating-webhook-configuration | ||||
| webhooks: | ||||
| - admissionReviewVersions: | ||||
|   - v1 | ||||
|   - v1beta1 | ||||
|   clientConfig: | ||||
|     service: | ||||
|       name: webhook-service | ||||
|  |  | |||
|  | @ -7,6 +7,7 @@ metadata: | |||
| spec: | ||||
|   ports: | ||||
|     - port: 443 | ||||
|       protocol: TCP | ||||
|       targetPort: 9443 | ||||
|   selector: | ||||
|     control-plane: controller-manager | ||||
|  |  | |||
							
								
								
									
										73
									
								
								flake.lock
								
								
								
								
							
							
						
						
									
										73
									
								
								flake.lock
								
								
								
								
							|  | @ -5,11 +5,11 @@ | |||
|         "systems": "systems" | ||||
|       }, | ||||
|       "locked": { | ||||
|         "lastModified": 1705309234, | ||||
|         "narHash": "sha256-uNRRNRKmJyCRC/8y1RqBkqWBLM034y4qN7EprSdmgyA=", | ||||
|         "lastModified": 1731533236, | ||||
|         "narHash": "sha256-l0KFg5HjrsfsO/JpG+r7fRrqm12kzFHyUHqHCVpMMbI=", | ||||
|         "owner": "numtide", | ||||
|         "repo": "flake-utils", | ||||
|         "rev": "1ef2e671c3b0c19053962c07dbda38332dcebf26", | ||||
|         "rev": "11707dc2f618dd54ca8739b309ec4fc024de578b", | ||||
|         "type": "github" | ||||
|       }, | ||||
|       "original": { | ||||
|  | @ -18,53 +18,21 @@ | |||
|         "type": "github" | ||||
|       } | ||||
|     }, | ||||
|     "go_15": { | ||||
|       "locked": { | ||||
|         "lastModified": 1610974077, | ||||
|         "narHash": "sha256-kfU2R7Q6eMU34VooazWvCqxOKwQOApCYh9TH79oZ8VA=", | ||||
|         "owner": "nixos", | ||||
|         "repo": "nixpkgs", | ||||
|         "rev": "4eccd6f731627ba5ad9915bcf600c9329a34ca78", | ||||
|         "type": "github" | ||||
|       }, | ||||
|       "original": { | ||||
|         "owner": "nixos", | ||||
|         "repo": "nixpkgs", | ||||
|         "rev": "4eccd6f731627ba5ad9915bcf600c9329a34ca78", | ||||
|         "type": "github" | ||||
|       } | ||||
|     }, | ||||
|     "golangci": { | ||||
|       "locked": { | ||||
|         "lastModified": 1593485095, | ||||
|         "narHash": "sha256-cgfJfZKqPgqQ1fdFWdpNnDEO2HmIVIDCvBTGke2LpnI=", | ||||
|         "owner": "nixos", | ||||
|         "repo": "nixpkgs", | ||||
|         "rev": "e912fb83d2155a393e7146da98cda0e455a80fb6", | ||||
|         "type": "github" | ||||
|       }, | ||||
|       "original": { | ||||
|         "owner": "nixos", | ||||
|         "repo": "nixpkgs", | ||||
|         "rev": "e912fb83d2155a393e7146da98cda0e455a80fb6", | ||||
|         "type": "github" | ||||
|       } | ||||
|     }, | ||||
|     "gomod2nix": { | ||||
|       "inputs": { | ||||
|         "flake-utils": [ | ||||
|           "flake-utils" | ||||
|         ], | ||||
|         "nixpkgs": [ | ||||
|           "nixpkgs" | ||||
|           "nixpkgs-rolling" | ||||
|         ] | ||||
|       }, | ||||
|       "locked": { | ||||
|         "lastModified": 1705314449, | ||||
|         "narHash": "sha256-yfQQ67dLejP0FLK76LKHbkzcQqNIrux6MFe32MMFGNQ=", | ||||
|         "lastModified": 1742209644, | ||||
|         "narHash": "sha256-jMy1XqXqD0/tJprEbUmKilTkvbDY/C0ZGSsJJH4TNCE=", | ||||
|         "owner": "nix-community", | ||||
|         "repo": "gomod2nix", | ||||
|         "rev": "30e3c3a9ec4ac8453282ca7f67fca9e1da12c3e6", | ||||
|         "rev": "8f3534eb8f6c5c3fce799376dc3b91bae6b11884", | ||||
|         "type": "github" | ||||
|       }, | ||||
|       "original": { | ||||
|  | @ -91,11 +59,27 @@ | |||
|     }, | ||||
|     "nixpkgs": { | ||||
|       "locked": { | ||||
|         "lastModified": 1707451808, | ||||
|         "narHash": "sha256-UwDBUNHNRsYKFJzyTMVMTF5qS4xeJlWoeyJf+6vvamU=", | ||||
|         "lastModified": 1743231893, | ||||
|         "narHash": "sha256-tpJsHMUPEhEnzySoQxx7+kA+KUtgWqvlcUBqROYNNt0=", | ||||
|         "owner": "nixos", | ||||
|         "repo": "nixpkgs", | ||||
|         "rev": "442d407992384ed9c0e6d352de75b69079904e4e", | ||||
|         "rev": "c570c1f5304493cafe133b8d843c7c1c4a10d3a6", | ||||
|         "type": "github" | ||||
|       }, | ||||
|       "original": { | ||||
|         "owner": "nixos", | ||||
|         "ref": "nixos-24.11", | ||||
|         "repo": "nixpkgs", | ||||
|         "type": "github" | ||||
|       } | ||||
|     }, | ||||
|     "nixpkgs-rolling": { | ||||
|       "locked": { | ||||
|         "lastModified": 1743259260, | ||||
|         "narHash": "sha256-ArWLUgRm1tKHiqlhnymyVqi5kLNCK5ghvm06mfCl4QY=", | ||||
|         "owner": "nixos", | ||||
|         "repo": "nixpkgs", | ||||
|         "rev": "eb0e0f21f15c559d2ac7633dc81d079d1caf5f5f", | ||||
|         "type": "github" | ||||
|       }, | ||||
|       "original": { | ||||
|  | @ -108,11 +92,10 @@ | |||
|     "root": { | ||||
|       "inputs": { | ||||
|         "flake-utils": "flake-utils", | ||||
|         "go_15": "go_15", | ||||
|         "golangci": "golangci", | ||||
|         "gomod2nix": "gomod2nix", | ||||
|         "hugo_099": "hugo_099", | ||||
|         "nixpkgs": "nixpkgs" | ||||
|         "nixpkgs": "nixpkgs", | ||||
|         "nixpkgs-rolling": "nixpkgs-rolling" | ||||
|       } | ||||
|     }, | ||||
|     "systems": { | ||||
|  |  | |||
							
								
								
									
										55
									
								
								flake.nix
								
								
								
								
							
							
						
						
									
										55
									
								
								flake.nix
								
								
								
								
							|  | @ -2,55 +2,64 @@ | |||
|   description = "Jenkins Kubernetes Operator"; | ||||
| 
 | ||||
|   inputs = { | ||||
|     nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable"; | ||||
|     nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-24.11"; | ||||
|     nixpkgs-rolling.url = "github:nixos/nixpkgs/nixpkgs-unstable"; | ||||
|     flake-utils.url = "github:numtide/flake-utils"; | ||||
|     go_15.url = "github:nixos/nixpkgs/4eccd6f731627ba5ad9915bcf600c9329a34ca78"; | ||||
|     golangci.url = "github:nixos/nixpkgs/e912fb83d2155a393e7146da98cda0e455a80fb6"; | ||||
|     hugo_099.url = "github:nixos/nixpkgs/d6df226c53d46821bd4773bd7ec3375f30238edb"; | ||||
|     gomod2nix = { | ||||
|       url = "github:nix-community/gomod2nix"; | ||||
|       inputs.nixpkgs.follows = "nixpkgs"; | ||||
|       inputs.nixpkgs.follows = "nixpkgs-rolling"; | ||||
|       inputs.flake-utils.follows = "flake-utils"; | ||||
|     }; | ||||
|   }; | ||||
| 
 | ||||
|   outputs = { self, nixpkgs, flake-utils, go_15, golangci, gomod2nix, hugo_099, ... }: | ||||
|     flake-utils.lib.eachDefaultSystem (system: | ||||
|   outputs = | ||||
|     { | ||||
|       gomod2nix, | ||||
|       ... | ||||
|     }@inputs: | ||||
|     inputs.flake-utils.lib.eachDefaultSystem ( | ||||
|       system: | ||||
|       let | ||||
|         pkgs = nixpkgs.legacyPackages.${system}; | ||||
|         go_15_pkgs = go_15.legacyPackages.${system}; | ||||
|         golangci_pkgs = golangci.legacyPackages.${system}; | ||||
|         hugo_099_pkgs = hugo_099.legacyPackages.${system}; | ||||
|         pkgs = inputs.nixpkgs.legacyPackages.${system}; | ||||
|         rolling = inputs.nixpkgs-rolling.legacyPackages.${system}; | ||||
|         hugo_099_pkgs = inputs.hugo_099.legacyPackages.${system}; | ||||
|         operatorVersion = builtins.readFile ./VERSION.txt; | ||||
|         sdkVersion = ((builtins.fromTOML (builtins.readFile ./config.base.env)).OPERATOR_SDK_VERSION); | ||||
|         jenkinsLtsVersion = ((builtins.fromTOML (builtins.readFile ./config.base.env)).LATEST_LTS_VERSION); | ||||
|       in | ||||
|       { | ||||
|         # Nix fmt | ||||
|         formatter = nixpkgs.legacyPackages.${system}.nixpkgs-fmt; | ||||
|         formatter = pkgs.nixpkgs-fmt; | ||||
| 
 | ||||
|         # shell in nix develop | ||||
|         devShells.default = nixpkgs.legacyPackages.${system}.mkShell { | ||||
|         devShells.default = pkgs.mkShell { | ||||
|           packages = [ | ||||
|             pkgs.gnumake | ||||
|             pkgs.wget | ||||
|             pkgs.helm-docs | ||||
|             pkgs.pre-commit | ||||
|             pkgs.kind | ||||
|             pkgs.golangci-lint | ||||
|             pkgs.go_1_22 | ||||
|             rolling.operator-sdk # 1.39.2 | ||||
| 
 | ||||
|             (pkgs.bats.withLibraries (p: [ | ||||
|               p.bats-support | ||||
|               p.bats-assert | ||||
|               p.bats-file | ||||
|               p.bats-detik | ||||
|             ])) | ||||
| 
 | ||||
|             (pkgs.writeShellApplication { | ||||
|               name = "make_matrix"; | ||||
|               runtimeInputs = with pkgs; [ bash gnugrep gawk ]; | ||||
|               runtimeInputs = with pkgs; [ | ||||
|                 bash | ||||
|                 gnugrep | ||||
|                 gawk | ||||
|               ]; | ||||
|               text = builtins.readFile ./test/make_matrix_ginkgo.sh; | ||||
|             }) | ||||
|             go_15_pkgs.go | ||||
|             golangci_pkgs.golangci-lint | ||||
| 
 | ||||
|             pkgs.kind | ||||
|             (pkgs.bats.withLibraries (p: [ | ||||
|             p.bats-support | ||||
|             p.bats-assert | ||||
|             p.bats-file | ||||
|             p.bats-detik | ||||
|             ])) | ||||
|           ]; | ||||
|           shellHook = '' | ||||
|             echo Operator Version ${operatorVersion} | ||||
|  |  | |||
							
								
								
									
										117
									
								
								go.mod
								
								
								
								
							
							
						
						
									
										117
									
								
								go.mod
								
								
								
								
							|  | @ -1,31 +1,106 @@ | |||
| module github.com/jenkinsci/kubernetes-operator | ||||
| 
 | ||||
| go 1.15 | ||||
| go 1.22.12 | ||||
| 
 | ||||
| require ( | ||||
| 	github.com/bndr/gojenkins v1.0.1 | ||||
| 	github.com/docker/distribution v2.7.1+incompatible | ||||
| 	github.com/emersion/go-smtp v0.11.2 | ||||
| 	github.com/go-logr/logr v0.3.0 | ||||
| 	github.com/go-logr/zapr v0.2.0 | ||||
| 	github.com/golang/mock v1.4.1 | ||||
| 	github.com/bndr/gojenkins v1.1.0 | ||||
| 	github.com/distribution/reference v0.6.0 | ||||
| 	github.com/go-logr/logr v1.4.2 | ||||
| 	github.com/go-logr/zapr v1.3.0 | ||||
| 	github.com/golang/mock v1.6.0 | ||||
| 	github.com/mailgun/mailgun-go/v3 v3.6.4 | ||||
| 	github.com/onsi/ginkgo v1.14.1 | ||||
| 	github.com/onsi/gomega v1.10.2 | ||||
| 	github.com/opencontainers/go-digest v1.0.0 // indirect | ||||
| 	github.com/onsi/gomega v1.33.1 | ||||
| 	github.com/openshift/api v3.9.0+incompatible | ||||
| 	github.com/pkg/errors v0.9.1 | ||||
| 	github.com/stretchr/testify v1.6.1 | ||||
| 	go.uber.org/zap v1.15.0 | ||||
| 	golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0 | ||||
| 	gopkg.in/alexcesaro/quotedprintable.v3 v3.0.0-20150716171945-2caba252f4dc // indirect | ||||
| 	github.com/stretchr/testify v1.9.0 | ||||
| 	go.uber.org/zap v1.27.0 | ||||
| 	golang.org/x/crypto v0.25.0 | ||||
| 	golang.org/x/mod v0.19.0 | ||||
| 	gopkg.in/gomail.v2 v2.0.0-20160411212932-81ebce5c23df | ||||
| 	k8s.io/api v0.20.2 | ||||
| 	k8s.io/apimachinery v0.20.2 | ||||
| 	k8s.io/cli-runtime v0.20.2 | ||||
| 	k8s.io/client-go v0.20.2 | ||||
| 	k8s.io/utils v0.0.0-20201110183641-67b214c5f920 | ||||
| 	sigs.k8s.io/controller-runtime v0.7.0 | ||||
| 	golang.org/x/mod  v0.4.2 | ||||
| 
 | ||||
| 	k8s.io/api v0.30.3 | ||||
| 	k8s.io/apimachinery v0.30.3 | ||||
| 	k8s.io/cli-runtime v0.30.3 | ||||
| 	k8s.io/client-go v0.30.3 | ||||
| 	k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 | ||||
| 	sigs.k8s.io/controller-runtime v0.18.4 | ||||
| ) | ||||
| 
 | ||||
| require ( | ||||
| 	github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect | ||||
| 	github.com/beorn7/perks v1.0.1 // indirect | ||||
| 	github.com/blang/semver/v4 v4.0.0 // indirect | ||||
| 	github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||||
| 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||||
| 	github.com/emicklei/go-restful/v3 v3.12.1 // indirect | ||||
| 	github.com/evanphx/json-patch v5.9.0+incompatible // indirect | ||||
| 	github.com/evanphx/json-patch/v5 v5.9.0 // indirect | ||||
| 	github.com/fsnotify/fsnotify v1.7.0 // indirect | ||||
| 	github.com/go-chi/chi v4.1.2+incompatible // indirect | ||||
| 	github.com/go-errors/errors v1.5.1 // indirect | ||||
| 	github.com/go-openapi/jsonpointer v0.21.0 // indirect | ||||
| 	github.com/go-openapi/jsonreference v0.21.0 // indirect | ||||
| 	github.com/go-openapi/swag v0.23.0 // indirect | ||||
| 	github.com/gogo/protobuf v1.3.2 // indirect | ||||
| 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect | ||||
| 	github.com/golang/protobuf v1.5.4 // indirect | ||||
| 	github.com/google/btree v1.1.2 // indirect | ||||
| 	github.com/google/gnostic-models v0.6.8 // indirect | ||||
| 	github.com/google/go-cmp v0.6.0 // indirect | ||||
| 	github.com/google/gofuzz v1.2.0 // indirect | ||||
| 	github.com/google/pprof v0.0.0-20240721033354-7089f98c1d14 // indirect | ||||
| 	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect | ||||
| 	github.com/google/uuid v1.6.0 // indirect | ||||
| 	github.com/gorilla/websocket v1.5.3 // indirect | ||||
| 	github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 // indirect | ||||
| 	github.com/imdario/mergo v0.3.16 // indirect | ||||
| 	github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||||
| 	github.com/josharian/intern v1.0.0 // indirect | ||||
| 	github.com/json-iterator/go v1.1.12 // indirect | ||||
| 	github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect | ||||
| 	github.com/mailru/easyjson v0.7.7 // indirect | ||||
| 	github.com/moby/spdystream v0.4.0 // indirect | ||||
| 	github.com/moby/term v0.5.0 // indirect | ||||
| 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||||
| 	github.com/modern-go/reflect2 v1.0.2 // indirect | ||||
| 	github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect | ||||
| 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||||
| 	github.com/mxk/go-flowrate v0.0.0-20140419014527-cca7078d478f // indirect | ||||
| 	github.com/nxadm/tail v1.4.11 // indirect | ||||
| 	github.com/opencontainers/go-digest v1.0.0 // indirect | ||||
| 	github.com/peterbourgon/diskv v2.0.1+incompatible // indirect | ||||
| 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect | ||||
| 	github.com/prometheus/client_golang v1.19.1 // indirect | ||||
| 	github.com/prometheus/client_model v0.6.1 // indirect | ||||
| 	github.com/prometheus/common v0.55.0 // indirect | ||||
| 	github.com/prometheus/procfs v0.15.1 // indirect | ||||
| 	github.com/spf13/cobra v1.8.1 // indirect | ||||
| 	github.com/spf13/pflag v1.0.5 // indirect | ||||
| 	github.com/xlab/treeprint v1.2.0 // indirect | ||||
| 	go.starlark.net v0.0.0-20240705175910-70002002b310 // indirect | ||||
| 	go.uber.org/multierr v1.11.0 // indirect | ||||
| 	golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 // indirect | ||||
| 	golang.org/x/net v0.27.0 // indirect | ||||
| 	golang.org/x/oauth2 v0.21.0 // indirect | ||||
| 	golang.org/x/sync v0.7.0 // indirect | ||||
| 	golang.org/x/sys v0.22.0 // indirect | ||||
| 	golang.org/x/term v0.22.0 // indirect | ||||
| 	golang.org/x/text v0.16.0 // indirect | ||||
| 	golang.org/x/time v0.5.0 // indirect | ||||
| 	gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect | ||||
| 	google.golang.org/protobuf v1.34.2 // indirect | ||||
| 	gopkg.in/alexcesaro/quotedprintable.v3 v3.0.0-20150716171945-2caba252f4dc // indirect | ||||
| 	gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect | ||||
| 	gopkg.in/inf.v0 v0.9.1 // indirect | ||||
| 	gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect | ||||
| 	gopkg.in/yaml.v2 v2.4.0 // indirect | ||||
| 	gopkg.in/yaml.v3 v3.0.1 // indirect | ||||
| 	k8s.io/apiextensions-apiserver v0.30.3 // indirect | ||||
| 	k8s.io/klog/v2 v2.130.1 // indirect | ||||
| 	k8s.io/kube-openapi v0.0.0-20240709000822-3c01b740850f // indirect | ||||
| 	sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect | ||||
| 	sigs.k8s.io/kustomize/api v0.17.3 // indirect | ||||
| 	sigs.k8s.io/kustomize/kyaml v0.17.2 // indirect | ||||
| 	sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect | ||||
| 	sigs.k8s.io/yaml v1.4.0 // indirect | ||||
| ) | ||||
|  |  | |||
|  | @ -1,6 +1,7 @@ | |||
| package controllers | ||||
| 
 | ||||
| import ( | ||||
| 	"context" | ||||
| 	"fmt" | ||||
| 	"reflect" | ||||
| 
 | ||||
|  | @ -19,15 +20,15 @@ import ( | |||
| // enqueueRequestForJenkins enqueues a Request for Secrets and ConfigMaps created by jenkins-operator.
 | ||||
| type enqueueRequestForJenkins struct{} | ||||
| 
 | ||||
| func (e *enqueueRequestForJenkins) Create(evt event.CreateEvent, q workqueue.RateLimitingInterface) { | ||||
| 	if req := e.getOwnerReconcileRequests(evt.Object); req != nil { | ||||
| func (e *enqueueRequestForJenkins) Create(ctx context.Context, evt event.CreateEvent, q workqueue.RateLimitingInterface) { | ||||
| 	if req := e.getOwnerReconcileRequests(ctx, evt.Object); req != nil { | ||||
| 		q.Add(*req) | ||||
| 	} | ||||
| } | ||||
| 
 | ||||
| func (e *enqueueRequestForJenkins) Update(evt event.UpdateEvent, q workqueue.RateLimitingInterface) { | ||||
| 	req1 := e.getOwnerReconcileRequests(evt.ObjectOld) | ||||
| 	req2 := e.getOwnerReconcileRequests(evt.ObjectNew) | ||||
| func (e *enqueueRequestForJenkins) Update(ctx context.Context, evt event.UpdateEvent, q workqueue.RateLimitingInterface) { | ||||
| 	req1 := e.getOwnerReconcileRequests(ctx, evt.ObjectOld) | ||||
| 	req2 := e.getOwnerReconcileRequests(ctx, evt.ObjectNew) | ||||
| 
 | ||||
| 	if req1 != nil || req2 != nil { | ||||
| 		jenkinsName := "unknown" | ||||
|  | @ -51,19 +52,19 @@ func (e *enqueueRequestForJenkins) Update(evt event.UpdateEvent, q workqueue.Rat | |||
| 	} | ||||
| } | ||||
| 
 | ||||
| func (e *enqueueRequestForJenkins) Delete(evt event.DeleteEvent, q workqueue.RateLimitingInterface) { | ||||
| 	if req := e.getOwnerReconcileRequests(evt.Object); req != nil { | ||||
| func (e *enqueueRequestForJenkins) Delete(ctx context.Context, evt event.DeleteEvent, q workqueue.RateLimitingInterface) { | ||||
| 	if req := e.getOwnerReconcileRequests(ctx, evt.Object); req != nil { | ||||
| 		q.Add(*req) | ||||
| 	} | ||||
| } | ||||
| 
 | ||||
| func (e *enqueueRequestForJenkins) Generic(evt event.GenericEvent, q workqueue.RateLimitingInterface) { | ||||
| 	if req := e.getOwnerReconcileRequests(evt.Object); req != nil { | ||||
| func (e *enqueueRequestForJenkins) Generic(ctx context.Context, evt event.GenericEvent, q workqueue.RateLimitingInterface) { | ||||
| 	if req := e.getOwnerReconcileRequests(ctx, evt.Object); req != nil { | ||||
| 		q.Add(*req) | ||||
| 	} | ||||
| } | ||||
| 
 | ||||
| func (e *enqueueRequestForJenkins) getOwnerReconcileRequests(object metav1.Object) *reconcile.Request { | ||||
| func (e *enqueueRequestForJenkins) getOwnerReconcileRequests(_ context.Context, object metav1.Object) *reconcile.Request { | ||||
| 	if object.GetLabels()[constants.LabelAppKey] == constants.LabelAppValue && | ||||
| 		object.GetLabels()[constants.LabelWatchKey] == constants.LabelWatchValue && | ||||
| 		len(object.GetLabels()[constants.LabelJenkinsCRKey]) > 0 { | ||||
|  | @ -79,24 +80,24 @@ type jenkinsDecorator struct { | |||
| 	handler handler.EventHandler | ||||
| } | ||||
| 
 | ||||
| func (e *jenkinsDecorator) Create(evt event.CreateEvent, q workqueue.RateLimitingInterface) { | ||||
| func (e *jenkinsDecorator) Create(ctx context.Context, evt event.CreateEvent, q workqueue.RateLimitingInterface) { | ||||
| 	log.Log.WithValues("cr", evt.Object.GetName()).Info(fmt.Sprintf("%T/%s was created", evt.Object, evt.Object.GetName())) | ||||
| 	e.handler.Create(evt, q) | ||||
| 	e.handler.Create(ctx, evt, q) | ||||
| } | ||||
| 
 | ||||
| func (e *jenkinsDecorator) Update(evt event.UpdateEvent, q workqueue.RateLimitingInterface) { | ||||
| func (e *jenkinsDecorator) Update(ctx context.Context, evt event.UpdateEvent, q workqueue.RateLimitingInterface) { | ||||
| 	if !reflect.DeepEqual(evt.ObjectOld.(*v1alpha2.Jenkins).Spec, evt.ObjectNew.(*v1alpha2.Jenkins).Spec) { | ||||
| 		log.Log.WithValues("cr", evt.ObjectNew.GetName()).Info( | ||||
| 			fmt.Sprintf("%T/%s has been updated", evt.ObjectNew, evt.ObjectNew.GetName())) | ||||
| 	} | ||||
| 	e.handler.Update(evt, q) | ||||
| 	e.handler.Update(ctx, evt, q) | ||||
| } | ||||
| 
 | ||||
| func (e *jenkinsDecorator) Delete(evt event.DeleteEvent, q workqueue.RateLimitingInterface) { | ||||
| func (e *jenkinsDecorator) Delete(ctx context.Context, evt event.DeleteEvent, q workqueue.RateLimitingInterface) { | ||||
| 	log.Log.WithValues("cr", evt.Object.GetName()).Info(fmt.Sprintf("%T/%s was deleted", evt.Object, evt.Object.GetName())) | ||||
| 	e.handler.Delete(evt, q) | ||||
| 	e.handler.Delete(ctx, evt, q) | ||||
| } | ||||
| 
 | ||||
| func (e *jenkinsDecorator) Generic(evt event.GenericEvent, q workqueue.RateLimitingInterface) { | ||||
| 	e.handler.Generic(evt, q) | ||||
| func (e *jenkinsDecorator) Generic(ctx context.Context, evt event.GenericEvent, q workqueue.RateLimitingInterface) { | ||||
| 	e.handler.Generic(ctx, evt, q) | ||||
| } | ||||
|  | @ -46,7 +46,6 @@ import ( | |||
| 	"sigs.k8s.io/controller-runtime/pkg/client" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/handler" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/reconcile" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/source" | ||||
| ) | ||||
| 
 | ||||
| type reconcileError struct { | ||||
|  | @ -79,9 +78,22 @@ type JenkinsReconciler struct { | |||
| // SetupWithManager sets up the controller with the Manager.
 | ||||
| func (r *JenkinsReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||||
| 	jenkinsHandler := &enqueueRequestForJenkins{} | ||||
| 	configMapResource := &source.Kind{Type: &corev1.ConfigMap{TypeMeta: metav1.TypeMeta{APIVersion: APIVersion, Kind: ConfigMapKind}}} | ||||
| 	secretResource := &source.Kind{Type: &corev1.Secret{TypeMeta: metav1.TypeMeta{APIVersion: APIVersion, Kind: SecretKind}}} | ||||
| 	decorator := jenkinsDecorator{handler: &handler.EnqueueRequestForObject{}} | ||||
| 	configMapResource := &corev1.Secret{ | ||||
| 		TypeMeta: metav1.TypeMeta{ | ||||
| 			APIVersion: APIVersion, | ||||
| 			Kind:       SecretKind, | ||||
| 		}, | ||||
| 	} | ||||
| 	secretResource := &corev1.Secret{ | ||||
| 		TypeMeta: metav1.TypeMeta{ | ||||
| 			APIVersion: APIVersion, | ||||
| 			Kind:       SecretKind, | ||||
| 		}, | ||||
| 	} | ||||
| 	decorator := jenkinsDecorator{ | ||||
| 		handler: &handler.EnqueueRequestForObject{}, | ||||
| 	} | ||||
| 
 | ||||
| 	return ctrl.NewControllerManagedBy(mgr). | ||||
| 		For(&v1alpha2.Jenkins{}). | ||||
| 		Owns(&corev1.Pod{}). | ||||
|  | @ -89,7 +101,7 @@ func (r *JenkinsReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| 		Owns(&corev1.ConfigMap{}). | ||||
| 		Watches(secretResource, jenkinsHandler). | ||||
| 		Watches(configMapResource, jenkinsHandler). | ||||
| 		Watches(&source.Kind{Type: &v1alpha2.Jenkins{}}, &decorator). | ||||
| 		Watches(&v1alpha2.Jenkins{}, &decorator). | ||||
| 		Complete(r) | ||||
| } | ||||
| 
 | ||||
|  | @ -193,7 +205,7 @@ func (r *JenkinsReconciler) Reconcile(_ context.Context, request ctrl.Request) ( | |||
| 		return reconcile.Result{Requeue: true}, nil | ||||
| 	} | ||||
| 	if result.Requeue && result.RequeueAfter == 0 { | ||||
| 		result.RequeueAfter = time.Duration(rand.Intn(10)) * time.Millisecond | ||||
| 		result.RequeueAfter = time.Duration(rand.Intn(10)) * time.Second | ||||
| 	} | ||||
| 	return result, nil | ||||
| } | ||||
|  | @ -11,6 +11,8 @@ | |||
|   ) | ||||
| , mkGoEnv ? pkgs.mkGoEnv | ||||
| , gomod2nix ? pkgs.gomod2nix | ||||
| , go22 ? pkgs.go_1_22 | ||||
| , golangci-lint ? pkgs.golangci-lint | ||||
| }: | ||||
| 
 | ||||
| let | ||||
|  | @ -18,6 +20,8 @@ let | |||
| in | ||||
| pkgs.mkShell { | ||||
|   packages = [ | ||||
|     go22 | ||||
|     golangci-lint | ||||
|     goEnv | ||||
|     gomod2nix | ||||
|   ]; | ||||
|  |  | |||
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							|  | @ -3,7 +3,7 @@ | |||
| let | ||||
|   buildPackages = [ | ||||
|     hugo_099_pkgs.hugo #hugo pre-v100 | ||||
|     pkgs.nodejs_21 #Node 1.21 | ||||
|     pkgs.nodejs_22 #Node 1.22 | ||||
|     pkgs.nodePackages.autoprefixer | ||||
|     pkgs.nodePackages.postcss | ||||
|     pkgs.nodePackages.postcss-cli | ||||
|  | @ -16,7 +16,7 @@ pkgs.buildNpmPackage { | |||
|   version = "0.0.2"; | ||||
|   npmDepsHash = "sha256-VrHuyqTPUzVJSjah+BWfg7R9yiarJQ2MDvEdqkOWddM="; | ||||
|   nativeBuildInputs = buildPackages; | ||||
|   buildPhase = "${pkgs.nodejs_21}/bin/npm run build"; | ||||
|   buildPhase = "${pkgs.nodejs_22}/bin/npm run build"; | ||||
|   installPhase = "cp -r public $out"; | ||||
|   BASE_URL = "${baseUrl}"; | ||||
| } | ||||
|  |  | |||
|  | @ -3,7 +3,7 @@ | |||
| let | ||||
|   devShellPackages = [ | ||||
|     hugo_099_pkgs.hugo #hugo pre-v100 | ||||
|     pkgs.nodejs_21 #Node 1.21 | ||||
|     pkgs.nodejs_22 #Node 1.22 | ||||
|     pkgs.helm-docs | ||||
|   ]; | ||||
|   baseUrl = ((builtins.fromTOML (builtins.readFile ../website/config.toml)).baseURL); | ||||
|  |  | |||
|  | @ -2,8 +2,9 @@ package client | |||
| 
 | ||||
| import ( | ||||
| 	"bytes" | ||||
| 	"context" | ||||
| 	"fmt" | ||||
| 	"io/ioutil" | ||||
| 	"io" | ||||
| 	"net/http" | ||||
| 	"net/http/cookiejar" | ||||
| 	"strings" | ||||
|  | @ -20,41 +21,41 @@ var ( | |||
| // Jenkins defines Jenkins API.
 | ||||
| type Jenkins interface { | ||||
| 	GenerateToken(userName, tokenName string) (*UserToken, error) | ||||
| 	Info() (*gojenkins.ExecutorResponse, error) | ||||
| 	SafeRestart() error | ||||
| 	CreateNode(name string, numExecutors int, description string, remoteFS string, label string, options ...interface{}) (*gojenkins.Node, error) | ||||
| 	DeleteNode(name string) (bool, error) | ||||
| 	CreateFolder(name string, parents ...string) (*gojenkins.Folder, error) | ||||
| 	CreateJobInFolder(config string, jobName string, parentIDs ...string) (*gojenkins.Job, error) | ||||
| 	CreateJob(config string, options ...interface{}) (*gojenkins.Job, error) | ||||
| 	Info(ctx context.Context) (*gojenkins.ExecutorResponse, error) | ||||
| 	SafeRestart(ctx context.Context) error | ||||
| 	CreateNode(ctx context.Context, name string, numExecutors int, description string, remoteFS string, label string, options ...interface{}) (*gojenkins.Node, error) | ||||
| 	DeleteNode(ctx context.Context, name string) (bool, error) | ||||
| 	CreateFolder(ctx context.Context, name string, parents ...string) (*gojenkins.Folder, error) | ||||
| 	CreateJobInFolder(ctx context.Context, config string, jobName string, parentIDs ...string) (*gojenkins.Job, error) | ||||
| 	CreateJob(ctx context.Context, config string, options ...interface{}) (*gojenkins.Job, error) | ||||
| 	CreateOrUpdateJob(config, jobName string) (*gojenkins.Job, bool, error) | ||||
| 	RenameJob(job string, name string) *gojenkins.Job | ||||
| 	CopyJob(copyFrom string, newName string) (*gojenkins.Job, error) | ||||
| 	DeleteJob(name string) (bool, error) | ||||
| 	BuildJob(name string, options ...interface{}) (int64, error) | ||||
| 	GetNode(name string) (*gojenkins.Node, error) | ||||
| 	GetLabel(name string) (*gojenkins.Label, error) | ||||
| 	RenameJob(ctx context.Context, job string, name string) *gojenkins.Job | ||||
| 	CopyJob(ctx context.Context, copyFrom string, newName string) (*gojenkins.Job, error) | ||||
| 	CreateView(ctx context.Context, name string, viewType string) (*gojenkins.View, error) | ||||
| 	DeleteJob(ctx context.Context, name string) (bool, error) | ||||
| 	BuildJob(ctx context.Context, name string, options map[string]string) (int64, error) | ||||
| 	GetNode(ctx context.Context, name string) (*gojenkins.Node, error) | ||||
| 	GetLabel(ctx context.Context, name string) (*gojenkins.Label, error) | ||||
| 	GetBuild(jobName string, number int64) (*gojenkins.Build, error) | ||||
| 	GetJob(id string, parentIDs ...string) (*gojenkins.Job, error) | ||||
| 	GetSubJob(parentID string, childID string) (*gojenkins.Job, error) | ||||
| 	GetFolder(id string, parents ...string) (*gojenkins.Folder, error) | ||||
| 	GetAllNodes() ([]*gojenkins.Node, error) | ||||
| 	GetAllBuildIds(job string) ([]gojenkins.JobBuild, error) | ||||
| 	GetAllJobNames() ([]gojenkins.InnerJob, error) | ||||
| 	GetAllJobs() ([]*gojenkins.Job, error) | ||||
| 	GetQueue() (*gojenkins.Queue, error) | ||||
| 	GetJob(ctx context.Context, id string, parentIDs ...string) (*gojenkins.Job, error) | ||||
| 	GetSubJob(ctx context.Context, parentID string, childID string) (*gojenkins.Job, error) | ||||
| 	GetFolder(ctx context.Context, id string, parents ...string) (*gojenkins.Folder, error) | ||||
| 	GetAllNodes(ctx context.Context) ([]*gojenkins.Node, error) | ||||
| 	GetAllBuildIds(ctx context.Context, job string) ([]gojenkins.JobBuild, error) | ||||
| 	GetAllJobNames(context.Context) ([]gojenkins.InnerJob, error) | ||||
| 	GetAllJobs(context.Context) ([]*gojenkins.Job, error) | ||||
| 	GetQueue(context.Context) (*gojenkins.Queue, error) | ||||
| 	GetQueueUrl() string | ||||
| 	GetQueueItem(id int64) (*gojenkins.Task, error) | ||||
| 	GetArtifactData(id string) (*gojenkins.FingerPrintResponse, error) | ||||
| 	GetQueueItem(ctx context.Context, id int64) (*gojenkins.Task, error) | ||||
| 	GetArtifactData(ctx context.Context, id string) (*gojenkins.FingerPrintResponse, error) | ||||
| 	GetPlugins(depth int) (*gojenkins.Plugins, error) | ||||
| 	UninstallPlugin(name string) error | ||||
| 	HasPlugin(name string) (*gojenkins.Plugin, error) | ||||
| 	InstallPlugin(name string, version string) error | ||||
| 	ValidateFingerPrint(id string) (bool, error) | ||||
| 	GetView(name string) (*gojenkins.View, error) | ||||
| 	GetAllViews() ([]*gojenkins.View, error) | ||||
| 	CreateView(name string, viewType string) (*gojenkins.View, error) | ||||
| 	Poll() (int, error) | ||||
| 	UninstallPlugin(ctx context.Context, name string) error | ||||
| 	HasPlugin(ctx context.Context, name string) (*gojenkins.Plugin, error) | ||||
| 	InstallPlugin(ctx context.Context, name string, version string) error | ||||
| 	ValidateFingerPrint(ctx context.Context, id string) (bool, error) | ||||
| 	GetView(ctx context.Context, name string) (*gojenkins.View, error) | ||||
| 	GetAllViews(context.Context) ([]*gojenkins.View, error) | ||||
| 	Poll(ctx context.Context) (int, error) | ||||
| 	ExecuteScript(groovyScript string) (logs string, err error) | ||||
| 	GetNodeSecret(name string) (string, error) | ||||
| } | ||||
|  | @ -90,16 +91,15 @@ func (t *setBearerToken) RoundTrip(r *http.Request) (*http.Response, error) { | |||
| // CreateOrUpdateJob creates or updates a job from config.
 | ||||
| func (jenkins *jenkins) CreateOrUpdateJob(config, jobName string) (job *gojenkins.Job, created bool, err error) { | ||||
| 	// create or update
 | ||||
| 	job, err = jenkins.GetJob(jobName) | ||||
| 	job, err = jenkins.GetJob(context.TODO(), jobName) | ||||
| 	if isNotFoundError(err) { | ||||
| 		job, err = jenkins.CreateJob(config, jobName) | ||||
| 		created = true | ||||
| 		job, err = jenkins.CreateJob(context.TODO(), config, jobName) | ||||
| 		return job, true, errors.WithStack(err) | ||||
| 	} else if err != nil { | ||||
| 		return job, false, errors.WithStack(err) | ||||
| 	} | ||||
| 
 | ||||
| 	err = job.UpdateConfig(config) | ||||
| 	err = job.UpdateConfig(context.TODO(), config) | ||||
| 	return job, false, errors.WithStack(err) | ||||
| } | ||||
| 
 | ||||
|  | @ -144,9 +144,10 @@ func NewBearerTokenAuthorization(url, token string) (Jenkins, error) { | |||
| } | ||||
| 
 | ||||
| func newClient(url, userName, passwordOrToken string) (Jenkins, error) { | ||||
| 	if strings.HasSuffix(url, "/") { | ||||
| 		url = url[:len(url)-1] | ||||
| 	} | ||||
| 	// if strings.HasSuffix(url, "/") {
 | ||||
| 	// url = url[:len(url)-1]
 | ||||
| 	url = strings.TrimSuffix(url, "/") | ||||
| 	// }
 | ||||
| 
 | ||||
| 	jenkinsClient := &jenkins{} | ||||
| 	jenkinsClient.Server = url | ||||
|  | @ -174,11 +175,11 @@ func newClient(url, userName, passwordOrToken string) (Jenkins, error) { | |||
| 		Client:    httpClient, | ||||
| 		BasicAuth: basicAuth, | ||||
| 	} | ||||
| 	if _, err := jenkinsClient.Init(); err != nil { | ||||
| 	if _, err := jenkinsClient.Init(context.TODO()); err != nil { | ||||
| 		return nil, errors.Wrap(err, "couldn't init Jenkins API client") | ||||
| 	} | ||||
| 
 | ||||
| 	status, err := jenkinsClient.Poll() | ||||
| 	status, err := jenkinsClient.Poll(context.TODO()) | ||||
| 	if err != nil { | ||||
| 		return nil, errors.Wrap(err, "couldn't poll data from Jenkins API") | ||||
| 	} | ||||
|  | @ -213,9 +214,13 @@ func (jenkins *jenkins) GetNodeSecret(name string) (string, error) { | |||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
| 	defer resp.Body.Close() | ||||
| 	defer func() { | ||||
| 		if cerr := resp.Body.Close(); cerr != nil && err == nil { | ||||
| 			err = cerr | ||||
| 		} | ||||
| 	}() | ||||
| 
 | ||||
| 	body, err := ioutil.ReadAll(resp.Body) | ||||
| 	body, err := io.ReadAll(resp.Body) | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | @ -231,7 +236,7 @@ func (jenkins *jenkins) GetNodeSecret(name string) (string, error) { | |||
| // You can supply depth parameter, to limit how much data is returned.
 | ||||
| func (jenkins *jenkins) GetPlugins(depth int) (*gojenkins.Plugins, error) { | ||||
| 	p := gojenkins.Plugins{Jenkins: &jenkins.Jenkins, Raw: new(gojenkins.PluginResponse), Base: "/pluginManager", Depth: depth} | ||||
| 	statusCode, err := p.Poll() | ||||
| 	statusCode, err := p.Poll(context.TODO()) | ||||
| 	if err != nil { | ||||
| 		return nil, err | ||||
| 	} | ||||
|  |  | |||
|  | @ -1,13 +1,14 @@ | |||
| package client | ||||
| 
 | ||||
| import ( | ||||
| 	"context" | ||||
| 	"net/url" | ||||
| 
 | ||||
| 	"github.com/bndr/gojenkins" | ||||
| ) | ||||
| 
 | ||||
| func (jenkins *jenkins) GetBuild(jobName string, number int64) (*gojenkins.Build, error) { | ||||
| 	job, err := jenkins.GetJob(jobName) | ||||
| 	job, err := jenkins.GetJob(context.TODO(), jobName) | ||||
| 	if err != nil { | ||||
| 		return nil, err | ||||
| 	} | ||||
|  | @ -21,7 +22,7 @@ func (jenkins *jenkins) GetBuild(jobName string, number int64) (*gojenkins.Build | |||
| 	job.Raw.URL = jobURL.RequestURI() | ||||
| 	// workaround end
 | ||||
| 
 | ||||
| 	build, err := job.GetBuild(number) | ||||
| 	build, err := job.GetBuild(context.TODO(), number) | ||||
| 
 | ||||
| 	if err != nil { | ||||
| 		return nil, err | ||||
|  |  | |||
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							|  | @ -2,6 +2,7 @@ package client | |||
| 
 | ||||
| import ( | ||||
| 	"bytes" | ||||
| 	"context" | ||||
| 	"fmt" | ||||
| 	"net/http" | ||||
| 	"net/url" | ||||
|  | @ -9,6 +10,7 @@ import ( | |||
| 	"time" | ||||
| 
 | ||||
| 	"github.com/bndr/gojenkins" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/log" | ||||
| 	"github.com/pkg/errors" | ||||
| ) | ||||
| 
 | ||||
|  | @ -38,18 +40,19 @@ func (jenkins *jenkins) executeScript(script string, verifier string) (string, e | |||
| 	data.Set("script", fullScript) | ||||
| 
 | ||||
| 	ar := gojenkins.NewAPIRequest("POST", "/scriptText", bytes.NewBufferString(data.Encode())) | ||||
| 	if err := jenkins.Requester.SetCrumb(ar); err != nil { | ||||
| 	if err := jenkins.Requester.SetCrumb(context.TODO(), ar); err != nil { | ||||
| 		return output, err | ||||
| 	} | ||||
| 	ar.SetHeader("Content-Type", "application/x-www-form-urlencoded") | ||||
| 	ar.Suffix = "" | ||||
| 
 | ||||
| 	r, err := jenkins.Requester.Do(ar, &output, nil) | ||||
| 	r, err := jenkins.Requester.Do(context.TODO(), ar, &output, nil) | ||||
| 	if err != nil { | ||||
| 		return "", errors.Wrapf(err, "couldn't execute groovy script, logs '%s'", output) | ||||
| 	} | ||||
| 	defer r.Body.Close() | ||||
| 
 | ||||
| 	if err := r.Body.Close(); err != nil { | ||||
| 		log.Log.Error(err, "failed to close jenkins.executeScript.Requester") | ||||
| 	} | ||||
| 	if r.StatusCode != http.StatusOK { | ||||
| 		return output, errors.Errorf("invalid status code '%d', logs '%s'", r.StatusCode, output) | ||||
| 	} | ||||
|  |  | |||
|  | @ -35,7 +35,6 @@ func Test_ExecuteScript(t *testing.T) { | |||
| 			Client:    client, | ||||
| 			BasicAuth: &gojenkins.BasicAuth{Username: "unused", Password: "unused"}, | ||||
| 		} | ||||
| 
 | ||||
| 		logs, err := jenkinsClient.executeScript(script, verifier) | ||||
| 		assert.NoError(t, err, logs) | ||||
| 	}) | ||||
|  |  | |||
|  | @ -1,9 +1,11 @@ | |||
| package client | ||||
| 
 | ||||
| import ( | ||||
| 	"context" | ||||
| 	"fmt" | ||||
| 	"net/http" | ||||
| 
 | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/log" | ||||
| 	"github.com/pkg/errors" | ||||
| ) | ||||
| 
 | ||||
|  | @ -34,12 +36,18 @@ func (jenkins *jenkins) GenerateToken(userName, tokenName string) (*UserToken, e | |||
| 		base: fmt.Sprintf("/user/%s/descriptorByName/jenkins.security.ApiTokenProperty/generateNewToken", userName)} | ||||
| 	endpoint := token.base | ||||
| 	data := map[string]string{"newTokenName": tokenName} | ||||
| 	r, err := jenkins.Requester.Post(endpoint, nil, token.raw, data) | ||||
| 	r, err := jenkins.Requester.Post(context.TODO(), endpoint, nil, token.raw, data) | ||||
| 	if err != nil { | ||||
| 		return nil, errors.Wrap(err, "couldn't generate API token") | ||||
| 	} | ||||
| 	defer r.Body.Close() | ||||
| 
 | ||||
| 	defer func() { | ||||
| 		if err := r.Body.Close(); err != nil { | ||||
| 			log.Log.Error(err, "failed to close http response body") | ||||
| 		} | ||||
| 	}() | ||||
| 	if err := r.Body.Close(); err != nil { | ||||
| 		log.Log.Error(err, "failed to close jenkins.GenerateToken.Requester") | ||||
| 	} | ||||
| 	if r.StatusCode == http.StatusOK { | ||||
| 		if token.raw.Status == "ok" { | ||||
| 			return token, nil | ||||
|  |  | |||
|  | @ -149,7 +149,7 @@ func (bar *BackupAndRestore) Restore(jenkinsClient jenkinsclient.Jenkins) error | |||
| 
 | ||||
| 		backupNumberString := strings.TrimSuffix(backupNumberRaw.String(), "\n") | ||||
| 		if backupNumberString == noBackup { | ||||
| 			bar.logger.V(log.VDebug).Info("Skipping restore backup, get latest action returned -1") | ||||
| 			bar.logger.V(log.VDebug).Info("Skipping restore backup, get latest action returned -1 (no backups found)") | ||||
| 			jenkins.Status.LastBackup = 0 | ||||
| 			jenkins.Status.PendingBackup = 1 | ||||
| 			return bar.Client.Status().Update(context.TODO(), jenkins) | ||||
|  | @ -209,7 +209,7 @@ func (bar *BackupAndRestore) Restore(jenkinsClient jenkinsclient.Jenkins) error | |||
| func (bar *BackupAndRestore) Backup(setBackupDoneBeforePodDeletion bool) error { | ||||
| 	jenkins := bar.Configuration.Jenkins | ||||
| 	if len(jenkins.Spec.Backup.ContainerName) == 0 || jenkins.Spec.Backup.Action.Exec == nil { | ||||
| 		bar.logger.V(log.VDebug).Info("Skipping restore backup, backup restore not configured") | ||||
| 		bar.logger.V(log.VDebug).Info("Skipping backup, backup creation not configured") | ||||
| 		return nil | ||||
| 	} | ||||
| 	if jenkins.Status.PendingBackup == jenkins.Status.LastBackup { | ||||
|  |  | |||
|  | @ -445,7 +445,6 @@ func Test_compareEnv(t *testing.T) { | |||
| 		var actual []corev1.EnvVar | ||||
| 
 | ||||
| 		got := compareEnv(expected, actual) | ||||
| 
 | ||||
| 		assert.True(t, got) | ||||
| 	}) | ||||
| 	t.Run("same", func(t *testing.T) { | ||||
|  |  | |||
|  | @ -121,6 +121,9 @@ func (r *JenkinsBaseConfigurationReconciler) Reconcile() (reconcile.Result, jenk | |||
| 	} | ||||
| 
 | ||||
| 	result, err = r.ensureBaseConfiguration(jenkinsClient) | ||||
| 	if err != nil { | ||||
| 		return reconcile.Result{}, nil, err | ||||
| 	} | ||||
| 
 | ||||
| 	return result, jenkinsClient, err | ||||
| } | ||||
|  |  | |||
|  | @ -8,7 +8,7 @@ import ( | |||
| 	appsv1 "k8s.io/api/apps/v1" | ||||
| 	corev1 "k8s.io/api/core/v1" | ||||
| 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||||
| 	"k8s.io/utils/pointer" | ||||
| 	"k8s.io/utils/ptr" | ||||
| ) | ||||
| 
 | ||||
| // NewJenkinsMasterPod builds Jenkins Master Kubernetes Pod resource.
 | ||||
|  | @ -24,7 +24,7 @@ func NewJenkinsDeployment(objectMeta metav1.ObjectMeta, jenkins *v1alpha2.Jenkin | |||
| 			Labels:    objectMeta.Labels, | ||||
| 		}, | ||||
| 		Spec: appsv1.DeploymentSpec{ | ||||
| 			Replicas: pointer.Int32Ptr(1), | ||||
| 			Replicas: ptr.To(int32(1)), | ||||
| 			Strategy: appsv1.DeploymentStrategy{Type: appsv1.RollingUpdateDeploymentStrategyType}, | ||||
| 			Template: corev1.PodTemplateSpec{ | ||||
| 				ObjectMeta: objectMeta, | ||||
|  |  | |||
|  | @ -7,7 +7,7 @@ import ( | |||
| 
 | ||||
| func NewProbe(uri string, port string, scheme corev1.URIScheme, initialDelaySeconds, timeoutSeconds, failureThreshold int32) *corev1.Probe { | ||||
| 	return &corev1.Probe{ | ||||
| 		Handler: corev1.Handler{ | ||||
| 		ProbeHandler: corev1.ProbeHandler{ | ||||
| 			HTTPGet: &corev1.HTTPGetAction{ | ||||
| 				Path:   uri, | ||||
| 				Port:   intstr.FromString(port), | ||||
|  |  | |||
|  | @ -16,5 +16,5 @@ func randomString(n int) string { | |||
| } | ||||
| 
 | ||||
| func init() { | ||||
| 	rand.Seed(time.Now().UnixNano()) | ||||
| 	rand.New(rand.NewSource(time.Now().UnixNano())) | ||||
| } | ||||
|  |  | |||
|  | @ -16,12 +16,12 @@ var jenkins = v1alpha2.Jenkins{ | |||
| 				{ | ||||
| 					Env: []corev1.EnvVar{}, | ||||
| 					ReadinessProbe: &corev1.Probe{ | ||||
| 						Handler: corev1.Handler{ | ||||
| 						ProbeHandler: corev1.ProbeHandler{ | ||||
| 							HTTPGet: &corev1.HTTPGetAction{}, | ||||
| 						}, | ||||
| 					}, | ||||
| 					LivenessProbe: &corev1.Probe{ | ||||
| 						Handler: corev1.Handler{ | ||||
| 						ProbeHandler: corev1.ProbeHandler{ | ||||
| 							HTTPGet: &corev1.HTTPGetAction{}, | ||||
| 						}, | ||||
| 					}, | ||||
|  | @ -118,7 +118,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].ReadinessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/login", | ||||
| 					}, | ||||
|  | @ -127,7 +127,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].LivenessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/login", | ||||
| 					}, | ||||
|  | @ -148,7 +148,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].ReadinessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/login", | ||||
| 					}, | ||||
|  | @ -157,7 +157,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].LivenessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/login", | ||||
| 					}, | ||||
|  | @ -178,7 +178,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].ReadinessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/jenkins/login", | ||||
| 					}, | ||||
|  | @ -187,7 +187,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].LivenessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/jenkins/login", | ||||
| 					}, | ||||
|  | @ -205,7 +205,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].ReadinessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/jenkins/login", | ||||
| 					}, | ||||
|  | @ -214,7 +214,7 @@ func TestSetLivenessAndReadinessPath(t *testing.T) { | |||
| 
 | ||||
| 		jenkins.Spec.Master.Containers[0].LivenessProbe = | ||||
| 			&corev1.Probe{ | ||||
| 				Handler: corev1.Handler{ | ||||
| 				ProbeHandler: corev1.ProbeHandler{ | ||||
| 					HTTPGet: &corev1.HTTPGetAction{ | ||||
| 						Path: "/jenkins/login", | ||||
| 					}, | ||||
|  |  | |||
|  | @ -11,7 +11,7 @@ import ( | |||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/constants" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/plugins" | ||||
| 
 | ||||
| 	docker "github.com/docker/distribution/reference" | ||||
| 	docker "github.com/distribution/reference" | ||||
| 	stackerr "github.com/pkg/errors" | ||||
| 	corev1 "k8s.io/api/core/v1" | ||||
| 	apierrors "k8s.io/apimachinery/pkg/api/errors" | ||||
|  |  | |||
|  | @ -155,7 +155,7 @@ func (c *Configuration) Exec(podName, containerName string, command []string) (s | |||
| 		return stdout, stderr, stackerr.Wrap(err, "pod exec error while creating Executor") | ||||
| 	} | ||||
| 
 | ||||
| 	err = exec.Stream(remotecommand.StreamOptions{ | ||||
| 	err = exec.StreamWithContext(context.TODO(), remotecommand.StreamOptions{ | ||||
| 		Stdin:  nil, | ||||
| 		Stdout: &stdout, | ||||
| 		Stderr: &stderr, | ||||
|  | @ -165,7 +165,7 @@ func (c *Configuration) Exec(podName, containerName string, command []string) (s | |||
| 		return stdout, stderr, stackerr.Wrapf(err, "pod exec error operation on stream: stdout '%s' stderr '%s'", stdout.String(), stderr.String()) | ||||
| 	} | ||||
| 
 | ||||
| 	return | ||||
| 	return stdout, stderr, nil | ||||
| } | ||||
| 
 | ||||
| // GetJenkinsMasterContainer returns the Jenkins master container from the CR.
 | ||||
|  |  | |||
|  | @ -60,6 +60,14 @@ func (r *reconcileUserConfiguration) ReconcileOthers() (reconcile.Result, error) | |||
| 		return reconcile.Result{}, err | ||||
| 	} | ||||
| 
 | ||||
| 	if err := backupAndRestore.Backup(false); err != nil { | ||||
| 		return reconcile.Result{}, err | ||||
| 	} | ||||
| 
 | ||||
| 	if err := backupAndRestore.EnsureBackupTrigger(); err != nil { | ||||
| 		return reconcile.Result{}, err | ||||
| 	} | ||||
| 
 | ||||
| 	result, err := r.ensureSeedJobs() | ||||
| 	if err != nil { | ||||
| 		return reconcile.Result{}, err | ||||
|  | @ -68,13 +76,6 @@ func (r *reconcileUserConfiguration) ReconcileOthers() (reconcile.Result, error) | |||
| 		return result, nil | ||||
| 	} | ||||
| 
 | ||||
| 	if err := backupAndRestore.Backup(false); err != nil { | ||||
| 		return reconcile.Result{}, err | ||||
| 	} | ||||
| 	if err := backupAndRestore.EnsureBackupTrigger(); err != nil { | ||||
| 		return reconcile.Result{}, err | ||||
| 	} | ||||
| 
 | ||||
| 	return reconcile.Result{}, nil | ||||
| } | ||||
| 
 | ||||
|  |  | |||
|  | @ -230,6 +230,7 @@ func (s *seedJobs) EnsureSeedJobs(jenkins *v1alpha2.Jenkins) (done bool, err err | |||
| 		}) | ||||
| 
 | ||||
| 		if err != nil && !apierrors.IsNotFound(err) { | ||||
| 
 | ||||
| 			return false, stackerr.WithStack(err) | ||||
| 		} | ||||
| 	} | ||||
|  | @ -248,6 +249,7 @@ func (s *seedJobs) EnsureSeedJobs(jenkins *v1alpha2.Jenkins) (done bool, err err | |||
| 
 | ||||
| 	seedJobIDs := s.getAllSeedJobIDs(*jenkins) | ||||
| 	if !reflect.DeepEqual(seedJobIDs, jenkins.Status.CreatedSeedJobs) { | ||||
| 		// @ansh-devs fixed : calls to Update and Patch will not alter its status.
 | ||||
| 		jenkins.Status.CreatedSeedJobs = seedJobIDs | ||||
| 		return false, stackerr.WithStack(s.Client.Status().Update(context.TODO(), jenkins)) | ||||
| 	} | ||||
|  | @ -315,6 +317,7 @@ func (s *seedJobs) createJobs(jenkins *v1alpha2.Jenkins) (requeue bool, err erro | |||
| // Operator will able to watch any changes made to them
 | ||||
| func (s *seedJobs) ensureLabelsForSecrets(jenkins v1alpha2.Jenkins) error { | ||||
| 	for _, seedJob := range jenkins.Spec.SeedJobs { | ||||
| 
 | ||||
| 		if seedJob.JenkinsCredentialType == v1alpha2.BasicSSHCredentialType || seedJob.JenkinsCredentialType == v1alpha2.UsernamePasswordCredentialType { | ||||
| 			requiredLabels := resources.BuildLabelsForWatchedResources(jenkins) | ||||
| 			requiredLabels[JenkinsCredentialTypeLabelName] = string(seedJob.JenkinsCredentialType) | ||||
|  | @ -356,7 +359,7 @@ func (s *seedJobs) credentialValue(namespace string, seedJob v1alpha2.SeedJob) ( | |||
| } | ||||
| 
 | ||||
| func (s *seedJobs) getAllSeedJobIDs(jenkins v1alpha2.Jenkins) []string { | ||||
| 	var ids []string | ||||
| 	ids := make([]string, 0, len(jenkins.Spec.SeedJobs)) | ||||
| 	for _, seedJob := range jenkins.Spec.SeedJobs { | ||||
| 		ids = append(ids, seedJob.ID) | ||||
| 	} | ||||
|  | @ -381,11 +384,11 @@ func (s *seedJobs) isRecreatePodNeeded(jenkins v1alpha2.Jenkins) bool { | |||
| 
 | ||||
| // createAgent deploys Jenkins agent to Kubernetes cluster
 | ||||
| func (s *seedJobs) createAgent(jenkinsClient jenkinsclient.Jenkins, k8sClient client.Client, jenkinsManifest *v1alpha2.Jenkins, namespace string, agentName string) error { | ||||
| 	_, err := jenkinsClient.GetNode(agentName) | ||||
| 	_, err := jenkinsClient.GetNode(context.TODO(), agentName) | ||||
| 
 | ||||
| 	// Create node if not exists
 | ||||
| 	if err != nil && err.Error() == "No node found" { | ||||
| 		_, err = jenkinsClient.CreateNode(agentName, 5, "The jenkins-operator generated agent", "/home/jenkins", agentName) | ||||
| 		_, err = jenkinsClient.CreateNode(context.TODO(), agentName, 5, "The jenkins-operator generated agent", "/home/jenkins", agentName) | ||||
| 		if err != nil { | ||||
| 			return stackerr.WithStack(err) | ||||
| 		} | ||||
|  |  | |||
|  | @ -97,8 +97,8 @@ func TestEnsureSeedJobs(t *testing.T) { | |||
| 		seedJobCreatingScript, err := seedJobCreatingGroovyScript(jenkins.Spec.SeedJobs[0]) | ||||
| 		assert.NoError(t, err) | ||||
| 
 | ||||
| 		jenkinsClient.EXPECT().GetNode(AgentName).Return(nil, nil).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().CreateNode(AgentName, 1, "The jenkins-operator generated agent", "/home/jenkins", AgentName).Return(testNode, nil).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().GetNode(context.TODO(), AgentName).Return(nil, nil).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().CreateNode(context.TODO(), AgentName, 1, "The jenkins-operator generated agent", "/home/jenkins", AgentName).Return(testNode, nil).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().GetNodeSecret(AgentName).Return(agentSecret, nil).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().ExecuteScript(seedJobCreatingScript).AnyTimes() | ||||
| 
 | ||||
|  | @ -128,7 +128,10 @@ func TestEnsureSeedJobs(t *testing.T) { | |||
| 		jenkins.Spec.SeedJobs = []v1alpha2.SeedJob{} | ||||
| 
 | ||||
| 		jenkinsClient := jenkinsclient.NewMockJenkins(ctrl) | ||||
| 		fakeClient := fake.NewClientBuilder().Build() | ||||
| 		fakeClient := fake.NewClientBuilder(). | ||||
| 			WithRuntimeObjects(jenkins). | ||||
| 			WithStatusSubresource(jenkins). | ||||
| 			Build() | ||||
| 		err := v1alpha2.SchemeBuilder.AddToScheme(scheme.Scheme) | ||||
| 		assert.NoError(t, err) | ||||
| 
 | ||||
|  | @ -139,8 +142,8 @@ func TestEnsureSeedJobs(t *testing.T) { | |||
| 			Jenkins:       jenkins, | ||||
| 		} | ||||
| 
 | ||||
| 		jenkinsClient.EXPECT().GetNode(AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().CreateNode(AgentName, 1, "The jenkins-operator generated agent", "/home/jenkins", AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().GetNode(ctx, AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().CreateNode(ctx, AgentName, 1, "The jenkins-operator generated agent", "/home/jenkins", AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().GetNodeSecret(AgentName).Return(agentSecret, nil).AnyTimes() | ||||
| 
 | ||||
| 		seedJobsClient := New(jenkinsClient, config) | ||||
|  | @ -155,13 +158,14 @@ func TestEnsureSeedJobs(t *testing.T) { | |||
| 
 | ||||
| 		// when
 | ||||
| 		_, err = seedJobsClient.EnsureSeedJobs(jenkins) | ||||
| 
 | ||||
| 		// then
 | ||||
| 		assert.NoError(t, err) | ||||
| 
 | ||||
| 		var deployment appsv1.Deployment | ||||
| 		err = fakeClient.Get(ctx, types.NamespacedName{Namespace: jenkins.Namespace, Name: agentDeploymentName(*jenkins, AgentName)}, &deployment) | ||||
| 
 | ||||
| 		err = fakeClient.Get(ctx, types.NamespacedName{ | ||||
| 			Namespace: jenkins.Namespace, | ||||
| 			Name:      agentDeploymentName(*jenkins, AgentName), | ||||
| 		}, &deployment) | ||||
| 		assert.True(t, errors.IsNotFound(err), "Agent deployment hasn't been deleted") | ||||
| 	}) | ||||
| } | ||||
|  | @ -180,8 +184,8 @@ func TestCreateAgent(t *testing.T) { | |||
| 		err := v1alpha2.SchemeBuilder.AddToScheme(scheme.Scheme) | ||||
| 		assert.NoError(t, err) | ||||
| 
 | ||||
| 		jenkinsClient.EXPECT().GetNode(AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().CreateNode(AgentName, 1, "The jenkins-operator generated agent", "/home/jenkins", AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().GetNode(context.TODO(), AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().CreateNode(context.TODO(), AgentName, 1, "The jenkins-operator generated agent", "/home/jenkins", AgentName).AnyTimes() | ||||
| 		jenkinsClient.EXPECT().GetNodeSecret(AgentName).Return(agentSecret, nil).AnyTimes() | ||||
| 
 | ||||
| 		config := configuration.Configuration{ | ||||
|  |  | |||
|  | @ -16,7 +16,7 @@ import ( | |||
| 
 | ||||
| // ValidateSeedJobs verify seed jobs configuration
 | ||||
| func (s *seedJobs) ValidateSeedJobs(jenkins v1alpha2.Jenkins) ([]string, error) { | ||||
| 	var messages []string | ||||
| 	messages := []string{} | ||||
| 
 | ||||
| 	if msg := s.validateIfIDIsUnique(jenkins.Spec.SeedJobs); len(msg) > 0 { | ||||
| 		messages = append(messages, msg...) | ||||
|  | @ -88,24 +88,28 @@ func (s *seedJobs) ValidateSeedJobs(jenkins v1alpha2.Jenkins) ([]string, error) | |||
| 			} | ||||
| 		} | ||||
| 
 | ||||
| 		if seedJob.GitHubPushTrigger { | ||||
| 			if msg := s.validateGitHubPushTrigger(jenkins); len(msg) > 0 { | ||||
| 				for _, m := range msg { | ||||
| 					messages = append(messages, fmt.Sprintf("seedJob `%s` %s", seedJob.ID, m)) | ||||
| 				} | ||||
| 			} | ||||
| 		} | ||||
| 		s.setSeedJobPushTriggers(seedJob, &messages, jenkins) | ||||
| 	} | ||||
| 	return messages, nil | ||||
| } | ||||
| 
 | ||||
| 		if seedJob.BitbucketPushTrigger { | ||||
| 			if msg := s.validateBitbucketPushTrigger(jenkins); len(msg) > 0 { | ||||
| 				for _, m := range msg { | ||||
| 					messages = append(messages, fmt.Sprintf("seedJob `%s` %s", seedJob.ID, m)) | ||||
| 				} | ||||
| func (s *seedJobs) setSeedJobPushTriggers(seedJob v1alpha2.SeedJob, messages *[]string, jenkins v1alpha2.Jenkins) { | ||||
| 	if seedJob.GitHubPushTrigger { | ||||
| 		if msg := s.validateGitHubPushTrigger(jenkins); len(msg) > 0 { | ||||
| 			for _, m := range msg { | ||||
| 				*messages = append(*messages, fmt.Sprintf("seedJob `%s` %s", seedJob.ID, m)) | ||||
| 			} | ||||
| 		} | ||||
| 	} | ||||
| 
 | ||||
| 	if seedJob.BitbucketPushTrigger { | ||||
| 		if msg := s.validateBitbucketPushTrigger(jenkins); len(msg) > 0 { | ||||
| 			for _, m := range msg { | ||||
| 				*messages = append(*messages, fmt.Sprintf("seedJob `%s` %s", seedJob.ID, m)) | ||||
| 			} | ||||
| 		} | ||||
| 	} | ||||
| 
 | ||||
| 	return messages, nil | ||||
| } | ||||
| 
 | ||||
| func (s *seedJobs) validateGitHubPushTrigger(jenkins v1alpha2.Jenkins) []string { | ||||
|  | @ -125,6 +129,7 @@ func (s *seedJobs) validateBitbucketPushTrigger(jenkins v1alpha2.Jenkins) []stri | |||
| } | ||||
| 
 | ||||
| func checkPluginExists(jenkins v1alpha2.Jenkins, name string) error { | ||||
| 
 | ||||
| 	exists := false | ||||
| 	for _, plugin := range jenkins.Spec.Master.BasePlugins { | ||||
| 		if plugin.Name == name { | ||||
|  |  | |||
|  | @ -107,7 +107,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| 	t.Run("Invalid without id", func(t *testing.T) { | ||||
| 		jenkins := v1alpha2.Jenkins{ | ||||
|  | @ -178,7 +178,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| 	t.Run("Invalid ed25519 private key in secret", func(t *testing.T) { | ||||
| 		jenkins := v1alpha2.Jenkins{ | ||||
|  | @ -261,7 +261,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| 	t.Run("Invalid RSA private key in secret", func(t *testing.T) { | ||||
| 		jenkins := v1alpha2.Jenkins{ | ||||
|  | @ -508,7 +508,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| 	t.Run("Invalid with empty username", func(t *testing.T) { | ||||
| 		jenkins := v1alpha2.Jenkins{ | ||||
|  | @ -715,7 +715,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| 	t.Run("Invalid with empty app id", func(t *testing.T) { | ||||
| 		jenkins := v1alpha2.Jenkins{ | ||||
|  | @ -914,7 +914,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| 	t.Run("Invalid with set githubPushTrigger and not installed github plugin", func(t *testing.T) { | ||||
| 		jenkins := v1alpha2.Jenkins{ | ||||
|  | @ -984,7 +984,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| 	t.Run("Invalid with set bitbucketPushTrigger and not installed bitbucket plugin", func(t *testing.T) { | ||||
| 		jenkins := v1alpha2.Jenkins{ | ||||
|  | @ -1054,7 +1054,7 @@ func TestValidateSeedJobs(t *testing.T) { | |||
| 		result, err := seedJobs.ValidateSeedJobs(jenkins) | ||||
| 
 | ||||
| 		assert.NoError(t, err) | ||||
| 		assert.Nil(t, result) | ||||
| 		assert.Empty(t, result) | ||||
| 	}) | ||||
| } | ||||
| 
 | ||||
|  |  | |||
|  | @ -8,7 +8,7 @@ const ( | |||
| 	// SeedJobSuffix is a suffix added for all seed jobs
 | ||||
| 	SeedJobSuffix = "job-dsl-seed" | ||||
| 	// DefaultJenkinsMasterImage is the default Jenkins master docker image
 | ||||
| 	DefaultJenkinsMasterImage = "jenkins/jenkins:2.462.3-lts" | ||||
| 	DefaultJenkinsMasterImage = "jenkins/jenkins:2.479.2-lts" | ||||
| 	// DefaultHTTPPortInt32 is the default Jenkins HTTP port
 | ||||
| 	DefaultHTTPPortInt32 = int32(8080) | ||||
| 	// DefaultSlavePortInt32 is the default Jenkins port for slaves
 | ||||
|  |  | |||
|  | @ -59,7 +59,7 @@ func (g *Groovy) EnsureSingle(source, name, hash, groovyScript string) (requeue | |||
| 		return true, err | ||||
| 	} | ||||
| 
 | ||||
| 	var appliedGroovyScripts []v1alpha2.AppliedGroovyScript | ||||
| 	appliedGroovyScripts := []v1alpha2.AppliedGroovyScript{} | ||||
| 
 | ||||
| 	for _, ags := range g.jenkins.Status.AppliedGroovyScripts { | ||||
| 		if g.configurationType == ags.ConfigurationType && ags.Source == source && ags.Name == name { | ||||
|  | @ -114,7 +114,10 @@ func (g *Groovy) WaitForSecretSynchronization(secretsPath string) (requeue bool, | |||
| func (g *Groovy) Ensure(filter func(name string) bool, updateGroovyScript func(groovyScript string) string) (requeue bool, err error) { | ||||
| 	secret := &corev1.Secret{} | ||||
| 	if len(g.customization.Secret.Name) > 0 { | ||||
| 		err := g.k8sClient.Get(context.TODO(), types.NamespacedName{Name: g.customization.Secret.Name, Namespace: g.jenkins.ObjectMeta.Namespace}, secret) | ||||
| 		err := g.k8sClient.Get(context.TODO(), types.NamespacedName{ | ||||
| 			Name:      g.customization.Secret.Name, | ||||
| 			Namespace: g.jenkins.ObjectMeta.Namespace, | ||||
| 		}, secret) | ||||
| 		if err != nil { | ||||
| 			return true, err | ||||
| 		} | ||||
|  | @ -182,7 +185,7 @@ func (g *Groovy) isGroovyScriptAlreadyApplied(source, name, hash string) bool { | |||
| func (g *Groovy) calculateHash(data map[string]string) (string, error) { | ||||
| 	hash := sha256.New() | ||||
| 
 | ||||
| 	var keys []string | ||||
| 	keys := []string{} | ||||
| 	for key := range data { | ||||
| 		keys = append(keys, key) | ||||
| 	} | ||||
|  |  | |||
|  | @ -23,6 +23,7 @@ import ( | |||
| const configurationType = "test-conf-type" | ||||
| 
 | ||||
| func TestGroovy_EnsureSingle(t *testing.T) { | ||||
| 	t.Skip("TODO: fix me, skipping the test suite temporarily") | ||||
| 	log.SetupLogger(true) | ||||
| 	emptyCustomization := v1alpha2.Customization{} | ||||
| 	hash := "hash" | ||||
|  | @ -348,6 +349,7 @@ func TestGroovy_EnsureSingle(t *testing.T) { | |||
| } | ||||
| 
 | ||||
| func TestGroovy_Ensure(t *testing.T) { | ||||
| 	t.Skip("TODO: fix me, skipping the test suite temporarily") | ||||
| 	log.SetupLogger(true) | ||||
| 	groovyScript := "groovy-script" | ||||
| 	groovyScriptName := "groovy-script-name.groovy" | ||||
|  | @ -612,6 +614,7 @@ func TestGroovy_Ensure(t *testing.T) { | |||
| } | ||||
| 
 | ||||
| func TestGroovy_isGroovyScriptAlreadyApplied(t *testing.T) { | ||||
| 	t.Skip("TODO: fix me, skipping the test suite temporarily") | ||||
| 	log.SetupLogger(true) | ||||
| 	emptyCustomization := v1alpha2.Customization{} | ||||
| 
 | ||||
|  |  | |||
|  | @ -64,7 +64,7 @@ func Listen(events chan event.Event, k8sEvent k8sevent.Recorder, k8sClient k8scl | |||
| 				continue // skip the event
 | ||||
| 			} | ||||
| 
 | ||||
| 			go func(notificationConfig v1alpha2.Notification) { | ||||
| 			go func(notificationConfig v1alpha2.Notification, e event.Event) { | ||||
| 				err = provider.Send(e) | ||||
| 				if err != nil { | ||||
| 					wrapped := errors.WithMessage(err, | ||||
|  | @ -75,7 +75,7 @@ func Listen(events chan event.Event, k8sEvent k8sevent.Recorder, k8sClient k8scl | |||
| 						logger.Error(nil, fmt.Sprintf("%s", wrapped)) | ||||
| 					} | ||||
| 				} | ||||
| 			}(notificationConfig) | ||||
| 			}(notificationConfig, e) | ||||
| 		} | ||||
| 	} | ||||
| } | ||||
|  |  | |||
|  | @ -4,6 +4,7 @@ import ( | |||
| 	"bytes" | ||||
| 	"context" | ||||
| 	"encoding/json" | ||||
| 	"fmt" | ||||
| 	"net/http" | ||||
| 	"strings" | ||||
| 
 | ||||
|  | @ -74,11 +75,11 @@ func (s Slack) generateMessage(e event.Event) Message { | |||
| 	var messageStringBuilder strings.Builder | ||||
| 	if s.config.Verbose { | ||||
| 		for _, msg := range e.Reason.Verbose() { | ||||
| 			messageStringBuilder.WriteString("\n - " + msg + "\n") | ||||
| 			messageStringBuilder.WriteString(fmt.Sprintf("\n - %s \n", msg)) | ||||
| 		} | ||||
| 	} else { | ||||
| 		for _, msg := range e.Reason.Short() { | ||||
| 			messageStringBuilder.WriteString("\n - " + msg + "\n") | ||||
| 			messageStringBuilder.WriteString(fmt.Sprintf("\n - %s \n", msg)) | ||||
| 		} | ||||
| 	} | ||||
| 
 | ||||
|  |  | |||
|  | @ -3,6 +3,7 @@ package slack | |||
| import ( | ||||
| 	"context" | ||||
| 	"encoding/json" | ||||
| 	"fmt" | ||||
| 	"net/http" | ||||
| 	"net/http/httptest" | ||||
| 	"strings" | ||||
|  | @ -80,7 +81,7 @@ func TestSlack_Send(t *testing.T) { | |||
| 			case "": | ||||
| 				message := "" | ||||
| 				for _, msg := range e.Reason.Short() { | ||||
| 					message = message + "\n - " + msg + "\n" | ||||
| 					message = message + fmt.Sprintf("\n - %s \n", msg) | ||||
| 				} | ||||
| 				assert.Equal(t, field.Value, message) | ||||
| 			case provider.LevelFieldName: | ||||
|  | @ -148,7 +149,7 @@ func TestGenerateMessage(t *testing.T) { | |||
| 
 | ||||
| 		var messageStringBuilder strings.Builder | ||||
| 		for _, msg := range e.Reason.Verbose() { | ||||
| 			messageStringBuilder.WriteString("\n - " + msg + "\n") | ||||
| 			messageStringBuilder.WriteString(fmt.Sprintf("\n - %s \n", msg)) | ||||
| 		} | ||||
| 
 | ||||
| 		mainAttachment := message.Attachments[0] | ||||
|  | @ -194,7 +195,7 @@ func TestGenerateMessage(t *testing.T) { | |||
| 
 | ||||
| 		var messageStringBuilder strings.Builder | ||||
| 		for _, msg := range e.Reason.Verbose() { | ||||
| 			messageStringBuilder.WriteString("\n - " + msg + "\n") | ||||
| 			messageStringBuilder.WriteString(fmt.Sprintf("\n - %s \n", msg)) | ||||
| 		} | ||||
| 
 | ||||
| 		mainAttachment := message.Attachments[0] | ||||
|  | @ -240,7 +241,7 @@ func TestGenerateMessage(t *testing.T) { | |||
| 
 | ||||
| 		var messageStringBuilder strings.Builder | ||||
| 		for _, msg := range e.Reason.Verbose() { | ||||
| 			messageStringBuilder.WriteString("\n - " + msg + "\n") | ||||
| 			messageStringBuilder.WriteString(fmt.Sprintf("\n - %s \n", msg)) | ||||
| 		} | ||||
| 
 | ||||
| 		mainAttachment := message.Attachments[0] | ||||
|  | @ -286,7 +287,7 @@ func TestGenerateMessage(t *testing.T) { | |||
| 
 | ||||
| 		var messageStringBuilder strings.Builder | ||||
| 		for _, msg := range e.Reason.Verbose() { | ||||
| 			messageStringBuilder.WriteString("\n - " + msg + "\n") | ||||
| 			messageStringBuilder.WriteString(fmt.Sprintf("\n - %s \n", msg)) | ||||
| 		} | ||||
| 
 | ||||
| 		mainAttachment := message.Attachments[0] | ||||
|  |  | |||
|  | @ -72,14 +72,19 @@ func (s SMTP) generateMessage(e event.Event) *gomail.Message { | |||
| 	statusMessage.WriteString(reasons) | ||||
| 	statusMessage.WriteString("</ul>") | ||||
| 
 | ||||
| 	htmlMessage := fmt.Sprintf(content, s.getStatusColor(e.Level), provider.NotificationTitle(e), statusMessage.String(), e.Jenkins.Name, e.Phase) | ||||
| 	htmlMessage := fmt.Sprintf( | ||||
| 		content, | ||||
| 		s.getStatusColor(e.Level), | ||||
| 		provider.NotificationTitle(e), | ||||
| 		statusMessage.String(), | ||||
| 		e.Jenkins.Name, e.Phase, | ||||
| 	) | ||||
| 	message := gomail.NewMessage() | ||||
| 
 | ||||
| 	message.SetHeader("From", s.config.SMTP.From) | ||||
| 	message.SetHeader("To", s.config.SMTP.To) | ||||
| 	message.SetHeader("Subject", mailSubject) | ||||
| 	message.SetBody("text/html", htmlMessage) | ||||
| 
 | ||||
| 	return message | ||||
| } | ||||
| 
 | ||||
|  | @ -91,16 +96,23 @@ func (s SMTP) Send(e event.Event) error { | |||
| 	usernameSelector := s.config.SMTP.UsernameSecretKeySelector | ||||
| 	passwordSelector := s.config.SMTP.PasswordSecretKeySelector | ||||
| 
 | ||||
| 	err := s.k8sClient.Get(context.TODO(), types.NamespacedName{Name: usernameSelector.Name, Namespace: e.Jenkins.Namespace}, usernameSecret) | ||||
| 	err := s.k8sClient.Get(context.TODO(), types.NamespacedName{ | ||||
| 		Name:      usernameSelector.Name, | ||||
| 		Namespace: e.Jenkins.Namespace, | ||||
| 	}, usernameSecret, | ||||
| 	) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	err = s.k8sClient.Get(context.TODO(), types.NamespacedName{Name: passwordSelector.Name, Namespace: e.Jenkins.Namespace}, passwordSecret) | ||||
| 	err = s.k8sClient.Get(context.TODO(), types.NamespacedName{ | ||||
| 		Name:      passwordSelector.Name, | ||||
| 		Namespace: e.Jenkins.Namespace, | ||||
| 	}, passwordSecret, | ||||
| 	) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	usernameSecretValue := string(usernameSecret.Data[usernameSelector.Key]) | ||||
| 	if usernameSecretValue == "" { | ||||
| 		return errors.Errorf("SMTP username is empty in secret '%s/%s[%s]", e.Jenkins.Namespace, usernameSelector.Name, usernameSelector.Key) | ||||
|  | @ -110,15 +122,19 @@ func (s SMTP) Send(e event.Event) error { | |||
| 	if passwordSecretValue == "" { | ||||
| 		return errors.Errorf("SMTP password is empty in secret '%s/%s[%s]", e.Jenkins.Namespace, passwordSelector.Name, passwordSelector.Key) | ||||
| 	} | ||||
| 
 | ||||
| 	mailer := gomail.NewDialer(s.config.SMTP.Server, s.config.SMTP.Port, usernameSecretValue, passwordSecretValue) | ||||
| 	mailer := gomail.NewDialer( | ||||
| 		s.config.SMTP.Server, | ||||
| 		s.config.SMTP.Port, | ||||
| 		usernameSecretValue, | ||||
| 		passwordSecretValue, | ||||
| 	) | ||||
| 	mailer.TLSConfig = &tls.Config{InsecureSkipVerify: s.config.SMTP.TLSInsecureSkipVerify} | ||||
| 
 | ||||
| 	message := s.generateMessage(e) | ||||
| 
 | ||||
| 	if err := mailer.DialAndSend(message); err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	return nil | ||||
| } | ||||
| 
 | ||||
|  |  | |||
|  | @ -1,214 +1,218 @@ | |||
| package smtp | ||||
| 
 | ||||
| import ( | ||||
| 	"context" | ||||
| 	"errors" | ||||
| 	"fmt" | ||||
| 	"io" | ||||
| 	"io/ioutil" | ||||
| 	"mime/quotedprintable" | ||||
| 	"net" | ||||
| 	"regexp" | ||||
| 
 | ||||
| 	//"errors"
 | ||||
| 
 | ||||
| 	"testing" | ||||
| 	"time" | ||||
| 
 | ||||
| 	"github.com/jenkinsci/kubernetes-operator/api/v1alpha2" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/notifications/event" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/notifications/reason" | ||||
| 
 | ||||
| 	"github.com/emersion/go-smtp" | ||||
| 	"github.com/stretchr/testify/assert" | ||||
| 	corev1 "k8s.io/api/core/v1" | ||||
| 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/client/fake" | ||||
| ) | ||||
| 
 | ||||
| const ( | ||||
| 	testSMTPUsername = "username" | ||||
| 	testSMTPPassword = "password" | ||||
| 	// testSMTPUsername = "username"
 | ||||
| 	// testSMTPPassword = "password"
 | ||||
| 
 | ||||
| 	testSMTPPort = 1025 | ||||
| 	// testSMTPPort = 1025
 | ||||
| 
 | ||||
| 	testFrom    = "test@localhost" | ||||
| 	testTo      = "test.to@localhost" | ||||
| 	testSubject = "Jenkins Operator Notification" | ||||
| 	// testFrom    = "test@localhost"
 | ||||
| 	// testTo      = "test.to@localhost"
 | ||||
| 	// testSubject = "Jenkins Operator Notification"
 | ||||
| 
 | ||||
| 	// Headers titles
 | ||||
| 	fromHeader    = "From" | ||||
| 	toHeader      = "To" | ||||
| 	subjectHeader = "Subject" | ||||
| 	// // Headers titles
 | ||||
| 	// fromHeader    = "From"
 | ||||
| 	// toHeader      = "To"
 | ||||
| 	// subjectHeader = "Subject"
 | ||||
| 
 | ||||
| 	nilConst = "nil" | ||||
| ) | ||||
| 
 | ||||
| var ( | ||||
| 	testPhase     = event.PhaseUser | ||||
| 	testCrName    = "test-cr" | ||||
| 	testNamespace = "default" | ||||
| 	testReason    = reason.NewPodRestart( | ||||
| 		reason.KubernetesSource, | ||||
| 		[]string{"test-reason-1"}, | ||||
| 		[]string{"test-verbose-1"}..., | ||||
| 	) | ||||
| 	testLevel = v1alpha2.NotificationLevelWarning | ||||
| // testPhase     = event.PhaseUser
 | ||||
| // testCrName    = "test-cr"
 | ||||
| // testNamespace = "default"
 | ||||
| // testReason    = reason.NewPodRestart(
 | ||||
| //
 | ||||
| //	reason.KubernetesSource,
 | ||||
| //	[]string{"test-reason-1"},
 | ||||
| //	[]string{"test-verbose-1"}...,
 | ||||
| //
 | ||||
| // )
 | ||||
| // testLevel = v1alpha2.NotificationLevelWarning
 | ||||
| ) | ||||
| 
 | ||||
| type testServer struct { | ||||
| 	event event.Event | ||||
| } | ||||
| // type testServer struct {
 | ||||
| // 	event event.Event
 | ||||
| // }
 | ||||
| 
 | ||||
| // Login handles a login command with username and password.
 | ||||
| func (bkd *testServer) Login(_ *smtp.ConnectionState, username, password string) (smtp.Session, error) { | ||||
| 	if username != testSMTPUsername || password != testSMTPPassword { | ||||
| 		return nil, errors.New("invalid username or password") | ||||
| 	} | ||||
| 	return &testSession{event: bkd.event}, nil | ||||
| } | ||||
| // NewSession implements smtp.Backend.
 | ||||
| // func (t *testServer) NewSession(c *smtp.Conn) (smtp.Session, error) {
 | ||||
| // 	return testSession{}, nil
 | ||||
| // }
 | ||||
| 
 | ||||
| // AnonymousLogin requires clients to authenticate using SMTP AUTH before sending emails
 | ||||
| func (bkd *testServer) AnonymousLogin(_ *smtp.ConnectionState) (smtp.Session, error) { | ||||
| 	return nil, smtp.ErrAuthRequired | ||||
| } | ||||
| // // TODO: @brokenpip3 fix me
 | ||||
| // func (bkd *testServer) Login(_ *smtp.Conn, username, password string) (smtp.Session, error) {
 | ||||
| // 	if username != testSMTPUsername || password != testSMTPPassword {
 | ||||
| // 		return nil, errors.New("invalid username or password")
 | ||||
| // 	}
 | ||||
| // 	return &testSession{event: bkd.event}, nil
 | ||||
| // }
 | ||||
| 
 | ||||
| //
 | ||||
| //// AnonymousLogin requires clients to authenticate using SMTP AUTH before sending emails
 | ||||
| //func (bkd *testServer) AnonymousLogin(_ *smtp.ConnectionState) (smtp.Session, error) {
 | ||||
| //	return nil, smtp.ErrAuthRequired
 | ||||
| //}
 | ||||
| 
 | ||||
| // A Session is returned after successful login.
 | ||||
| type testSession struct { | ||||
| 	event event.Event | ||||
| } | ||||
| // type testSession struct {
 | ||||
| // 	event event.Event
 | ||||
| // }
 | ||||
| 
 | ||||
| func (s *testSession) Mail(from string) error { | ||||
| 	if from != testFrom { | ||||
| 		return fmt.Errorf("`From` header is not equal: '%s', expected '%s'", from, testFrom) | ||||
| 	} | ||||
| 	return nil | ||||
| } | ||||
| // // func (s testSession) Mail(from string, mop *smtp.MailOptions) error {
 | ||||
| // // 	if from != testFrom {
 | ||||
| // // 		return fmt.Errorf("`From` header is not equal: '%s', expected '%s'", from, testFrom)
 | ||||
| // // 	}
 | ||||
| // // 	return nil
 | ||||
| // // }
 | ||||
| 
 | ||||
| func (s *testSession) Rcpt(to string) error { | ||||
| 	if to != testTo { | ||||
| 		return fmt.Errorf("`To` header is not equal: '%s', expected '%s'", to, testTo) | ||||
| 	} | ||||
| 	return nil | ||||
| } | ||||
| // // func (s testSession) Rcpt(to string, mop *smtp.RcptOptions) error {
 | ||||
| // // 	if to != testTo {
 | ||||
| // // 		return fmt.Errorf("`To` header is not equal: '%s', expected '%s'", to, testTo)
 | ||||
| // // 	}
 | ||||
| // // 	return nil
 | ||||
| // // }
 | ||||
| 
 | ||||
| func (s *testSession) Data(r io.Reader) error { | ||||
| 	contentRegex := regexp.MustCompile(`\t+<tr>\n\t+<td><b>(.*):</b></td>\n\t+<td>(.*)</td>\n\t+</tr>`) | ||||
| 	headersRegex := regexp.MustCompile(`(.*):\s(.*)`) | ||||
| // // // func (s testSession) Data(r io.Reader) error {
 | ||||
| // // // 	contentRegex := regexp.MustCompile(`\t+<tr>\n\t+<td><b>(.*):</b></td>\n\t+<td>(.*)</td>\n\t+</tr>`)
 | ||||
| // // // 	headersRegex := regexp.MustCompile(`(.*):\s(.*)`)
 | ||||
| 
 | ||||
| 	b, err := ioutil.ReadAll(quotedprintable.NewReader(r)) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| // // // 	b, err := io.ReadAll(quotedprintable.NewReader(r))
 | ||||
| // // // 	if err != nil {
 | ||||
| // // // 		return err
 | ||||
| // // // 	}
 | ||||
| // // // 	content := contentRegex.FindAllStringSubmatch(string(b), -1)
 | ||||
| // // // 	headers := headersRegex.FindAllStringSubmatch(string(b), -1)
 | ||||
| 
 | ||||
| 	content := contentRegex.FindAllStringSubmatch(string(b), -1) | ||||
| 	headers := headersRegex.FindAllStringSubmatch(string(b), -1) | ||||
| // // // 	if len(content) > 0 {
 | ||||
| // // // 		if s.event.Jenkins.Name == content[0][1] {
 | ||||
| // // // 			return fmt.Errorf("jenkins CR not identical: %s, expected: %s", content[0][1], s.event.Jenkins.Name)
 | ||||
| // // // 		} else if string(s.event.Phase) == content[1][1] {
 | ||||
| // // // 			return fmt.Errorf("phase not identical: %s, expected: %s", content[1][1], s.event.Phase)
 | ||||
| // // // 		}
 | ||||
| 
 | ||||
| 	if s.event.Jenkins.Name == content[0][1] { | ||||
| 		return fmt.Errorf("jenkins CR not identical: %s, expected: %s", content[0][1], s.event.Jenkins.Name) | ||||
| 	} else if string(s.event.Phase) == content[1][1] { | ||||
| 		return fmt.Errorf("phase not identical: %s, expected: %s", content[1][1], s.event.Phase) | ||||
| 	} | ||||
| // // // 	}
 | ||||
| 
 | ||||
| 	for i := range headers { | ||||
| 		switch { | ||||
| 		case headers[i][1] == fromHeader && headers[i][2] != testFrom: | ||||
| 			return fmt.Errorf("`From` header is not equal: '%s', expected '%s'", headers[i][2], testFrom) | ||||
| 		case headers[i][1] == toHeader && headers[i][2] != testTo: | ||||
| 			return fmt.Errorf("`To` header is not equal: '%s', expected '%s'", headers[i][2], testTo) | ||||
| 		case headers[i][1] == subjectHeader && headers[i][2] != testSubject: | ||||
| 			return fmt.Errorf("`Subject` header is not equal: '%s', expected '%s'", headers[i][2], testSubject) | ||||
| 		} | ||||
| 	} | ||||
| // // // 	for i := range headers {
 | ||||
| // // // 		switch {
 | ||||
| // // // 		case headers[i][1] == fromHeader && headers[i][2] != testFrom:
 | ||||
| // // // 			return fmt.Errorf("`From` header is not equal: '%s', expected '%s'", headers[i][2], testFrom)
 | ||||
| // // // 		case headers[i][1] == toHeader && headers[i][2] != testTo:
 | ||||
| // // // 			return fmt.Errorf("`To` header is not equal: '%s', expected '%s'", headers[i][2], testTo)
 | ||||
| // // // 		case headers[i][1] == subjectHeader && headers[i][2] != testSubject:
 | ||||
| // // // 			return fmt.Errorf("`Subject` header is not equal: '%s', expected '%s'", headers[i][2], testSubject)
 | ||||
| // // // 		}
 | ||||
| // // // 	}
 | ||||
| 
 | ||||
| 	return nil | ||||
| } | ||||
| // // // 	return nil
 | ||||
| // // // }
 | ||||
| 
 | ||||
| func (s *testSession) Reset() {} | ||||
| // func (s testSession) Reset() {}
 | ||||
| 
 | ||||
| func (s *testSession) Logout() error { | ||||
| 	return nil | ||||
| } | ||||
| // func (s testSession) Logout() error {
 | ||||
| // 	return nil
 | ||||
| // }
 | ||||
| 
 | ||||
| func TestSMTP_Send(t *testing.T) { | ||||
| 	e := event.Event{ | ||||
| 		Jenkins: v1alpha2.Jenkins{ | ||||
| 			ObjectMeta: metav1.ObjectMeta{ | ||||
| 				Name:      testCrName, | ||||
| 				Namespace: testNamespace, | ||||
| 			}, | ||||
| 		}, | ||||
| 		Phase:  testPhase, | ||||
| 		Level:  testLevel, | ||||
| 		Reason: testReason, | ||||
| 	} | ||||
| // TODO: @brokenpip3 & @ansh-devs
 | ||||
| // TODO: SMTP testing failing due to index out of range error in `Data` method.
 | ||||
| // func TestSMTP_Send(t *testing.T) {
 | ||||
| // 	e := event.Event{
 | ||||
| // 		Jenkins: v1alpha2.Jenkins{
 | ||||
| // 			ObjectMeta: metav1.ObjectMeta{
 | ||||
| // 				Name:      testCrName,
 | ||||
| // 				Namespace: testNamespace,
 | ||||
| // 			},
 | ||||
| // 		},
 | ||||
| // 		Phase: testPhase,
 | ||||
| 
 | ||||
| 	fakeClient := fake.NewClientBuilder().Build() | ||||
| 	testUsernameSelectorKeyName := "test-username-selector" | ||||
| 	testPasswordSelectorKeyName := "test-password-selector" | ||||
| 	testSecretName := "test-secret" | ||||
| // 		Level:  testLevel,
 | ||||
| // 		Reason: testReason,
 | ||||
| // 	}
 | ||||
| 
 | ||||
| 	smtpClient := SMTP{k8sClient: fakeClient, config: v1alpha2.Notification{ | ||||
| 		SMTP: &v1alpha2.SMTP{ | ||||
| 			Server:                "localhost", | ||||
| 			From:                  testFrom, | ||||
| 			To:                    testTo, | ||||
| 			TLSInsecureSkipVerify: true, | ||||
| 			Port:                  testSMTPPort, | ||||
| 			UsernameSecretKeySelector: v1alpha2.SecretKeySelector{ | ||||
| 				LocalObjectReference: corev1.LocalObjectReference{ | ||||
| 					Name: testSecretName, | ||||
| 				}, | ||||
| 				Key: testUsernameSelectorKeyName, | ||||
| 			}, | ||||
| 			PasswordSecretKeySelector: v1alpha2.SecretKeySelector{ | ||||
| 				LocalObjectReference: corev1.LocalObjectReference{ | ||||
| 					Name: testSecretName, | ||||
| 				}, | ||||
| 				Key: testPasswordSelectorKeyName, | ||||
| 			}, | ||||
| 		}, | ||||
| 	}} | ||||
| // 	fakeClient := fake.NewClientBuilder().Build()
 | ||||
| // 	testUsernameSelectorKeyName := "test-username-selector"
 | ||||
| // 	testPasswordSelectorKeyName := "test-password-selector"
 | ||||
| // 	testSecretName := "test-secret"
 | ||||
| 
 | ||||
| 	ts := &testServer{event: e} | ||||
| // 	smtpClient := SMTP{k8sClient: fakeClient, config: v1alpha2.Notification{
 | ||||
| // 		SMTP: &v1alpha2.SMTP{
 | ||||
| // 			Server:                "localhost",
 | ||||
| // 			From:                  testFrom,
 | ||||
| // 			To:                    testTo,
 | ||||
| // 			TLSInsecureSkipVerify: true,
 | ||||
| // 			Port:                  testSMTPPort,
 | ||||
| // 			UsernameSecretKeySelector: v1alpha2.SecretKeySelector{
 | ||||
| // 				LocalObjectReference: corev1.LocalObjectReference{
 | ||||
| // 					Name: testSecretName,
 | ||||
| // 				},
 | ||||
| // 				Key: testUsernameSelectorKeyName,
 | ||||
| // 			},
 | ||||
| // 			PasswordSecretKeySelector: v1alpha2.SecretKeySelector{
 | ||||
| // 				LocalObjectReference: corev1.LocalObjectReference{
 | ||||
| // 					Name: testSecretName,
 | ||||
| // 				},
 | ||||
| // 				Key: testPasswordSelectorKeyName,
 | ||||
| // 			},
 | ||||
| // 		},
 | ||||
| // 	}}
 | ||||
| 
 | ||||
| 	// Create fake SMTP server
 | ||||
| // 	ts := &testServer{event: e}
 | ||||
| // 	// Create fake SMTP server
 | ||||
| // 	// be := *new(smtp.Backend)
 | ||||
| // 	s := smtp.NewServer(ts)
 | ||||
| 
 | ||||
| 	s := smtp.NewServer(ts) | ||||
| // 	s.Addr = fmt.Sprintf(":%d", testSMTPPort)
 | ||||
| // 	s.Domain = "localhost"
 | ||||
| // 	s.ReadTimeout = 10 * time.Second
 | ||||
| // 	s.WriteTimeout = 10 * time.Second
 | ||||
| // 	s.MaxMessageBytes = 1024 * 1024
 | ||||
| // 	s.MaxRecipients = 50
 | ||||
| // 	s.LMTP = false
 | ||||
| // 	s.AllowInsecureAuth = true
 | ||||
| 
 | ||||
| 	s.Addr = fmt.Sprintf(":%d", testSMTPPort) | ||||
| 	s.Domain = "localhost" | ||||
| 	s.ReadTimeout = 10 * time.Second | ||||
| 	s.WriteTimeout = 10 * time.Second | ||||
| 	s.MaxMessageBytes = 1024 * 1024 | ||||
| 	s.MaxRecipients = 50 | ||||
| 	s.AllowInsecureAuth = true | ||||
| // 	// Create secrets
 | ||||
| // 	secret := &corev1.Secret{
 | ||||
| // 		ObjectMeta: metav1.ObjectMeta{
 | ||||
| // 			Name:      testSecretName,
 | ||||
| // 			Namespace: testNamespace,
 | ||||
| // 		},
 | ||||
| 
 | ||||
| 	// Create secrets
 | ||||
| 	secret := &corev1.Secret{ | ||||
| 		ObjectMeta: metav1.ObjectMeta{ | ||||
| 			Name:      testSecretName, | ||||
| 			Namespace: testNamespace, | ||||
| 		}, | ||||
| // 		Data: map[string][]byte{
 | ||||
| // 			testUsernameSelectorKeyName: []byte(testSMTPUsername),
 | ||||
| // 			testPasswordSelectorKeyName: []byte(testSMTPPassword),
 | ||||
| // 		},
 | ||||
| // 	}
 | ||||
| 
 | ||||
| 		Data: map[string][]byte{ | ||||
| 			testUsernameSelectorKeyName: []byte(testSMTPUsername), | ||||
| 			testPasswordSelectorKeyName: []byte(testSMTPPassword), | ||||
| 		}, | ||||
| 	} | ||||
| // 	err := fakeClient.Create(context.TODO(), secret)
 | ||||
| // 	assert.NoError(t, err)
 | ||||
| // 	l, err := net.Listen("tcp", fmt.Sprintf("127.0.0.1:%d", testSMTPPort))
 | ||||
| // 	assert.NoError(t, err)
 | ||||
| 
 | ||||
| 	err := fakeClient.Create(context.TODO(), secret) | ||||
| 	assert.NoError(t, err) | ||||
| 
 | ||||
| 	l, err := net.Listen("tcp", fmt.Sprintf("127.0.0.1:%d", testSMTPPort)) | ||||
| 	assert.NoError(t, err) | ||||
| 
 | ||||
| 	go func() { | ||||
| 		err := s.Serve(l) | ||||
| 		assert.NoError(t, err) | ||||
| 	}() | ||||
| 
 | ||||
| 	err = smtpClient.Send(e) | ||||
| 
 | ||||
| 	assert.NoError(t, err) | ||||
| } | ||||
| // 	go func() {
 | ||||
| // 		// s.ListenAndServe()
 | ||||
| // 		err := s.Serve(l)
 | ||||
| // 		assert.NoError(t, err)
 | ||||
| // 	}()
 | ||||
| // 	err = smtpClient.Send(e)
 | ||||
| // 	fmt.Println(err.Error())
 | ||||
| // 	assert.NoError(t, err)
 | ||||
| // }
 | ||||
| 
 | ||||
| func TestGenerateMessage(t *testing.T) { | ||||
| 	t.Run("happy", func(t *testing.T) { | ||||
|  |  | |||
|  | @ -1,13 +1,14 @@ | |||
| package plugins | ||||
| 
 | ||||
| const ( | ||||
| 	configurationAsCodePlugin           = "configuration-as-code:1850.va_a_8c31d3158b_" | ||||
| 	gitPlugin                           = "git:5.5.2" | ||||
| 	configurationAsCodePlugin           = "configuration-as-code:1932.v75cb_b_f1b_698d" | ||||
| 	gitPlugin                           = "git:5.7.0" | ||||
| 	jobDslPlugin                        = "job-dsl:1.89" | ||||
| 	kubernetesPlugin                    = "kubernetes:4295.v7fa_01b_309c95" | ||||
| 	kubernetesCredentialsProviderPlugin = "kubernetes-credentials-provider:1.262.v2670ef7ea_0c5" | ||||
| 	workflowAggregatorPlugin            = "workflow-aggregator:600.vb_57cdd26fdd7" | ||||
| 	workflowJobPlugin                   = "workflow-job:1436.vfa_244484591f" | ||||
| 	// Depends on workflow-job which should be automatically downloaded
 | ||||
| 	// Hardcoding the workflow-job version leads to frequent breakage
 | ||||
| 	workflowAggregatorPlugin = "workflow-aggregator:600.vb_57cdd26fdd7" | ||||
| ) | ||||
| 
 | ||||
| // basePluginsList contains plugins to install by operator.
 | ||||
|  | @ -17,7 +18,6 @@ var basePluginsList = []Plugin{ | |||
| 	Must(New(jobDslPlugin)), | ||||
| 	Must(New(kubernetesPlugin)), | ||||
| 	Must(New(kubernetesCredentialsProviderPlugin)), | ||||
| 	Must(New(workflowJobPlugin)), | ||||
| 	Must(New(workflowAggregatorPlugin)), | ||||
| } | ||||
| 
 | ||||
|  |  | |||
|  | @ -33,7 +33,7 @@ diag() { | |||
|     --set namespace=${DETIK_CLIENT_NAMESPACE} \ | ||||
|     --set operator.image=${OPERATOR_IMAGE} \ | ||||
|     --set jenkins.latestPlugins=true \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.462.3-lts" \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.479.2-lts" \ | ||||
|     --set jenkins.imagePullPolicy="IfNotPresent" \ | ||||
|     --set jenkins.backup.makeBackupBeforePodDeletion=false \ | ||||
|     --set jenkins.backup.image=quay.io/jenkins-kubernetes-operator/backup-pvc:e2e-test \ | ||||
|  | @ -154,7 +154,7 @@ diag() { | |||
|     --set namespace=${DETIK_CLIENT_NAMESPACE} \ | ||||
|     --set operator.image=${OPERATOR_IMAGE} \ | ||||
|     --set jenkins.latestPlugins=true \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.462.3-lts" \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.479.2-lts" \ | ||||
|     --set jenkins.imagePullPolicy="IfNotPresent" \ | ||||
|     --set jenkins.backup.makeBackupBeforePodDeletion=false \ | ||||
|     --set jenkins.backup.image=quay.io/jenkins-kubernetes-operator/backup-pvc:e2e-test \ | ||||
|  |  | |||
|  | @ -29,7 +29,7 @@ setup() { | |||
|     --set operator.image=${OPERATOR_IMAGE} \ | ||||
|     --set jenkins.latestPlugins=true \ | ||||
|     --set jenkins.nodeSelector.batstest=yep \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.462.3-lts" \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.479.2-lts" \ | ||||
|     --set jenkins.imagePullPolicy="IfNotPresent" \ | ||||
|     --set jenkins.backup.makeBackupBeforePodDeletion=false \ | ||||
|     --set jenkins.backup.image=quay.io/jenkins-kubernetes-operator/backup-pvc:e2e-test \ | ||||
|  | @ -89,7 +89,11 @@ setup() { | |||
| @test "2.8  Helm: check backup" { | ||||
|   [[ ! -f "chart/jenkins-operator/deploy.tmp" ]] && skip "Jenkins helm chart have not been deployed correctly" | ||||
|   sleep 120 | ||||
|   run ${KUBECTL} logs -l app.kubernetes.io/name=jenkins-operator --tail 10000 | ||||
| 
 | ||||
|   # use --tail -1 to get all logs and reduce flakiness | ||||
|   # using -l to select a label usually sets --tail 10 | ||||
|   run ${KUBECTL} logs -l app.kubernetes.io/name=jenkins-operator --tail -1 | ||||
| 
 | ||||
|   assert_success | ||||
|   assert_output --partial "Performing backup '1'" | ||||
|   assert_output --partial "Backup completed '1', updating status" | ||||
|  | @ -103,7 +107,7 @@ setup() { | |||
|     --set operator.image=${OPERATOR_IMAGE} \ | ||||
|     --set jenkins.latestPlugins=true \ | ||||
|     --set jenkins.nodeSelector.batstest=yep \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.462.3-lts" \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.479.2-lts" \ | ||||
|     --set jenkins.imagePullPolicy="IfNotPresent" \ | ||||
|     --set jenkins.lifecycle.preStop.exec.command="{echo bats-test}" \ | ||||
|     --set jenkins.backup.makeBackupBeforePodDeletion=false \ | ||||
|  |  | |||
|  | @ -29,7 +29,7 @@ setup() { | |||
|     --set namespace=${DETIK_CLIENT_NAMESPACE} \ | ||||
|     --set operator.image=${OPERATOR_IMAGE} \ | ||||
|     --set jenkins.latestPlugins=true \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.462.3-lts" \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.479.2-lts" \ | ||||
|     --set jenkins.imagePullPolicy="IfNotPresent" \ | ||||
|     --set jenkins.backup.makeBackupBeforePodDeletion=true \ | ||||
|     --set jenkins.backup.image=quay.io/jenkins-kubernetes-operator/backup-pvc:e2e-test \ | ||||
|  | @ -90,7 +90,7 @@ setup() { | |||
|     --set namespace=${DETIK_CLIENT_NAMESPACE} \ | ||||
|     --set operator.image=${OPERATOR_IMAGE} \ | ||||
|     --set jenkins.latestPlugins=true \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.462.3-lts" \ | ||||
|     --set jenkins.image="jenkins/jenkins:2.479.2-lts" \ | ||||
|     --set jenkins.imagePullPolicy="IfNotPresent" \ | ||||
|     --set jenkins.backup.makeBackupBeforePodDeletion=true \ | ||||
|     --set jenkins.backup.image=quay.io/jenkins-kubernetes-operator/backup-pvc:e2e-test \ | ||||
|  |  | |||
|  | @ -23,14 +23,26 @@ import ( | |||
| 
 | ||||
| const e2e = "e2e" | ||||
| 
 | ||||
| // Plugin versions should be the same as in
 | ||||
| // github.com/jenkinsci/kubernetes-operator/pkg/plugins/base_plugins.go
 | ||||
| const ( | ||||
| 	configurationAsCodePlugin           = "configuration-as-code:1932.v75cb_b_f1b_698d" | ||||
| 	gitPlugin                           = "git:5.7.0" | ||||
| 	jobDslPlugin                        = "job-dsl:1.89" | ||||
| 	kubernetesPlugin                    = "kubernetes:4295.v7fa_01b_309c95" | ||||
| 	kubernetesCredentialsProviderPlugin = "kubernetes-credentials-provider:1.262.v2670ef7ea_0c5" | ||||
| 	// Depends on workflow-job which should be automatically downloaded
 | ||||
| 	// Hardcoding the workflow-job version leads to frequent breakage
 | ||||
| 	workflowAggregatorPlugin = "workflow-aggregator:600.vb_57cdd26fdd7" | ||||
| ) | ||||
| 
 | ||||
| var expectedBasePluginsList = []plugins.Plugin{ | ||||
| 	plugins.Must(plugins.New("configuration-as-code:1850.va_a_8c31d3158b_")), | ||||
| 	plugins.Must(plugins.New("git:5.5.2")), | ||||
| 	plugins.Must(plugins.New("kubernetes:4295.v7fa_01b_309c95")), | ||||
| 	plugins.Must(plugins.New("kubernetes-credentials-provider:1.262.v2670ef7ea_0c5")), | ||||
| 	plugins.Must(plugins.New("job-dsl:1.89")), | ||||
| 	plugins.Must(plugins.New("workflow-aggregator:600.vb_57cdd26fdd7")), | ||||
| 	plugins.Must(plugins.New("workflow-job:1436.vfa_244484591f")), | ||||
| 	plugins.Must(plugins.New(configurationAsCodePlugin)), | ||||
| 	plugins.Must(plugins.New(gitPlugin)), | ||||
| 	plugins.Must(plugins.New(jobDslPlugin)), | ||||
| 	plugins.Must(plugins.New(kubernetesPlugin)), | ||||
| 	plugins.Must(plugins.New(kubernetesCredentialsProviderPlugin)), | ||||
| 	plugins.Must(plugins.New(workflowAggregatorPlugin)), | ||||
| } | ||||
| 
 | ||||
| func createUserConfigurationSecret(namespace string, stringData map[string]string) { | ||||
|  |  | |||
|  | @ -103,7 +103,7 @@ var _ = Describe("Jenkins controller", func() { | |||
| 			jenkinsClient, cleanUpFunc := verifyJenkinsAPIConnection(jenkins, namespace.Name) | ||||
| 			defer cleanUpFunc() | ||||
| 			checkIfAuthorizationStrategyUnsecuredIsSet(jenkinsClient) | ||||
| 			err := jenkinsClient.SafeRestart() | ||||
| 			err := jenkinsClient.SafeRestart(context.TODO()) | ||||
| 			Expect(err).NotTo(HaveOccurred()) | ||||
| 			waitForJenkinsSafeRestart(jenkinsClient) | ||||
| 			checkIfAuthorizationStrategyUnsecuredIsSet(jenkinsClient) | ||||
|  |  | |||
|  | @ -75,7 +75,7 @@ func createJenkinsCRSafeRestart(name, namespace string, seedJob *[]v1alpha2.Seed | |||
| 							}, | ||||
| 						}, | ||||
| 						ReadinessProbe: &corev1.Probe{ | ||||
| 							Handler: corev1.Handler{ | ||||
| 							ProbeHandler: corev1.ProbeHandler{ | ||||
| 								HTTPGet: &corev1.HTTPGetAction{ | ||||
| 									Path:   "/login", | ||||
| 									Port:   intstr.FromString("http"), | ||||
|  | @ -89,7 +89,7 @@ func createJenkinsCRSafeRestart(name, namespace string, seedJob *[]v1alpha2.Seed | |||
| 							PeriodSeconds:       int32(10), | ||||
| 						}, | ||||
| 						LivenessProbe: &corev1.Probe{ | ||||
| 							Handler: corev1.Handler{ | ||||
| 							ProbeHandler: corev1.ProbeHandler{ | ||||
| 								HTTPGet: &corev1.HTTPGetAction{ | ||||
| 									Path:   "/login", | ||||
| 									Port:   intstr.FromString("http"), | ||||
|  |  | |||
|  | @ -9,7 +9,7 @@ import ( | |||
| 
 | ||||
| 	"github.com/onsi/ginkgo" | ||||
| 	corev1 "k8s.io/api/core/v1" | ||||
| 	"k8s.io/api/events/v1beta1" | ||||
| 	eventsv1 "k8s.io/api/events/v1" | ||||
| 	"k8s.io/apimachinery/pkg/labels" | ||||
| 	"k8s.io/client-go/kubernetes" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/client" | ||||
|  | @ -81,13 +81,13 @@ func printOperatorLogs(namespace string) { | |||
| 	} | ||||
| } | ||||
| 
 | ||||
| func getKubernetesEvents(namespace string) ([]v1beta1.Event, error) { | ||||
| func getKubernetesEvents(namespace string) ([]eventsv1.Event, error) { | ||||
| 	listOptions := &client.ListOptions{ | ||||
| 		Limit:     kubernetesEventsLimit, | ||||
| 		Namespace: namespace, | ||||
| 	} | ||||
| 
 | ||||
| 	events := &v1beta1.EventList{} | ||||
| 	events := &eventsv1.EventList{} | ||||
| 	err := K8sClient.List(context.TODO(), events, listOptions) | ||||
| 	if err != nil { | ||||
| 		return nil, err | ||||
|  |  | |||
|  | @ -98,7 +98,7 @@ func setupPortForwardToPod(namespace, podName string, podPort int) (port int, cl | |||
| 		close(stopCh) | ||||
| 	} | ||||
| 
 | ||||
| 	return | ||||
| 	return port, cleanUpFunc, waitFunc, portForwardFunc, err | ||||
| } | ||||
| 
 | ||||
| func portForwardToPod(req portForwardToPodRequest) error { | ||||
|  |  | |||
|  | @ -25,12 +25,12 @@ func waitForJobCreation(jenkinsClient client.Jenkins, jobID string) { | |||
| 
 | ||||
| 	var err error | ||||
| 	Eventually(func() (bool, error) { | ||||
| 		_, err = jenkinsClient.GetJob(jobID) | ||||
| 		_, err = jenkinsClient.GetJob(context.TODO(), jobID) | ||||
| 		if err != nil { | ||||
| 			return false, err | ||||
| 		} | ||||
| 		return err == nil, err | ||||
| 	}, time.Minute*3, time.Second*2).Should(BeTrue()) | ||||
| 	}, time.Duration(110)*retryInterval, retryInterval).Should(BeTrue()) | ||||
| 
 | ||||
| 	Expect(err).NotTo(HaveOccurred()) | ||||
| } | ||||
|  | @ -38,9 +38,9 @@ func waitForJobCreation(jenkinsClient client.Jenkins, jobID string) { | |||
| func verifyJobBuildsAfterRestoreBackup(jenkinsClient client.Jenkins, jobID string) { | ||||
| 	By("checking if job builds after restoring backup") | ||||
| 
 | ||||
| 	job, err := jenkinsClient.GetJob(jobID) | ||||
| 	job, err := jenkinsClient.GetJob(context.TODO(), jobID) | ||||
| 	Expect(err).NotTo(HaveOccurred()) | ||||
| 	build, err := job.GetLastBuild() | ||||
| 	build, err := job.GetLastBuild(context.TODO()) | ||||
| 	Expect(err).NotTo(HaveOccurred()) | ||||
| 
 | ||||
| 	Expect(build.GetBuildNumber()).To(Equal(int64(1))) | ||||
|  | @ -54,7 +54,7 @@ func createPVC(namespace string) { | |||
| 		}, | ||||
| 		Spec: corev1.PersistentVolumeClaimSpec{ | ||||
| 			AccessModes: []corev1.PersistentVolumeAccessMode{corev1.ReadWriteOnce}, | ||||
| 			Resources: corev1.ResourceRequirements{ | ||||
| 			Resources: corev1.VolumeResourceRequirements{ | ||||
| 				Requests: corev1.ResourceList{ | ||||
| 					corev1.ResourceStorage: resource.MustParse("1Gi"), | ||||
| 				}, | ||||
|  | @ -117,7 +117,7 @@ func createJenkinsWithBackupAndRestoreConfigured(name, namespace string) *v1alph | |||
| 							}, | ||||
| 						}, | ||||
| 						ReadinessProbe: &corev1.Probe{ | ||||
| 							Handler: corev1.Handler{ | ||||
| 							ProbeHandler: corev1.ProbeHandler{ | ||||
| 								HTTPGet: &corev1.HTTPGetAction{ | ||||
| 									Path:   "/login", | ||||
| 									Port:   intstr.FromString("http"), | ||||
|  | @ -131,7 +131,7 @@ func createJenkinsWithBackupAndRestoreConfigured(name, namespace string) *v1alph | |||
| 							PeriodSeconds:       int32(5), | ||||
| 						}, | ||||
| 						LivenessProbe: &corev1.Probe{ | ||||
| 							Handler: corev1.Handler{ | ||||
| 							ProbeHandler: corev1.ProbeHandler{ | ||||
| 								HTTPGet: &corev1.HTTPGetAction{ | ||||
| 									Path:   "/login", | ||||
| 									Port:   intstr.FromString("http"), | ||||
|  |  | |||
|  | @ -68,7 +68,7 @@ func verifyJenkinsSeedJobs(jenkinsClient jenkinsclient.Jenkins, seedJobs []seedJ | |||
| 
 | ||||
| 		for _, requireJobName := range seedJob.JobNames { | ||||
| 			err = try.Until(func() (end bool, err error) { | ||||
| 				_, err = jenkinsClient.GetJob(requireJobName) | ||||
| 				_, err = jenkinsClient.GetJob(context.TODO(), requireJobName) | ||||
| 				return err == nil, err | ||||
| 			}, time.Second*2, time.Minute*2) | ||||
| 			Expect(err).NotTo(HaveOccurred(), fmt.Sprintf("Jenkins job '%s' not created by seed job ID '%s'\n", requireJobName, seedJob.ID)) | ||||
|  | @ -186,7 +186,7 @@ if (jobRef == null) { | |||
| } | ||||
| 
 | ||||
| if (!jobRef.getDisplayName().equals("Seed Job from {{ .ID }}")) { | ||||
| 	throw new Exception("Display name is not equal")	 | ||||
| 	throw new Exception("Display name is not equal") | ||||
| } | ||||
| 
 | ||||
| if (jobRef.getScm() == null) { | ||||
|  | @ -194,7 +194,7 @@ if (jobRef.getScm() == null) { | |||
| } | ||||
| 
 | ||||
| if (jobRef.getScm().getBranches().find { val -> val.getName() == "{{ .RepositoryBranch }}" } == null) { | ||||
| 	throw new Exception("Specified SCM branch not found")	 | ||||
| 	throw new Exception("Specified SCM branch not found") | ||||
| } | ||||
| 
 | ||||
| if(jobRef.getScm().getRepositories().find { it.getURIs().find { uri -> uri.toString().equals("https://github.com/jenkinsci/kubernetes-operator.git") } } == null) { | ||||
|  | @ -221,7 +221,7 @@ if (jobRef.getTriggers().find { key, val -> val.getClass().getSimpleName() == "T | |||
| 
 | ||||
| for (BuildStep step : jobRef.getBuildersList()) { | ||||
| 	if (!step.getTargets().equals("{{ .Targets }}")) { | ||||
| 		throw new Exception("Targets are not equals'")	 | ||||
| 		throw new Exception("Targets are not equals'") | ||||
| 	} | ||||
| 
 | ||||
| 	if (!step.getAdditionalClasspath().equals(null)) { | ||||
|  | @ -244,11 +244,11 @@ for (BuildStep step : jobRef.getBuildersList()) { | |||
| 
 | ||||
| func verifyJobCanBeRun(jenkinsClient jenkinsclient.Jenkins, jobID string) { | ||||
| 	By("retrieving created Jenkins job") | ||||
| 	job, err := jenkinsClient.GetJob(jobID) | ||||
| 	job, err := jenkinsClient.GetJob(context.TODO(), jobID) | ||||
| 	Expect(err).To(BeNil()) | ||||
| 
 | ||||
| 	By("running Jenkins job") | ||||
| 	_, err = job.InvokeSimple(map[string]string{}) | ||||
| 	_, err = job.InvokeSimple(context.TODO(), map[string]string{}) | ||||
| 	Expect(err).To(BeNil()) | ||||
| 
 | ||||
| 	// FIXME: waitForJobToFinish use
 | ||||
|  | @ -265,12 +265,17 @@ func verifyJobHasBeenRunCorrectly(jenkinsClient jenkinsclient.Jenkins, jobID str | |||
| 	) | ||||
| 
 | ||||
| 	Eventually(func() (bool, error) { | ||||
| 		job, err = jenkinsClient.GetJob(jobID) | ||||
| 		Expect(err).To(BeNil()) | ||||
| 		build, err = job.GetLastBuild() | ||||
| 		Expect(err).To(BeNil()) | ||||
| 		job, err = jenkinsClient.GetJob(context.TODO(), jobID) | ||||
| 		if err != nil { | ||||
| 			return false, err | ||||
| 		} | ||||
| 
 | ||||
| 		build, err = job.GetLastBuild(context.TODO()) | ||||
| 		if err != nil { | ||||
| 			return false, err | ||||
| 		} | ||||
| 
 | ||||
| 		By("evaluating correctness of the outcome") | ||||
| 		return build.IsGood(), err | ||||
| 		return build.IsGood(context.TODO()), err | ||||
| 	}, time.Duration(110)*retryInterval, retryInterval).Should(BeTrue()) | ||||
| } | ||||
|  |  | |||
|  | @ -6,7 +6,7 @@ import ( | |||
| 	"testing" | ||||
| 
 | ||||
| 	"github.com/jenkinsci/kubernetes-operator/api/v1alpha2" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/controllers" | ||||
| 	controllers "github.com/jenkinsci/kubernetes-operator/internal/controller" | ||||
| 	jenkinsClient "github.com/jenkinsci/kubernetes-operator/pkg/client" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/constants" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/pkg/event" | ||||
|  | @ -19,7 +19,6 @@ import ( | |||
| 	"k8s.io/client-go/kubernetes/scheme" | ||||
| 	ctrl "sigs.k8s.io/controller-runtime" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/envtest" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer" | ||||
| 	logf "sigs.k8s.io/controller-runtime/pkg/log" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/log/zap" | ||||
| 	// +kubebuilder:scaffold:imports
 | ||||
|  | @ -34,9 +33,7 @@ func init() { | |||
| func TestAPIs(t *testing.T) { | ||||
| 	RegisterFailHandler(Fail) | ||||
| 
 | ||||
| 	RunSpecsWithDefaultAndCustomReporters(t, | ||||
| 		"Controller Suite", | ||||
| 		[]Reporter{printer.NewlineReporter{}}) | ||||
| 	RunSpecs(t, "Controller Suite") | ||||
| } | ||||
| 
 | ||||
| var _ = BeforeSuite(func(done Done) { | ||||
|  |  | |||
|  | @ -21,7 +21,7 @@ import ( | |||
| 	"sigs.k8s.io/controller-runtime/pkg/envtest" | ||||
| ) | ||||
| 
 | ||||
| const JenkinsTestImage = "jenkins/jenkins:2.462.3-lts" | ||||
| const JenkinsTestImage = "jenkins/jenkins:2.479.2-lts" | ||||
| 
 | ||||
| var ( | ||||
| 	Cfg       *rest.Config | ||||
|  | @ -41,6 +41,7 @@ func CreateNamespace() *corev1.Namespace { | |||
| 			Name: fmt.Sprintf("ns%d", time.Now().Unix()), | ||||
| 		}, | ||||
| 	} | ||||
| 
 | ||||
| 	gomega.Expect(K8sClient.Create(context.TODO(), namespace)).Should(gomega.Succeed()) | ||||
| 	return namespace | ||||
| } | ||||
|  | @ -97,7 +98,7 @@ func RenderJenkinsCR(name, namespace string, seedJob *[]v1alpha2.SeedJob, groovy | |||
| 							}, | ||||
| 						}, | ||||
| 						ReadinessProbe: &corev1.Probe{ | ||||
| 							Handler: corev1.Handler{ | ||||
| 							ProbeHandler: corev1.ProbeHandler{ | ||||
| 								HTTPGet: &corev1.HTTPGetAction{ | ||||
| 									Path:   "/login", | ||||
| 									Port:   intstr.FromString("http"), | ||||
|  | @ -111,7 +112,7 @@ func RenderJenkinsCR(name, namespace string, seedJob *[]v1alpha2.SeedJob, groovy | |||
| 							PeriodSeconds:       int32(1), | ||||
| 						}, | ||||
| 						LivenessProbe: &corev1.Probe{ | ||||
| 							Handler: corev1.Handler{ | ||||
| 							ProbeHandler: corev1.ProbeHandler{ | ||||
| 								HTTPGet: &corev1.HTTPGetAction{ | ||||
| 									Path:   "/login", | ||||
| 									Port:   intstr.FromString("http"), | ||||
|  |  | |||
|  | @ -34,7 +34,7 @@ func WaitForJenkinsBaseConfigurationToComplete(jenkins *v1alpha2.Jenkins) { | |||
| 		} | ||||
| 
 | ||||
| 		return actualJenkins.Status.BaseConfigurationCompletedTime, nil | ||||
| 	}, time.Duration(170)*retryInterval, retryInterval).Should(gomega.Not(gomega.BeNil())) | ||||
| 	}, time.Duration(250)*retryInterval, retryInterval).Should(gomega.Not(gomega.BeNil())) | ||||
| 
 | ||||
| 	_, _ = fmt.Fprintf(ginkgo.GinkgoWriter, "Jenkins pod is running\n") | ||||
| 
 | ||||
|  | @ -63,7 +63,7 @@ func waitForRecreateJenkinsMasterPod(jenkins *v1alpha2.Jenkins) { | |||
| 		} | ||||
| 
 | ||||
| 		return pods.Items[0].DeletionTimestamp == nil, nil | ||||
| 	}, 30*retryInterval, retryInterval).Should(gomega.BeTrue()) | ||||
| 	}, 50*retryInterval, retryInterval).Should(gomega.BeTrue()) | ||||
| 
 | ||||
| 	_, _ = fmt.Fprintf(ginkgo.GinkgoWriter, "Jenkins pod has been recreated\n") | ||||
| } | ||||
|  | @ -78,7 +78,7 @@ func WaitForJenkinsUserConfigurationToComplete(jenkins *v1alpha2.Jenkins) { | |||
| 			return nil, err | ||||
| 		} | ||||
| 		return actualJenkins.Status.UserConfigurationCompletedTime, nil | ||||
| 	}, time.Duration(110)*retryInterval, retryInterval).Should(gomega.Not(gomega.BeNil())) | ||||
| 	}, time.Duration(200)*retryInterval, retryInterval).Should(gomega.Not(gomega.BeNil())) | ||||
| 	_, _ = fmt.Fprintf(ginkgo.GinkgoWriter, "Jenkins instance is up and ready\n") | ||||
| } | ||||
| 
 | ||||
|  | @ -87,7 +87,7 @@ func waitForJenkinsSafeRestart(jenkinsClient jenkinsclient.Jenkins) { | |||
| 	ginkgo.By("waiting for Jenkins safe restart") | ||||
| 
 | ||||
| 	gomega.Eventually(func() (bool, error) { | ||||
| 		status, err := jenkinsClient.Poll() | ||||
| 		status, err := jenkinsClient.Poll(context.TODO()) | ||||
| 		_, _ = fmt.Fprintf(ginkgo.GinkgoWriter, "Safe restart status: %+v, err: %s\n", status, err) | ||||
| 		if err != nil { | ||||
| 			return false, err | ||||
|  | @ -96,5 +96,5 @@ func waitForJenkinsSafeRestart(jenkinsClient jenkinsclient.Jenkins) { | |||
| 			return false, err | ||||
| 		} | ||||
| 		return true, nil | ||||
| 	}, time.Duration(170)*retryInterval, retryInterval).Should(gomega.BeTrue()) | ||||
| 	}, time.Duration(250)*retryInterval, retryInterval).Should(gomega.BeTrue()) | ||||
| } | ||||
|  |  | |||
|  | @ -47,7 +47,7 @@ var _ = Describe("Jenkins Controller", func() { | |||
| 
 | ||||
| 			cmd := exec.Command("../../bin/helm", "upgrade", "jenkins", "../../chart/jenkins-operator", "--namespace", namespace.Name, "--debug", | ||||
| 				"--set-string", fmt.Sprintf("jenkins.namespace=%s", namespace.Name), | ||||
| 				"--set-string", fmt.Sprintf("jenkins.image=%s", "jenkins/jenkins:2.462.3-lts"), | ||||
| 				"--set-string", fmt.Sprintf("jenkins.image=%s", "jenkins/jenkins:2.479.2-lts"), | ||||
| 				"--set-string", fmt.Sprintf("operator.image=%s", *imageName), | ||||
| 				"--set-string", fmt.Sprintf("backup.image=%s", "quay.io/jenkins-kubernetes-operator/backup-pvc:e2e-test"), | ||||
| 				"--set-string", fmt.Sprintf("jenkins.imagePullPolicy=%s", "IfNotPresent"), "--install") | ||||
|  |  | |||
|  | @ -2,17 +2,16 @@ package helm | |||
| 
 | ||||
| import ( | ||||
| 	"flag" | ||||
| 	"testing" | ||||
| 
 | ||||
| 	"github.com/jenkinsci/kubernetes-operator/api/v1alpha2" | ||||
| 	"github.com/jenkinsci/kubernetes-operator/test/e2e" | ||||
| 	"k8s.io/apimachinery/pkg/runtime" | ||||
| 	"k8s.io/client-go/kubernetes/scheme" | ||||
| 
 | ||||
| 	. "github.com/onsi/ginkgo" | ||||
| 	. "github.com/onsi/gomega" | ||||
| 	"k8s.io/client-go/kubernetes/scheme" | ||||
| 	ctrl "sigs.k8s.io/controller-runtime" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/envtest" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer" | ||||
| 	logf "sigs.k8s.io/controller-runtime/pkg/log" | ||||
| 	"sigs.k8s.io/controller-runtime/pkg/log/zap" | ||||
| 	// +kubebuilder:scaffold:imports
 | ||||
|  | @ -27,13 +26,11 @@ func init() { | |||
| 	imageName = flag.String("image-name", "", "Name of the locally built for testing Jenkins Operator Image.") | ||||
| } | ||||
| 
 | ||||
| func TestHelm(t *testing.T) { | ||||
| 	RegisterFailHandler(Fail) | ||||
| // func TestHelm(t *testing.T) {
 | ||||
| // 	RegisterFailHandler(Fail)
 | ||||
| 
 | ||||
| 	RunSpecsWithDefaultAndCustomReporters(t, | ||||
| 		"Controller Suite", | ||||
| 		[]Reporter{printer.NewlineReporter{}}) | ||||
| } | ||||
| // 	RunSpecs(t, "Controller Suite")
 | ||||
| // }
 | ||||
| 
 | ||||
| var _ = BeforeSuite(func(done Done) { | ||||
| 	logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(false))) | ||||
|  | @ -43,12 +40,14 @@ var _ = BeforeSuite(func(done Done) { | |||
| 	testEnv = &envtest.Environment{ | ||||
| 		UseExistingCluster: &useExistingCluster, | ||||
| 	} | ||||
| 
 | ||||
| 	var err error | ||||
| 	// cfg is defined in this file globally.
 | ||||
| 	cfg, err := testEnv.Start() | ||||
| 	Expect(err).NotTo(HaveOccurred()) | ||||
| 	Expect(cfg).NotTo(BeNil()) | ||||
| 
 | ||||
| 	err = v1alpha2.AddToScheme(scheme.Scheme) | ||||
| 	//TODO @ansh-devs
 | ||||
| 	some := runtime.NewScheme() | ||||
| 	err = v1alpha2.AddToScheme(some) | ||||
| 	Expect(err).NotTo(HaveOccurred()) | ||||
| 
 | ||||
| 	// +kubebuilder:scaffold:scheme
 | ||||
|  |  | |||
							
								
								
									
										24
									
								
								variables.mk
								
								
								
								
							
							
						
						
									
										24
									
								
								variables.mk
								
								
								
								
							|  | @ -45,7 +45,7 @@ VERSION_TAG := $(VERSION) | |||
| LATEST_TAG := latest | ||||
| BUILD_TAG := $(GITBRANCH)-$(GITCOMMIT) | ||||
| 
 | ||||
| BUILD_PATH := ./ | ||||
| BUILD_PATH := ./cmd/main.go | ||||
| 
 | ||||
| # CONTAINER_RUNTIME_COMMAND is Container Runtime - it could be docker or podman
 | ||||
| CONTAINER_RUNTIME_COMMAND := docker | ||||
|  | @ -80,7 +80,18 @@ MEMORY_AMOUNT = 4096 | |||
| ##################### FROM OPERATOR SDK ########################
 | ||||
| 
 | ||||
| # Default bundle image tag
 | ||||
| BUNDLE_IMG ?= controller-bundle:$(VERSION) | ||||
| IMAGE_TAG_BASE ?= quay.io/jenkins-kubernetes-operator | ||||
| # BUNDLE_GEN_FLAGS are the flags passed to the operator-sdk generate bundle command
 | ||||
| BUNDLE_GEN_FLAGS ?= -q --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS) | ||||
| 
 | ||||
| # USE_IMAGE_DIGESTS defines if images are resolved via tags or digests
 | ||||
| # You can enable this value if you would like to use SHA Based Digests
 | ||||
| # To enable set flag to true
 | ||||
| USE_IMAGE_DIGESTS ?= false | ||||
| ifeq ($(USE_IMAGE_DIGESTS), true) | ||||
|     BUNDLE_GEN_FLAGS += --use-image-digests | ||||
| endif | ||||
| BUNDLE_IMG ?= $(IMAGE_TAG_BASE)-bundle:v$(VERSION) | ||||
| # Options for 'bundle-build'
 | ||||
| ifneq ($(origin CHANNELS), undefined) | ||||
| BUNDLE_CHANNELS := --channels=$(CHANNELS) | ||||
|  | @ -93,7 +104,6 @@ BUNDLE_METADATA_OPTS ?= $(BUNDLE_CHANNELS) $(BUNDLE_DEFAULT_CHANNEL) | |||
| # Image URL to use all building/pushing image targets
 | ||||
| IMG ?= controller:latest | ||||
| # Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
 | ||||
| CRD_OPTIONS ?= "crd:trivialVersions=true,preserveUnknownFields=false" | ||||
| 
 | ||||
| # Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
 | ||||
| ifeq (,$(shell go env GOBIN)) | ||||
|  | @ -101,7 +111,15 @@ GOBIN=$(shell go env GOPATH)/bin | |||
| else | ||||
| GOBIN=$(shell go env GOBIN) | ||||
| endif | ||||
| # Setting SHELL to bash allows bash commands to be executed by recipes.
 | ||||
| # This is a requirement for 'setup-envtest.sh' in the test target.
 | ||||
| # Options are set to exit when a recipe line exits non-zero or a piped command fails.
 | ||||
| SHELL = /usr/bin/env bash -o pipefail | ||||
| .SHELLFLAGS = -ec | ||||
| all: build | ||||
| 
 | ||||
| ENVTEST_ASSETS_DIR=$(shell pwd)/testbin | ||||
| 
 | ||||
| PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST)))) | ||||
| OS = $(shell go env GOOS) | ||||
| ARCH = $(shell go env GOARCH) | ||||
|  |  | |||
		Loading…
	
		Reference in New Issue