#54 Improve tests

This commit is contained in:
Jakub Al-Khalili 2019-07-23 09:16:38 +02:00
parent 4d2cab5109
commit 2dabc773d4
1 changed files with 13 additions and 0 deletions

View File

@ -132,6 +132,7 @@ func TestGroovy_EnsureSingle(t *testing.T) {
defer ctrl.Finish() defer ctrl.Finish()
jenkinsClient := jenkinsclient.NewMockJenkins(ctrl) jenkinsClient := jenkinsclient.NewMockJenkins(ctrl)
jenkinsClient.EXPECT().ExecuteScript(groovyScript).Return("logs", nil)
jenkinsClient.EXPECT().ExecuteScript(groovyScript).Return("logs", nil) jenkinsClient.EXPECT().ExecuteScript(groovyScript).Return("logs", nil)
jenkinsClient.EXPECT().ExecuteScript(groovyScript).Return("logs", nil) jenkinsClient.EXPECT().ExecuteScript(groovyScript).Return("logs", nil)
@ -163,6 +164,18 @@ func TestGroovy_EnsureSingle(t *testing.T) {
assert.Equal(t, anotherHash, jenkins.Status.AppliedGroovyScripts[0].Hash) assert.Equal(t, anotherHash, jenkins.Status.AppliedGroovyScripts[0].Hash)
assert.Equal(t, source, jenkins.Status.AppliedGroovyScripts[0].Source) assert.Equal(t, source, jenkins.Status.AppliedGroovyScripts[0].Source)
assert.Equal(t, groovyScriptName, jenkins.Status.AppliedGroovyScripts[0].Name) assert.Equal(t, groovyScriptName, jenkins.Status.AppliedGroovyScripts[0].Name)
requeue, err = groovyClient.EnsureSingle(source, groovyScriptName, hash, groovyScript)
require.NoError(t, err)
assert.True(t, requeue)
err = fakeClient.Get(ctx, types.NamespacedName{Name: jenkins.Name, Namespace: jenkins.Namespace}, jenkins)
require.NoError(t, err)
assert.Equal(t, 1, len(jenkins.Status.AppliedGroovyScripts))
assert.Equal(t, configurationType, jenkins.Status.AppliedGroovyScripts[0].ConfigurationType)
assert.Equal(t, hash, jenkins.Status.AppliedGroovyScripts[0].Hash)
assert.Equal(t, source, jenkins.Status.AppliedGroovyScripts[0].Source)
assert.Equal(t, groovyScriptName, jenkins.Status.AppliedGroovyScripts[0].Name)
}) })
t.Run("execute script fails", func(t *testing.T) { t.Run("execute script fails", func(t *testing.T) {
// given // given