lint with golangci-lint

test/e2e/configuration_test.go

@@ -22,13 +22,15 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+const e2e = "e2e"
+
 func TestConfiguration(t *testing.T) {
 	t.Parallel()
 	namespace, ctx := setupTest(t)
 
 	defer showLogsAndCleanup(t, ctx)
 
-	jenkinsCRName := "e2e"
+	jenkinsCRName := e2e
 	numberOfExecutors := 6
 	numberOfExecutorsEnvName := "NUMBER_OF_EXECUTORS"
 	systemMessage := "Configuration as Code integration works!!!"
@@ -207,7 +209,7 @@ unclassified:
 func createDefaultLimitsForContainersInNamespace(t *testing.T, namespace string) {
 	limitRange := &corev1.LimitRange{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      "e2e",
+			Name:      e2e,
 			Namespace: namespace,
 		},
 		Spec: corev1.LimitRangeSpec{

test/e2e/seedjobs_test.go

@@ -76,7 +76,7 @@ func loadSeedJobsConfig(t *testing.T) seedJobsConfig {
 	assert.NoError(t, err)
 
 	var result seedJobsConfig
-	err = json.Unmarshal([]byte(byteValue), &result)
+	err = json.Unmarshal(byteValue, &result)
 	assert.NoError(t, err)
 	assert.NotEmpty(t, result.SeedJobs)
 	return result
@@ -95,7 +95,7 @@ func createKubernetesCredentialsProviderSecret(t *testing.T, namespace string, c
 				"jenkins.io/credentials-description": "credentials from Kubernetes " + config.ID,
 			},
 			Labels: map[string]string{
-				seedjobs.JenkinsCredentialTypeLabelName: string(config.CredentialID),
+				seedjobs.JenkinsCredentialTypeLabelName: config.CredentialID,
 			},
 		},
 		StringData: map[string]string{