public_git/kubernetes-operator
1
0
Fork 0
mirror of https://github.com/jenkinsci/kubernetes-operator.git synced 2026-10-19 09:10:58 +02:00
Code Issues Releases Wiki Activity

lint with golangci-lint

Browse Source
This commit is contained in:
jkhelil
2020-05-06 16:22:52 +02:00
parent eb8b2e32e8
commit 128c97be6b
46 changed files with 394 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/controller/jenkins/plugins/base_plugins.go
+2 -2
View File
@@ -10,7 +10,7 @@ const (
workflowJobPlugin = "workflow-job:2.38"
)
// basePluginsList contains plugins to install by operator
// basePluginsList contains plugins to install by operator.
var basePluginsList = []Plugin{
Must(New(kubernetesPlugin)),
Must(New(workflowJobPlugin)),
@@ -21,7 +21,7 @@ var basePluginsList = []Plugin{
Must(New(kubernetesCredentialsProviderPlugin)),
}
// BasePlugins returns list of plugins to install by operator
// BasePlugins returns list of plugins to install by operator.
func BasePlugins() []Plugin {
return basePluginsList
}
pkg/controller/jenkins/plugins/plugin.go
+5 -5
View File
@@ -8,7 +8,7 @@ import (
"github.com/pkg/errors"
)
// Plugin represents jenkins plugin
// Plugin represents jenkins plugin.
type Plugin struct {
Name string `json:"name"`
Version string `json:"version"`
@@ -29,7 +29,7 @@ var (
DownloadURLPattern = regexp.MustCompile(`https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)`)
)
// New creates plugin from string, for example "name-of-plugin:0.0.1"
// New creates plugin from string, for example "name-of-plugin:0.0.1".
func New(nameWithVersion string) (*Plugin, error) {
val := strings.SplitN(nameWithVersion, ":", 2)
if val == nil || len(val) != 2 {
@@ -48,7 +48,7 @@ func New(nameWithVersion string) (*Plugin, error) {
}, nil
}
// NewPlugin creates plugin from name and version, for example "name-of-plugin:0.0.1"
// NewPlugin creates plugin from name and version, for example "name-of-plugin:0.0.1".
func NewPlugin(name, version, downloadURL string) (*Plugin, error) {
if err := validatePlugin(name, version, downloadURL); err != nil {
return nil, err
@@ -76,7 +76,7 @@ func validatePlugin(name, version, downloadURL string) error {
return nil
}
// Must returns plugin from pointer and throws panic when error is set
// Must returns plugin from pointer and throws panic when error is set.
func Must(plugin *Plugin, err error) Plugin {
if err != nil {
panic(err)
@@ -85,7 +85,7 @@ func Must(plugin *Plugin, err error) Plugin {
return *plugin
}
// VerifyDependencies checks if all plugins have compatible versions
// VerifyDependencies checks if all plugins have compatible versions.
func VerifyDependencies(values ...map[Plugin][]Plugin) []string {
var messages []string
// key - plugin name, value array of versions