fix: seed job warnings, updated latest lts and plugins (#1018)

test/bats/1-deploy.bats

@@ -33,8 +33,14 @@ diag() {
     --set namespace=${DETIK_CLIENT_NAMESPACE} \
     --set operator.image=${OPERATOR_IMAGE} \
     --set jenkins.latestPlugins=true \
-    --set jenkins.image="jenkins/jenkins:2.440.1-lts" \
+    --set jenkins.image="jenkins/jenkins:2.452.1-lts" \
     --set jenkins.backup.makeBackupBeforePodDeletion=false \
+    --set jenkins.seedJobs[0].id=seed-job \
+    --set jenkins.seedJobs[0].targets="cicd/jobs/*.jenkins" \
+    --set jenkins.seedJobs[0].description="jobs-from-operator-repo" \
+    --set jenkins.seedJobs[0].repositoryBranch=master \
+    --set jenkins.seedJobs[0].repositoryUrl=https://github.com/jenkinsci/kubernetes-operator \
+    --set jenkins.seedJobs[0].buildPeriodically="10 * * * *" \
     jenkins-operator/jenkins-operator --version=$(cat VERSION.txt | sed 's/v//')
   assert_success
   assert ${HELM} status default
@@ -118,7 +124,25 @@ diag() {
 }
 
 #bats test_tags=phase:helm,scenario:vanilla
-@test "1.10 Helm: upgrade from main branch same values" {
+@test "1.10 Helm: check Jenkins seed job status and logs" {
+  [[ ! -f "chart/jenkins-operator/deploy.tmp" ]] && skip "Jenkins helm chart have not been deployed correctly"
+  run verify "there is 1 deployment named 'seed-job-agent-jenkins'"
+  assert_success
+
+  run verify "there is 1 pod named 'seed-job-agent-jenkins-'"
+  assert_success
+
+  run try "at most 20 times every 10s to get pods named 'seed-job-agent-jenkins-' and verify that '.status.containerStatuses[?(@.name==\"jnlp\")].ready' is 'true'"
+  assert_success
+
+  run ${KUBECTL} logs -l app=seed-job-agent-selector
+  assert_success
+  assert_output --partial 'INFO: Connected'
+
+}
+
+#bats test_tags=phase:helm,scenario:vanilla
+@test "1.11 Helm: upgrade from main branch same values" {
   run echo ${DETIK_CLIENT_NAMESPACE}
   run echo ${OPERATOR_IMAGE}
   run ${HELM} upgrade default \
@@ -126,7 +150,7 @@ diag() {
     --set namespace=${DETIK_CLIENT_NAMESPACE} \
     --set operator.image=${OPERATOR_IMAGE} \
     --set jenkins.latestPlugins=true \
-    --set jenkins.image="jenkins/jenkins:2.440.1-lts" \
+    --set jenkins.image="jenkins/jenkins:2.452.1-lts" \
     --set jenkins.backup.makeBackupBeforePodDeletion=false \
     chart/jenkins-operator
   assert_success
@@ -134,7 +158,7 @@ diag() {
 }
 
 #bats test_tags=phase:helm,scenario:vanilla
-@test "1.11 Helm: check Jenkins operator pods status again" {
+@test "1.12 Helm: check Jenkins operator pods status again" {
   [[ ! -f "chart/jenkins-operator/deploy.tmp" ]] && skip "Jenkins helm chart have not been deployed correctly"
   run verify "there is 1 deployment named 'default-jenkins-operator'"
   assert_success
@@ -147,7 +171,7 @@ diag() {
 }
 
 #bats test_tags=phase:helm,scenario:vanilla
-@test "1.12 Helm: check Jenkins operator pods status" {
+@test "1.13 Helm: check Jenkins operator pods status" {
   [[ ! -f "chart/jenkins-operator/deploy.tmp" ]] && skip "Jenkins helm chart have not been deployed correctly"
   run verify "there is 1 deployment named 'default-jenkins-operator'"
   assert_success
@@ -160,7 +184,7 @@ diag() {
 }
 
 #bats test_tags=phase:helm,scenario:vanilla
-@test "1.13 Helm: check Jenkins Pod status" {
+@test "1.14 Helm: check Jenkins Pod status" {
   [[ ! -f "chart/jenkins-operator/deploy.tmp" ]] && skip "Jenkins helm chart have not been deployed correctly"
   run try "at most 20 times every 10s to get pods named 'jenkins-jenkins' and verify that '.status.containerStatuses[?(@.name==\"jenkins-master\")].ready' is 'true'"
   assert_success
@@ -170,7 +194,7 @@ diag() {
 }
 
 #bats test_tags=phase:helm,scenario:vanilla
-@test "1.14 Helm: clean" {
+@test "1.15 Helm: clean" {
   run ${HELM} uninstall default
   assert_success
   # Wait for the complete removal

test/bats/2-deploy-with-more-options.bats

@@ -29,7 +29,7 @@ setup() {
     --set operator.image=${OPERATOR_IMAGE} \
     --set jenkins.latestPlugins=true \
     --set jenkins.nodeSelector.batstest=yep \
-    --set jenkins.image="jenkins/jenkins:2.440.1-lts" \
+    --set jenkins.image="jenkins/jenkins:2.452.1-lts" \
     --set jenkins.backup.makeBackupBeforePodDeletion=false \
     jenkins-operator/jenkins-operator --version=$(cat VERSION.txt | sed 's/v//')
   assert_success
@@ -101,7 +101,7 @@ setup() {
     --set operator.image=${OPERATOR_IMAGE} \
     --set jenkins.latestPlugins=true \
     --set jenkins.nodeSelector.batstest=yep \
-    --set jenkins.image="jenkins/jenkins:2.440.1-lts" \
+    --set jenkins.image="jenkins/jenkins:2.452.1-lts" \
     --set jenkins.backup.makeBackupBeforePodDeletion=false \
     chart/jenkins-operator
   assert_success

test/bats/3-deploy-with-webhook.bats

@@ -29,7 +29,7 @@ setup() {
     --set namespace=${DETIK_CLIENT_NAMESPACE} \
     --set operator.image=${OPERATOR_IMAGE} \
     --set jenkins.latestPlugins=true \
-    --set jenkins.image="jenkins/jenkins:2.440.1-lts" \
+    --set jenkins.image="jenkins/jenkins:2.452.1-lts" \
     --set jenkins.backup.makeBackupBeforePodDeletion=true \
     --set webhook.enabled=true \
     jenkins-operator/jenkins-operator --version=$(cat VERSION.txt | sed 's/v//')
@@ -86,7 +86,7 @@ setup() {
     --set namespace=${DETIK_CLIENT_NAMESPACE} \
     --set operator.image=${OPERATOR_IMAGE} \
     --set jenkins.latestPlugins=true \
-    --set jenkins.image="jenkins/jenkins:2.440.1-lts" \
+    --set jenkins.image="jenkins/jenkins:2.452.1-lts" \
     --set jenkins.backup.makeBackupBeforePodDeletion=true \
     --set webhook.enabled=true \
     chart/jenkins-operator

test/e2e/configuration_test.go

@@ -24,13 +24,13 @@ import (
 const e2e = "e2e"
 
 var expectedBasePluginsList = []plugins.Plugin{
-	plugins.Must(plugins.New("configuration-as-code:1775.v810dc950b_514")),
-	plugins.Must(plugins.New("git:5.2.1")),
-	plugins.Must(plugins.New("kubernetes:4186.v1d804571d5d4")),
-	plugins.Must(plugins.New("kubernetes-credentials-provider:1.258.v95949f923a_a_e")),
+	plugins.Must(plugins.New("configuration-as-code:1810.v9b_c30a_249a_4c")),
+	plugins.Must(plugins.New("git:5.2.2")),
+	plugins.Must(plugins.New("kubernetes:4238.v41b_3ef14a_5d8")),
+	plugins.Must(plugins.New("kubernetes-credentials-provider:1.262.v2670ef7ea_0c5")),
 	plugins.Must(plugins.New("job-dsl:1.87")),
 	plugins.Must(plugins.New("workflow-aggregator:596.v8c21c963d92d")),
-	plugins.Must(plugins.New("workflow-job:1385.vb_58b_86ea_fff1")),
+	plugins.Must(plugins.New("workflow-job:1400.v7fd111b_ec82f")),
 }
 
 func createUserConfigurationSecret(namespace string, stringData map[string]string) {

test/e2e/test_utility.go

@@ -21,7 +21,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest"
 )
 
-const JenkinsTestImage = "jenkins/jenkins:2.440.1-lts"
+const JenkinsTestImage = "jenkins/jenkins:2.452.1-lts"
 
 var (
 	Cfg       *rest.Config

test/helm/helm_test.go

@@ -47,7 +47,7 @@ var _ = Describe("Jenkins Controller", func() {
 
 			cmd := exec.Command("../../bin/helm", "upgrade", "jenkins", "../../chart/jenkins-operator", "--namespace", namespace.Name, "--debug",
 				"--set-string", fmt.Sprintf("jenkins.namespace=%s", namespace.Name),
-				"--set-string", fmt.Sprintf("jenkins.image=%s", "jenkins/jenkins:2.440.1-lts"),
+				"--set-string", fmt.Sprintf("jenkins.image=%s", "jenkins/jenkins:2.452.1-lts"),
 				"--set-string", fmt.Sprintf("operator.image=%s", *imageName), "--install")
 			output, err := cmd.CombinedOutput()
 			Expect(err).NotTo(HaveOccurred(), string(output))